From: Shiraz Hashim <shiraz.hashim@st.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linus.walleij@linaro.org, grant.likely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, spear-devel@list.st.com,
Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio
Date: Fri, 23 Nov 2012 18:00:48 +0530 [thread overview]
Message-ID: <20121123123048.GM5384@localhost.localdomain> (raw)
In-Reply-To: <20121123121413.GB22268@gmail.com>
On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote:
> > >> + if (np)
> > >> + of_property_read_u32(np, "st,norequest-mask",
> > >> + &pdata->norequest_mask);
> > >
> > > Can you explain to me what this does?
> >
> > You mean pdata->norequest_mask? It marks few gpios as unusable.
> > Because these pads might be used by other blocks of stmpe.
>
> I'm not sure if that should be set with DT or not.
>
> Second opinion anyone?
This is a board dependent parameter which just informs gpio driver
about pins, which must not be requested. It may happen for a stmpe
variant where such gpio pins are multiplexed with some other
function.
Hence it must be part of DT itself.
--
regards
Shiraz
WARNING: multiple messages have this Message-ID (diff)
From: Shiraz Hashim <shiraz.hashim@st.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
<linus.walleij@linaro.org>, <grant.likely@secretlab.ca>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, <spear-devel@list.st.com>,
Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio
Date: Fri, 23 Nov 2012 18:00:48 +0530 [thread overview]
Message-ID: <20121123123048.GM5384@localhost.localdomain> (raw)
In-Reply-To: <20121123121413.GB22268@gmail.com>
On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote:
> > >> + if (np)
> > >> + of_property_read_u32(np, "st,norequest-mask",
> > >> + &pdata->norequest_mask);
> > >
> > > Can you explain to me what this does?
> >
> > You mean pdata->norequest_mask? It marks few gpios as unusable.
> > Because these pads might be used by other blocks of stmpe.
>
> I'm not sure if that should be set with DT or not.
>
> Second opinion anyone?
This is a board dependent parameter which just informs gpio driver
about pins, which must not be requested. It may happen for a stmpe
variant where such gpio pins are multiplexed with some other
function.
Hence it must be part of DT itself.
--
regards
Shiraz
next prev parent reply other threads:[~2012-11-23 12:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:51 [PATCH] gpio: stmpe: Add DT support for stmpe gpio Viresh Kumar
2012-11-23 10:34 ` Lee Jones
2012-11-23 10:41 ` Lee Jones
[not found] ` <20121123104140.GP17471-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-23 10:47 ` Viresh Kumar
2012-11-23 10:47 ` Viresh Kumar
2012-11-23 10:43 ` Viresh Kumar
2012-11-23 12:14 ` Lee Jones
[not found] ` <20121123121413.GB22268-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-23 12:25 ` Viresh Kumar
2012-11-23 12:25 ` Viresh Kumar
2012-11-23 15:45 ` Lee Jones
2012-11-23 12:30 ` Shiraz Hashim [this message]
2012-11-23 12:30 ` Shiraz Hashim
2012-11-26 11:28 ` Lee Jones
2012-11-26 11:28 ` Lee Jones
2012-11-26 11:32 ` Shiraz Hashim
2012-11-26 11:32 ` Shiraz Hashim
2012-12-01 16:35 ` Linus Walleij
2012-12-01 18:31 ` Shiraz Hashim
2012-12-01 19:34 ` Linus Walleij
[not found] ` <CACRpkda6=UPW+Xy9ztkAtFvCMySt4iR8YabYNNTdnZBpVc98rQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-01 19:55 ` Linus Walleij
2012-12-01 19:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123123048.GM5384@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.