Re: [GIT PULL] ASoC: Samsung: Updates for v3.8

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1021 bytes --]

On Fri, Nov 23, 2012 at 06:27:19PM +0900, Sangbeom Kim wrote:

> Padmavathi Venna (2):
>       ASoC: SAMSUNG: Add DT support for i2s

There's some problems with this binding.  The main one is the gpios
property the format of which isn't specified at all.  The requirement
for an alias is also very odd, where does that come from?

Some of the code also looks very peculiar, like the fact that it's
generating a clock name i2s_opclk%d rather than hard coding the clock,
the physical clock would normally be resolved based on the struct
device.

>       ASoC: Samsung: Register the audio dma platform device

This isn't the normal approach here, the normal approach is that the I2S
device instantiates the DMA device it needs - see the Tegra or i.MX
drivers for examples.  I'm also concerned that this is going to collide
with the existing static registrations that non-DT boards do.

> Sachin Kamat (1):
>       ASoC: Samsung-dma: Fix potential NULL pointer dereference

This should be sent separately as a bug fix patch.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]