* [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' @ 2012-11-25 23:13 kbuild test robot 2012-11-25 23:51 ` Chris Ball 2012-11-26 5:54 ` Huang Changming-R66093 0 siblings, 2 replies; 11+ messages in thread From: kbuild test robot @ 2012-11-25 23:13 UTC (permalink / raw) To: Haijun Zhang; +Cc: linux-mmc, Jerry Huang, Chris Ball tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: Use u64 to calculate the timeout value to avoid overflow config: make ARCH=arm omap2plus_defconfig All error/warnings: drivers/built-in.o: In function `mmc_omap_start_request': of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-25 23:13 [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' kbuild test robot @ 2012-11-25 23:51 ` Chris Ball 2012-11-26 4:11 ` Zhang Haijun-B42677 2012-11-26 10:02 ` Zhang Haijun-B42677 2012-11-26 5:54 ` Huang Changming-R66093 1 sibling, 2 replies; 11+ messages in thread From: Chris Ball @ 2012-11-25 23:51 UTC (permalink / raw) To: kbuild test robot; +Cc: Haijun Zhang, linux-mmc, Jerry Huang Hi, On Sun, Nov 25 2012, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: > Use u64 to calculate the timeout value to avoid overflow > config: make ARCH=arm omap2plus_defconfig > > All error/warnings: > > drivers/built-in.o: In function `mmc_omap_start_request': > of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' I've removed Haijun's three patches from mmc-next while they're reworked to fix this. Thanks! - Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-25 23:51 ` Chris Ball @ 2012-11-26 4:11 ` Zhang Haijun-B42677 2012-11-26 10:02 ` Zhang Haijun-B42677 1 sibling, 0 replies; 11+ messages in thread From: Zhang Haijun-B42677 @ 2012-11-26 4:11 UTC (permalink / raw) To: Chris Ball, kbuild test robot Cc: linux-mmc@vger.kernel.org, Huang Changming-R66093, Wang Dongsheng-B40534 Hi,Chris I had update my branch linux-mmc and test, there is no such err. As u64 need the macro div_u64 in "include/linux/math64.h" #ifndef div_u64 static inline u64 div_u64(u64 dividend, u32 divisor) { u32 remainder; return div_u64_rem(dividend, divisor, &remainder); } #endif As different vendor may redefine div_u64_rem or remove the func div_u64, it's possible. In driver/mmc/ all func use data->timeout_ns without define div_u64 or not use div_u64 to divide will encounter this err. So I'm not sure which reason bring about this err. Regards Haijun. > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Chris Ball > Sent: Monday, November 26, 2012 7:51 AM > To: kbuild test robot > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Huang Changming- > R66093 > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > Hi, > > On Sun, Nov 25 2012, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc- > next > > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > > commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: > > Use u64 to calculate the timeout value to avoid overflow > > config: make ARCH=arm omap2plus_defconfig > > > > All error/warnings: > > > > drivers/built-in.o: In function `mmc_omap_start_request': > > of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' > > I've removed Haijun's three patches from mmc-next while they're reworked > to fix this. Thanks! > > - Chris. > -- > Chris Ball <cjb@laptop.org> <http://printf.net/> > One Laptop Per Child > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-25 23:51 ` Chris Ball 2012-11-26 4:11 ` Zhang Haijun-B42677 @ 2012-11-26 10:02 ` Zhang Haijun-B42677 2012-12-14 2:52 ` Zhang Haijun-B42677 1 sibling, 1 reply; 11+ messages in thread From: Zhang Haijun-B42677 @ 2012-11-26 10:02 UTC (permalink / raw) To: Chris Ball, kbuild test robot Cc: linux-mmc@vger.kernel.org, Huang Changming-R66093 Hi Chris I see patches modified the public C file and Powerpc Host C file. But it also used by other host C file. So need to replace all the u64 division by macro div_u64 to avoid this error. Two new patches had send and reviewed by Anton. I think they can fix the `__aeabi_uldivmod' error. All the patches work fine on my branch. Regards Haijun. > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Chris Ball > Sent: Monday, November 26, 2012 7:51 AM > To: kbuild test robot > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Huang Changming- > R66093 > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > Hi, > > On Sun, Nov 25 2012, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc- > next > > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > > commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: > > Use u64 to calculate the timeout value to avoid overflow > > config: make ARCH=arm omap2plus_defconfig > > > > All error/warnings: > > > > drivers/built-in.o: In function `mmc_omap_start_request': > > of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' > > I've removed Haijun's three patches from mmc-next while they're reworked > to fix this. Thanks! > > - Chris. > -- > Chris Ball <cjb@laptop.org> <http://printf.net/> > One Laptop Per Child > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-26 10:02 ` Zhang Haijun-B42677 @ 2012-12-14 2:52 ` Zhang Haijun-B42677 2013-01-15 2:03 ` Zhang Haijun-B42677 0 siblings, 1 reply; 11+ messages in thread From: Zhang Haijun-B42677 @ 2012-12-14 2:52 UTC (permalink / raw) To: Chris Ball, kbuild test robot Cc: linux-mmc@vger.kernel.org, Huang Changming-R66093, Anton Vorontsov Hi, chris Two extra patches had been sent to fix these err. These patches had been Acked-by Anton. Could you please help review these patches again? Expect your comments. Thanks in advance. 1) Subject: [PATCH] Powerpc eSDHC: Use u64 to calculate the timeout value to avoid overflow 2) Subject: [PATCH 2/2 v3] mmc:core: Add limit to data and erase timeout value calculation 3) Subject: [PATCH 1/2 v5] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value Extra: 4) Subject: [PATCH 1/2 V2] mmc:block : Convert the cmd_timeou_ms to u64 to avoid overflow 5) Subject: [PATCH 2/2 V2] mmc:host: Use u64 to calculate the timeout value to avoid overflow Regards Haijun. > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Zhang Haijun-B42677 > Sent: Monday, November 26, 2012 6:03 PM > To: Chris Ball; kbuild test robot > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093 > Subject: RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > Hi Chris > > I see patches modified the public C file and Powerpc Host C file. But it > also used by other host C file. > So need to replace all the u64 division by macro div_u64 to avoid this > error. > Two new patches had send and reviewed by Anton. > I think they can fix the `__aeabi_uldivmod' error. > All the patches work fine on my branch. > > Regards > Haijun. > > > > -----Original Message----- > > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > > owner@vger.kernel.org] On Behalf Of Chris Ball > > Sent: Monday, November 26, 2012 7:51 AM > > To: kbuild test robot > > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Huang Changming- > > R66093 > > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): > > undefined reference to `__aeabi_uldivmod' > > > > Hi, > > > > On Sun, Nov 25 2012, kbuild test robot wrote: > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git > mmc- > > next > > > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > > > commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: > > > Use u64 to calculate the timeout value to avoid overflow > > > config: make ARCH=arm omap2plus_defconfig > > > > > > All error/warnings: > > > > > > drivers/built-in.o: In function `mmc_omap_start_request': > > > of_iommu.c:(.text+0x114dbc): undefined reference to > `__aeabi_uldivmod' > > > > I've removed Haijun's three patches from mmc-next while they're > > reworked to fix this. Thanks! > > > > - Chris. > > -- > > Chris Ball <cjb@laptop.org> <http://printf.net/> > > One Laptop Per Child > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > in the body of a message to majordomo@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-12-14 2:52 ` Zhang Haijun-B42677 @ 2013-01-15 2:03 ` Zhang Haijun-B42677 0 siblings, 0 replies; 11+ messages in thread From: Zhang Haijun-B42677 @ 2013-01-15 2:03 UTC (permalink / raw) To: Chris Ball, kbuild test robot Cc: linux-mmc@vger.kernel.org, Huang Changming-R66093, Anton Vorontsov, Zhang Haijun-B42677 Hi, chris Could you please help review these patches again? Expect your comments. Thanks in advance. Regards Haijun. > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Zhang Haijun-B42677 > Sent: Friday, December 14, 2012 10:52 AM > To: Chris Ball; kbuild test robot > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Anton Vorontsov > Subject: RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > Hi, chris > > Two extra patches had been sent to fix these err. > These patches had been Acked-by Anton. > Could you please help review these patches again? Expect your comments. > Thanks in advance. > > 1) Subject: [PATCH] Powerpc eSDHC: Use u64 to calculate the timeout > value to avoid overflow > 2) Subject: [PATCH 2/2 v3] mmc:core: Add limit to data and erase > timeout value calculation > 3) Subject: [PATCH 1/2 v5] Powerpc/eSDHC: Calculate the applicable mmc > erase timeout value > Extra: > 4) Subject: [PATCH 1/2 V2] mmc:block : Convert the cmd_timeou_ms to > u64 to avoid overflow > 5) Subject: [PATCH 2/2 V2] mmc:host: Use u64 to calculate the timeout > value to avoid overflow > > > Regards > Haijun. > > > -----Original Message----- > > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > > owner@vger.kernel.org] On Behalf Of Zhang Haijun-B42677 > > Sent: Monday, November 26, 2012 6:03 PM > > To: Chris Ball; kbuild test robot > > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093 > > Subject: RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): > > undefined reference to `__aeabi_uldivmod' > > > > Hi Chris > > > > I see patches modified the public C file and Powerpc Host C file. But > > it also used by other host C file. > > So need to replace all the u64 division by macro div_u64 to avoid this > > error. > > Two new patches had send and reviewed by Anton. > > I think they can fix the `__aeabi_uldivmod' error. > > All the patches work fine on my branch. > > > > Regards > > Haijun. > > > > > > > -----Original Message----- > > > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > > > owner@vger.kernel.org] On Behalf Of Chris Ball > > > Sent: Monday, November 26, 2012 7:51 AM > > > To: kbuild test robot > > > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Huang Changming- > > > R66093 > > > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): > > > undefined reference to `__aeabi_uldivmod' > > > > > > Hi, > > > > > > On Sun, Nov 25 2012, kbuild test robot wrote: > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git > > mmc- > > > next > > > > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > > > > commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: > > > > Use u64 to calculate the timeout value to avoid overflow > > > > config: make ARCH=arm omap2plus_defconfig > > > > > > > > All error/warnings: > > > > > > > > drivers/built-in.o: In function `mmc_omap_start_request': > > > > of_iommu.c:(.text+0x114dbc): undefined reference to > > `__aeabi_uldivmod' > > > > > > I've removed Haijun's three patches from mmc-next while they're > > > reworked to fix this. Thanks! > > > > > > - Chris. > > > -- > > > Chris Ball <cjb@laptop.org> <http://printf.net/> > > > One Laptop Per Child > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > > in the body of a message to majordomo@vger.kernel.org More majordomo > > > info at http://vger.kernel.org/majordomo-info.html > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > in the body of a message to majordomo@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-25 23:13 [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' kbuild test robot 2012-11-25 23:51 ` Chris Ball @ 2012-11-26 5:54 ` Huang Changming-R66093 2012-11-26 6:02 ` Fengguang Wu 1 sibling, 1 reply; 11+ messages in thread From: Huang Changming-R66093 @ 2012-11-26 5:54 UTC (permalink / raw) To: kbuild test robot, Zhang Haijun-B42677 Cc: linux-mmc@vger.kernel.org, Chris Ball Hi, Robot I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc tree. Could you point out which file use it? This patch just use the 'div_u64' to calculate the timeout in order to avoid overflow. Best Regards Jerry Huang > -----Original Message----- > From: kbuild test robot [mailto:fengguang.wu@intel.com] > Sent: Monday, November 26, 2012 7:14 AM > To: Zhang Haijun-B42677 > Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Chris Ball > Subject: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc- > next > head: b1dc46e6cd5f314f52a9864cc7ba1b7624b54bd7 > commit: d29254e21ddddee37b3c8525817398d96d6403f3 [45/63] mmc: core: Use > u64 to calculate the timeout value to avoid overflow > config: make ARCH=arm omap2plus_defconfig > > All error/warnings: > > drivers/built-in.o: In function `mmc_omap_start_request': > of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' > > --- > 0-DAY kernel build testing backend Open Source Technology Center > Fengguang Wu, Yuanhan Liu Intel Corporation ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-26 5:54 ` Huang Changming-R66093 @ 2012-11-26 6:02 ` Fengguang Wu 2012-11-26 6:12 ` Zhang Haijun-B42677 0 siblings, 1 reply; 11+ messages in thread From: Fengguang Wu @ 2012-11-26 6:02 UTC (permalink / raw) To: Huang Changming-R66093 Cc: Zhang Haijun-B42677, linux-mmc@vger.kernel.org, Chris Ball On Mon, Nov 26, 2012 at 05:54:33AM +0000, Huang Changming-R66093 wrote: > Hi, Robot > I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc tree. > Could you point out which file use it? > > This patch just use the 'div_u64' to calculate the timeout in order to avoid overflow. Hi! This is confirmed to fix the problem: diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 48ad361..daf0636 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -921,7 +921,7 @@ static inline void set_data_timeout(struct mmc_omap_host *host, struct mmc_reque u16 reg; cycle_ns = 1000000000 / host->current_slot->fclk_freq; - timeout = req->data->timeout_ns / cycle_ns; + timeout = div_u64(req->data->timeout_ns, cycle_ns); timeout += req->data->timeout_clks; /* Check if we need to use timeout multiplier register */ ^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-26 6:02 ` Fengguang Wu @ 2012-11-26 6:12 ` Zhang Haijun-B42677 2012-11-26 6:21 ` Fengguang Wu 0 siblings, 1 reply; 11+ messages in thread From: Zhang Haijun-B42677 @ 2012-11-26 6:12 UTC (permalink / raw) To: Fengguang Wu, Huang Changming-R66093 Cc: linux-mmc@vger.kernel.org, Chris Ball Thanks, Fengguang, did you use the same environment as Chris? If so that's just the reason caused the err. Regards Haijun. > -----Original Message----- > From: Fengguang Wu [mailto:fengguang.wu@intel.com] > Sent: Monday, November 26, 2012 2:03 PM > To: Huang Changming-R66093 > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > On Mon, Nov 26, 2012 at 05:54:33AM +0000, Huang Changming-R66093 wrote: > > Hi, Robot > > I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc > tree. > > Could you point out which file use it? > > > > This patch just use the 'div_u64' to calculate the timeout in order to > avoid overflow. > > Hi! This is confirmed to fix the problem: > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index > 48ad361..daf0636 100644 > --- a/drivers/mmc/host/omap.c > +++ b/drivers/mmc/host/omap.c > @@ -921,7 +921,7 @@ static inline void set_data_timeout(struct > mmc_omap_host *host, struct mmc_reque > u16 reg; > > cycle_ns = 1000000000 / host->current_slot->fclk_freq; > - timeout = req->data->timeout_ns / cycle_ns; > + timeout = div_u64(req->data->timeout_ns, cycle_ns); > timeout += req->data->timeout_clks; > > /* Check if we need to use timeout multiplier register */ ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-26 6:12 ` Zhang Haijun-B42677 @ 2012-11-26 6:21 ` Fengguang Wu 2012-11-26 7:23 ` Zhang Haijun-B42677 0 siblings, 1 reply; 11+ messages in thread From: Fengguang Wu @ 2012-11-26 6:21 UTC (permalink / raw) To: Zhang Haijun-B42677 Cc: Huang Changming-R66093, linux-mmc@vger.kernel.org, Chris Ball I don't understand your question... The question is, did Chris use the same environment detailed in the original report? Did he check out the right commit (d29254e21ddddee37b3c8525817398d96d6403f3) and used the right config (omap2plus_defconfig)? On Mon, Nov 26, 2012 at 06:12:24AM +0000, Zhang Haijun-B42677 wrote: > Thanks, Fengguang, did you use the same environment as Chris? > If so that's just the reason caused the err. > > Regards > Haijun. > > > > -----Original Message----- > > From: Fengguang Wu [mailto:fengguang.wu@intel.com] > > Sent: Monday, November 26, 2012 2:03 PM > > To: Huang Changming-R66093 > > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Chris Ball > > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > > reference to `__aeabi_uldivmod' > > > > On Mon, Nov 26, 2012 at 05:54:33AM +0000, Huang Changming-R66093 wrote: > > > Hi, Robot > > > I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of linux-mmc > > tree. > > > Could you point out which file use it? > > > > > > This patch just use the 'div_u64' to calculate the timeout in order to > > avoid overflow. > > > > Hi! This is confirmed to fix the problem: > > > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index > > 48ad361..daf0636 100644 > > --- a/drivers/mmc/host/omap.c > > +++ b/drivers/mmc/host/omap.c > > @@ -921,7 +921,7 @@ static inline void set_data_timeout(struct > > mmc_omap_host *host, struct mmc_reque > > u16 reg; > > > > cycle_ns = 1000000000 / host->current_slot->fclk_freq; > > - timeout = req->data->timeout_ns / cycle_ns; > > + timeout = div_u64(req->data->timeout_ns, cycle_ns); > > timeout += req->data->timeout_clks; > > > > /* Check if we need to use timeout multiplier register */ > ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' 2012-11-26 6:21 ` Fengguang Wu @ 2012-11-26 7:23 ` Zhang Haijun-B42677 0 siblings, 0 replies; 11+ messages in thread From: Zhang Haijun-B42677 @ 2012-11-26 7:23 UTC (permalink / raw) To: Fengguang Wu Cc: Huang Changming-R66093, linux-mmc@vger.kernel.org, Chris Ball Regards Haijun. > -----Original Message----- > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > owner@vger.kernel.org] On Behalf Of Fengguang Wu > Sent: Monday, November 26, 2012 2:22 PM > To: Zhang Haijun-B42677 > Cc: Huang Changming-R66093; linux-mmc@vger.kernel.org; Chris Ball > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined > reference to `__aeabi_uldivmod' > > I don't understand your question... The question is, did Chris use the > same environment detailed in the original report? [Haijun: ] yes, I mean that if you use the same environment detailed in Chris's mail. Including the config and the platform. No need yet, thank you anyway. Did he check out the > right commit (d29254e21ddddee37b3c8525817398d96d6403f3) and used the > right config (omap2plus_defconfig)? > > On Mon, Nov 26, 2012 at 06:12:24AM +0000, Zhang Haijun-B42677 wrote: > > Thanks, Fengguang, did you use the same environment as Chris? > > If so that's just the reason caused the err. > > > > Regards > > Haijun. > > > > > > > -----Original Message----- > > > From: Fengguang Wu [mailto:fengguang.wu@intel.com] > > > Sent: Monday, November 26, 2012 2:03 PM > > > To: Huang Changming-R66093 > > > Cc: Zhang Haijun-B42677; linux-mmc@vger.kernel.org; Chris Ball > > > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): > > > undefined reference to `__aeabi_uldivmod' > > > > > > On Mon, Nov 26, 2012 at 05:54:33AM +0000, Huang Changming-R66093 > wrote: > > > > Hi, Robot > > > > I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of > > > > linux-mmc > > > tree. > > > > Could you point out which file use it? > > > > > > > > This patch just use the 'div_u64' to calculate the timeout in > > > > order to > > > avoid overflow. > > > > > > Hi! This is confirmed to fix the problem: > > > > > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index > > > 48ad361..daf0636 100644 > > > --- a/drivers/mmc/host/omap.c > > > +++ b/drivers/mmc/host/omap.c > > > @@ -921,7 +921,7 @@ static inline void set_data_timeout(struct > > > mmc_omap_host *host, struct mmc_reque > > > u16 reg; > > > > > > cycle_ns = 1000000000 / host->current_slot->fclk_freq; > > > - timeout = req->data->timeout_ns / cycle_ns; > > > + timeout = div_u64(req->data->timeout_ns, cycle_ns); > > > timeout += req->data->timeout_clks; > > > > > > /* Check if we need to use timeout multiplier register */ > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-01-15 2:06 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-11-25 23:13 [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod' kbuild test robot 2012-11-25 23:51 ` Chris Ball 2012-11-26 4:11 ` Zhang Haijun-B42677 2012-11-26 10:02 ` Zhang Haijun-B42677 2012-12-14 2:52 ` Zhang Haijun-B42677 2013-01-15 2:03 ` Zhang Haijun-B42677 2012-11-26 5:54 ` Huang Changming-R66093 2012-11-26 6:02 ` Fengguang Wu 2012-11-26 6:12 ` Zhang Haijun-B42677 2012-11-26 6:21 ` Fengguang Wu 2012-11-26 7:23 ` Zhang Haijun-B42677
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.