From: Antonio Quartulli <ordex@autistici.org>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: "Martin Hundebøll" <martin@hundeboll.net>,
"The list for a Better Approach To Mobile Ad-hoc Networking"
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC 2/6] batman-adv: Detect coding nodes and remove these after timeout
Date: Mon, 26 Nov 2012 10:34:28 +0100 [thread overview]
Message-ID: <20121126093428.GC22729@ritirata.org> (raw)
In-Reply-To: <201211260915.44897.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Mon, Nov 26, 2012 at 09:15:44AM +0800, Marek Lindner wrote:
> On Monday, November 26, 2012 08:41:17 Antonio Quartulli wrote:
> > > struct batadv_priv_nc {
> > >
> > > struct delayed_work work;
> > >
> > > + struct dentry *debug_dir;
> > > + u8 min_tq;
> >
> > If I am not mistaken min_tq is never modified. Why do we need to store it
> > in a bat_priv field? And being a constant is it worth a define? In this
> > way it an be easily found and tuned like the other constant params.
>
> It can be modified via debugfs:
>
> + file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir,
> + &bat_priv->nc.min_tq);
Oh, ok! I hadn't seen the "W" in the mode.
Thanks.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-26 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 13:21 [B.A.T.M.A.N.] [RFC 0/6] CATWOMAN: Network coding in batman-adv Martin Hundebøll
2012-11-19 13:21 ` [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Add the initial code for network coding Martin Hundebøll
2012-11-26 0:23 ` Antonio Quartulli
2012-11-27 8:24 ` Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 2/6] batman-adv: Detect coding nodes and remove these after timeout Martin Hundebøll
2012-11-26 0:41 ` Antonio Quartulli
2012-11-26 1:15 ` Marek Lindner
2012-11-26 9:34 ` Antonio Quartulli [this message]
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 3/6] batman-adv: Buffer unicast packets before forward Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 4/6] batman-adv: Code and transmit packets if possible Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 5/6] batman-adv: Save overheard and tx packets for decoding Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 6/6] batman-adv: Receive coded packets and decode them Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126093428.GC22729@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
--cc=martin@hundeboll.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.