From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI: include missed header into acpi_platform.c
Date: Mon, 26 Nov 2012 11:40:44 +0200 [thread overview]
Message-ID: <20121126094044.GG3867@intel.com> (raw)
In-Reply-To: <1353922086-19917-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Mon, Nov 26, 2012 at 11:28:05AM +0200, Andy Shevchenko wrote:
> The internal.h declares the acpi_create_platform_device(). Without that include
> we get a following warning:
> drivers/acpi/acpi_platform.c:133:24: warning: symbol 'acpi_create_platform_device' was not declared. Should it be static?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/acpi/acpi_platform.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index dbb31d6..2eee101 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -17,6 +17,8 @@
> #include <linux/module.h>
> #include <linux/platform_device.h>
>
> +#include "internal.h"
> +
> ACPI_MODULE_NAME("platform");
>
> struct resource_info {
> --
> 1.7.10.4
next prev parent reply other threads:[~2012-11-26 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 9:28 [PATCH] ACPI: include missed header into acpi_platform.c Andy Shevchenko
2012-11-26 9:40 ` Mika Westerberg [this message]
2012-11-26 10:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126094044.GG3867@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.