* [PATCH] ACPI: include missed header into acpi_platform.c
@ 2012-11-26 9:28 Andy Shevchenko
2012-11-26 9:40 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2012-11-26 9:28 UTC (permalink / raw)
To: Rafael J . Wysocki, Mika Westerberg, linux-acpi; +Cc: Andy Shevchenko
The internal.h declares the acpi_create_platform_device(). Without that include
we get a following warning:
drivers/acpi/acpi_platform.c:133:24: warning: symbol 'acpi_create_platform_device' was not declared. Should it be static?
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/acpi_platform.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
index dbb31d6..2eee101 100644
--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -17,6 +17,8 @@
#include <linux/module.h>
#include <linux/platform_device.h>
+#include "internal.h"
+
ACPI_MODULE_NAME("platform");
struct resource_info {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: include missed header into acpi_platform.c
2012-11-26 9:28 [PATCH] ACPI: include missed header into acpi_platform.c Andy Shevchenko
@ 2012-11-26 9:40 ` Mika Westerberg
2012-11-26 10:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2012-11-26 9:40 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Rafael J . Wysocki, linux-acpi
On Mon, Nov 26, 2012 at 11:28:05AM +0200, Andy Shevchenko wrote:
> The internal.h declares the acpi_create_platform_device(). Without that include
> we get a following warning:
> drivers/acpi/acpi_platform.c:133:24: warning: symbol 'acpi_create_platform_device' was not declared. Should it be static?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/acpi/acpi_platform.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index dbb31d6..2eee101 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -17,6 +17,8 @@
> #include <linux/module.h>
> #include <linux/platform_device.h>
>
> +#include "internal.h"
> +
> ACPI_MODULE_NAME("platform");
>
> struct resource_info {
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: include missed header into acpi_platform.c
2012-11-26 9:40 ` Mika Westerberg
@ 2012-11-26 10:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2012-11-26 10:08 UTC (permalink / raw)
To: linux-acpi; +Cc: Mika Westerberg, Andy Shevchenko, Rafael J . Wysocki
On Monday, November 26, 2012 11:40:44 AM Mika Westerberg wrote:
> On Mon, Nov 26, 2012 at 11:28:05AM +0200, Andy Shevchenko wrote:
> > The internal.h declares the acpi_create_platform_device(). Without that include
> > we get a following warning:
> > drivers/acpi/acpi_platform.c:133:24: warning: symbol 'acpi_create_platform_device' was not declared. Should it be static?
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied.
Thanks,
Rafael
> > ---
> > drivers/acpi/acpi_platform.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> > index dbb31d6..2eee101 100644
> > --- a/drivers/acpi/acpi_platform.c
> > +++ b/drivers/acpi/acpi_platform.c
> > @@ -17,6 +17,8 @@
> > #include <linux/module.h>
> > #include <linux/platform_device.h>
> >
> > +#include "internal.h"
> > +
> > ACPI_MODULE_NAME("platform");
> >
> > struct resource_info {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-26 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-26 9:28 [PATCH] ACPI: include missed header into acpi_platform.c Andy Shevchenko
2012-11-26 9:40 ` Mika Westerberg
2012-11-26 10:08 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.