From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
Cc: alsa-devel@alsa-project.org,
davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.infradead.org, tony@atomide.com,
lrg@ti.com, perex@perex.cz, nsekhar@ti.com, sudhakar.raj@ti.com,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
rob@landley.net
Subject: Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support
Date: Mon, 26 Nov 2012 11:45:11 +0000 [thread overview]
Message-ID: <20121126114511.GE9411@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1353557099-21599-2-git-send-email-gururaja.hebbar@ti.com>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote:
> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl))
> + dev_warn(&pdev->dev,
> + "pins are not configured from the driver\n");
Since the driver is happy to continue without the pins why is it
bothering requesting them in the first place? In other words, this
should be a hard error.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support
Date: Mon, 26 Nov 2012 11:45:11 +0000 [thread overview]
Message-ID: <20121126114511.GE9411@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1353557099-21599-2-git-send-email-gururaja.hebbar@ti.com>
On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote:
> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl))
> + dev_warn(&pdev->dev,
> + "pins are not configured from the driver\n");
Since the driver is happy to continue without the pins why is it
bothering requesting them in the first place? In other words, this
should be a hard error.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121126/a82d85f5/attachment.sig>
next prev parent reply other threads:[~2012-11-26 11:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 4:04 [PATCH 0/2] ARM/ASoC: Davinci: Device Tree Update Hebbar, Gururaja
2012-11-22 4:04 ` Hebbar, Gururaja
2012-11-22 4:04 ` Hebbar, Gururaja
[not found] ` <1353557099-21599-1-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2012-11-22 4:04 ` [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support Hebbar, Gururaja
2012-11-22 4:04 ` Hebbar, Gururaja
2012-11-22 4:04 ` Hebbar, Gururaja
2012-11-26 11:45 ` Mark Brown [this message]
2012-11-26 11:45 ` Mark Brown
2012-11-27 5:55 ` Peter Korsgaard
2012-11-27 5:55 ` Peter Korsgaard
2012-11-27 5:55 ` Peter Korsgaard
2012-11-27 14:04 ` Mark Brown
2012-11-27 14:04 ` Mark Brown
2012-11-22 4:04 ` [PATCH 2/2] ASoC: Davinci: machine: Add device tree binding Hebbar, Gururaja
2012-11-22 4:04 ` Hebbar, Gururaja
2012-11-22 4:04 ` Hebbar, Gururaja
2012-11-26 11:56 ` Mark Brown
2012-11-26 11:56 ` Mark Brown
2012-11-27 12:53 ` Hebbar, Gururaja
2012-11-27 12:53 ` Hebbar, Gururaja
2012-11-26 11:41 ` [PATCH 0/2] ARM/ASoC: Davinci: Device Tree Update Hebbar, Gururaja
2012-11-26 11:41 ` Hebbar, Gururaja
2012-11-26 11:41 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126114511.GE9411@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=rob@landley.net \
--cc=sudhakar.raj@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.