From: Dan Carpenter <dan.carpenter@oracle.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k: Add concurrent WLAN and BT tx support for MCI based chips
Date: Tue, 27 Nov 2012 00:03:37 +0300 [thread overview]
Message-ID: <20121126210337.GA27645@elgon.mountain> (raw)
Hello Rajkumar Manoharan,
The patch db60428b1af1: "ath9k: Add concurrent WLAN and BT tx support
for MCI based chips" from Oct 12, 2012, leads to the following
warning:
drivers/net/wireless/ath/ath9k/btcoex.c:414
ath9k_hw_btcoex_set_concur_txprio()
error: buffer overflow 'stomp_txprio' 4 <= 4
stomp_txprio has 4 elements.
u8 stomp_txprio[] = { 0, 0, 0, 0 }; /* all, low, none, low_ftp */
drivers/net/wireless/ath/ath9k/btcoex.c
408 void ath9k_hw_btcoex_set_concur_txprio(struct ath_hw *ah, u8 *stomp_txprio)
409 {
410 struct ath_btcoex_hw *btcoex = &ah->btcoex_hw;
411 int i;
412
413 for (i = 0; i < ATH_BTCOEX_STOMP_MAX; i++)
^^^^^^^^^^^^^^^^^^^^
This is 5.
414 btcoex->tx_prio[i] = stomp_txprio[i];
^^^^^^^^^^^^^^
We are reading one positition past the end of the array.
415 }
Possibly we need to add some code to handle ATH_BTCOEX_STOMP_AUDIO which
was added recently in 2884561a "ath9k: stomp audio profiles on weak
signal strength."
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: rmanohar@qca.qualcomm.com
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: re: ath9k: Add concurrent WLAN and BT tx support for MCI based chips
Date: Tue, 27 Nov 2012 00:03:37 +0300 [thread overview]
Message-ID: <20121126210337.GA27645@elgon.mountain> (raw)
Hello Rajkumar Manoharan,
The patch db60428b1af1: "ath9k: Add concurrent WLAN and BT tx support
for MCI based chips" from Oct 12, 2012, leads to the following
warning:
drivers/net/wireless/ath/ath9k/btcoex.c:414
ath9k_hw_btcoex_set_concur_txprio()
error: buffer overflow 'stomp_txprio' 4 <= 4
stomp_txprio has 4 elements.
u8 stomp_txprio[] = { 0, 0, 0, 0 }; /* all, low, none, low_ftp */
drivers/net/wireless/ath/ath9k/btcoex.c
408 void ath9k_hw_btcoex_set_concur_txprio(struct ath_hw *ah, u8 *stomp_txprio)
409 {
410 struct ath_btcoex_hw *btcoex = &ah->btcoex_hw;
411 int i;
412
413 for (i = 0; i < ATH_BTCOEX_STOMP_MAX; i++)
^^^^^^^^^^^^^^^^^^^^
This is 5.
414 btcoex->tx_prio[i] = stomp_txprio[i];
^^^^^^^^^^^^^^
We are reading one positition past the end of the array.
415 }
Possibly we need to add some code to handle ATH_BTCOEX_STOMP_AUDIO which
was added recently in 2884561a "ath9k: stomp audio profiles on weak
signal strength."
regards,
dan carpenter
next reply other threads:[~2012-11-26 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 21:03 Dan Carpenter [this message]
2012-11-26 21:03 ` ath9k: Add concurrent WLAN and BT tx support for MCI based chips Dan Carpenter
2012-11-27 8:28 ` [ath9k-devel] " Rajkumar Manoharan
2012-11-27 8:28 ` Rajkumar Manoharan
2012-11-27 8:49 ` [ath9k-devel] " Dan Carpenter
2012-11-27 8:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126210337.GA27645@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.