* [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
@ 2012-11-27 9:34 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2012-11-27 9:34 UTC (permalink / raw)
To: linux-arm-kernel
The u9540 stopped booting after the v3.7 merge window due to
a lack of common clk support and early PRCMU initialisation.
In this patch we rectify these issues, placing the u9540
development board back into a successfully booting state.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/mach-ux500/cpu.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index 721e7b4..d4dcec5 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -71,13 +71,11 @@ void __init ux500_init_irq(void)
* Init clocks here so that they are available for system timer
* initialization.
*/
- if (cpu_is_u8500_family())
+ if (cpu_is_u8500_family() || cpu_is_u9540())
db8500_prcmu_early_init();
- if (cpu_is_u8500_family())
+ if (cpu_is_u8500_family() || cpu_is_u9540())
u8500_clk_init();
- else if (cpu_is_u9540())
- u9540_clk_init();
else if (cpu_is_u8540())
u8540_clk_init();
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
@ 2012-11-27 9:34 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2012-11-27 9:34 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: arnd, linus.walleij, Lee Jones
The u9540 stopped booting after the v3.7 merge window due to
a lack of common clk support and early PRCMU initialisation.
In this patch we rectify these issues, placing the u9540
development board back into a successfully booting state.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/mach-ux500/cpu.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index 721e7b4..d4dcec5 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -71,13 +71,11 @@ void __init ux500_init_irq(void)
* Init clocks here so that they are available for system timer
* initialization.
*/
- if (cpu_is_u8500_family())
+ if (cpu_is_u8500_family() || cpu_is_u9540())
db8500_prcmu_early_init();
- if (cpu_is_u8500_family())
+ if (cpu_is_u8500_family() || cpu_is_u9540())
u8500_clk_init();
- else if (cpu_is_u9540())
- u9540_clk_init();
else if (cpu_is_u8540())
u8540_clk_init();
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
2012-11-27 9:34 ` Lee Jones
@ 2012-11-27 12:36 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2012-11-27 12:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 27 November 2012, Lee Jones wrote:
> The u9540 stopped booting after the v3.7 merge window due to
> a lack of common clk support and early PRCMU initialisation.
> In this patch we rectify these issues, placing the u9540
> development board back into a successfully booting state.
> - if (cpu_is_u8500_family())
> + if (cpu_is_u8500_family() || cpu_is_u9540())
> u8500_clk_init();
> - else if (cpu_is_u9540())
> - u9540_clk_init();
> else if (cpu_is_u8540())
> u8540_clk_init();
It certainly doesn't /look/ right, even if it works. Can you explain why
u8540_clk_init works and u9540_clk_init doesn't?
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
@ 2012-11-27 12:36 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2012-11-27 12:36 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, linus.walleij
On Tuesday 27 November 2012, Lee Jones wrote:
> The u9540 stopped booting after the v3.7 merge window due to
> a lack of common clk support and early PRCMU initialisation.
> In this patch we rectify these issues, placing the u9540
> development board back into a successfully booting state.
> - if (cpu_is_u8500_family())
> + if (cpu_is_u8500_family() || cpu_is_u9540())
> u8500_clk_init();
> - else if (cpu_is_u9540())
> - u9540_clk_init();
> else if (cpu_is_u8540())
> u8540_clk_init();
It certainly doesn't /look/ right, even if it works. Can you explain why
u8540_clk_init works and u9540_clk_init doesn't?
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
2012-11-27 12:36 ` Arnd Bergmann
@ 2012-11-27 13:03 ` Lee Jones
-1 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2012-11-27 13:03 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 27 Nov 2012, Arnd Bergmann wrote:
> On Tuesday 27 November 2012, Lee Jones wrote:
>
> > The u9540 stopped booting after the v3.7 merge window due to
> > a lack of common clk support and early PRCMU initialisation.
> > In this patch we rectify these issues, placing the u9540
> > development board back into a successfully booting state.
>
> > - if (cpu_is_u8500_family())
> > + if (cpu_is_u8500_family() || cpu_is_u9540())
> > u8500_clk_init();
> > - else if (cpu_is_u9540())
> > - u9540_clk_init();
> > else if (cpu_is_u8540())
> > u8540_clk_init();
>
> It certainly doesn't /look/ right, even if it works. Can you explain why
> u8540_clk_init works and u9540_clk_init doesn't?
Because it's empty. :)
Common clk doesn't support the u9540 yet, and even when it does,
most (all?) of the clocks will be identical to the u9540 in any
case.
I believe Linus wants to apply this with a TODO, to ensure the
board is at least bootable. This whole section is in the wrong
place anyway IMHO, and needs moving out to somewhere less hacky,
rather than initialising clocks and the PRCMU from .init_irq.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
@ 2012-11-27 13:03 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2012-11-27 13:03 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-arm-kernel, linux-kernel, linus.walleij
On Tue, 27 Nov 2012, Arnd Bergmann wrote:
> On Tuesday 27 November 2012, Lee Jones wrote:
>
> > The u9540 stopped booting after the v3.7 merge window due to
> > a lack of common clk support and early PRCMU initialisation.
> > In this patch we rectify these issues, placing the u9540
> > development board back into a successfully booting state.
>
> > - if (cpu_is_u8500_family())
> > + if (cpu_is_u8500_family() || cpu_is_u9540())
> > u8500_clk_init();
> > - else if (cpu_is_u9540())
> > - u9540_clk_init();
> > else if (cpu_is_u8540())
> > u8540_clk_init();
>
> It certainly doesn't /look/ right, even if it works. Can you explain why
> u8540_clk_init works and u9540_clk_init doesn't?
Because it's empty. :)
Common clk doesn't support the u9540 yet, and even when it does,
most (all?) of the clocks will be identical to the u9540 in any
case.
I believe Linus wants to apply this with a TODO, to ensure the
board is at least bootable. This whole section is in the wrong
place anyway IMHO, and needs moving out to somewhere less hacky,
rather than initialising clocks and the PRCMU from .init_irq.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
2012-11-27 9:34 ` Lee Jones
@ 2013-01-24 16:06 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2013-01-24 16:06 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 27, 2012 at 10:34 AM, Lee Jones <lee.jones@linaro.org> wrote:
> The u9540 stopped booting after the v3.7 merge window due to
> a lack of common clk support and early PRCMU initialisation.
> In this patch we rectify these issues, placing the u9540
> development board back into a successfully booting state.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to my ux500-fixes branch, will go into ARM SoC
pull request RealSoonNow.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Fix u9540 booting issues
@ 2013-01-24 16:06 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2013-01-24 16:06 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Tue, Nov 27, 2012 at 10:34 AM, Lee Jones <lee.jones@linaro.org> wrote:
> The u9540 stopped booting after the v3.7 merge window due to
> a lack of common clk support and early PRCMU initialisation.
> In this patch we rectify these issues, placing the u9540
> development board back into a successfully booting state.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to my ux500-fixes branch, will go into ARM SoC
pull request RealSoonNow.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-01-24 16:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 9:34 [PATCH 1/1] ARM: ux500: Fix u9540 booting issues Lee Jones
2012-11-27 9:34 ` Lee Jones
2012-11-27 12:36 ` Arnd Bergmann
2012-11-27 12:36 ` Arnd Bergmann
2012-11-27 13:03 ` Lee Jones
2012-11-27 13:03 ` Lee Jones
2013-01-24 16:06 ` Linus Walleij
2013-01-24 16:06 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.