All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/3] balancenuma: set last_nid on newly allocated page
@ 2012-11-27 13:15 Hillf Danton
  2012-11-27 14:48 ` Mel Gorman
  0 siblings, 1 reply; 2+ messages in thread
From: Hillf Danton @ 2012-11-27 13:15 UTC (permalink / raw)
  To: Mel Gorman; +Cc: lkml, dhillf

Pass last_nid from misplaced page to newly allocated migration target page.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/mm/migrate.c	Tue Nov 27 20:16:48 2012
+++ b/mm/migrate.c	Tue Nov 27 20:19:12 2012
@@ -1457,6 +1457,9 @@ static struct page *alloc_misplaced_dst_
 					  __GFP_NOMEMALLOC | __GFP_NORETRY |
 					  __GFP_NOWARN) &
 					 ~GFP_IOFS, 0);
+	if (newpage)
+		page_xchg_last_nid(newpage, page_last_nid(page));
+
 	return newpage;
 }

@@ -1627,6 +1630,8 @@ int migrate_misplaced_transhuge_page(str
 		(GFP_TRANSHUGE | GFP_THISNODE) & ~__GFP_WAIT, HPAGE_PMD_ORDER);
 	if (!new_page)
 		goto out_dropref;
+
+	page_xchg_last_nid(new_page, page_last_nid(page));

 	isolated = numamigrate_isolate_page(pgdat, page);
 	if (!isolated) {
--

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/3] balancenuma: set last_nid on newly allocated page
  2012-11-27 13:15 [PATCH 2/3] balancenuma: set last_nid on newly allocated page Hillf Danton
@ 2012-11-27 14:48 ` Mel Gorman
  0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2012-11-27 14:48 UTC (permalink / raw)
  To: Hillf Danton; +Cc: lkml

On Tue, Nov 27, 2012 at 09:15:44PM +0800, Hillf Danton wrote:
> Pass last_nid from misplaced page to newly allocated migration target page.
> 
> Signed-off-by: Hillf Danton <dhillf@gmail.com>

Picked up. One part if it gets slotted into place as a standalone patch.
The second became part of the THP patch at the end of the series. Same
logic as before -- preserves bisection and allows the tree to be tested
in pieces.

Thanks Hillf!

-- 
Mel Gorman
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-27 14:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 13:15 [PATCH 2/3] balancenuma: set last_nid on newly allocated page Hillf Danton
2012-11-27 14:48 ` Mel Gorman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.