From: Rafael Aquini <aquini@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sasha Levin <levinsasha928@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: fix balloon_page_movable() page->flags check
Date: Tue, 27 Nov 2012 23:30:31 -0200 [thread overview]
Message-ID: <20121128013031.GA2071@x61.redhat.com> (raw)
In-Reply-To: <20121127171544.8bbb702a.akpm@linux-foundation.org>
On Tue, Nov 27, 2012 at 05:15:44PM -0800, Andrew Morton wrote:
> On Tue, 27 Nov 2012 22:34:10 -0200 Rafael Aquini <aquini@redhat.com> wrote:
>
> > Do you want me to resubmit this patch with the changes you suggested?
>
> oh, I think I can reach that far. How's this look?
>
It looks great to me.
Just a small nitpick,
here __balloon_page_flags should be changed to page_flags_cleared too:
> @@ -109,18 +110,16 @@ static inline void balloon_mapping_free(
> /*
> * __balloon_page_flags - helper to perform balloon @page ->flags tests.
> *
Thanks!
--Rafael
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rafael Aquini <aquini@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sasha Levin <levinsasha928@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: fix balloon_page_movable() page->flags check
Date: Tue, 27 Nov 2012 23:30:31 -0200 [thread overview]
Message-ID: <20121128013031.GA2071@x61.redhat.com> (raw)
In-Reply-To: <20121127171544.8bbb702a.akpm@linux-foundation.org>
On Tue, Nov 27, 2012 at 05:15:44PM -0800, Andrew Morton wrote:
> On Tue, 27 Nov 2012 22:34:10 -0200 Rafael Aquini <aquini@redhat.com> wrote:
>
> > Do you want me to resubmit this patch with the changes you suggested?
>
> oh, I think I can reach that far. How's this look?
>
It looks great to me.
Just a small nitpick,
here __balloon_page_flags should be changed to page_flags_cleared too:
> @@ -109,18 +110,16 @@ static inline void balloon_mapping_free(
> /*
> * __balloon_page_flags - helper to perform balloon @page ->flags tests.
> *
Thanks!
--Rafael
next prev parent reply other threads:[~2012-11-28 1:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121127145708.c7173d0d.akpm@linux-foundation.org>
2012-11-27 23:31 ` [PATCH] mm: fix balloon_page_movable() page->flags check Rafael Aquini
2012-11-27 23:31 ` Rafael Aquini
2012-11-27 23:32 ` Rafael Aquini
2012-11-27 23:32 ` Rafael Aquini
2012-11-27 23:52 ` Andrew Morton
2012-11-27 23:52 ` Andrew Morton
2012-11-28 0:34 ` Rafael Aquini
2012-11-28 0:34 ` Rafael Aquini
2012-11-28 1:15 ` Andrew Morton
2012-11-28 1:15 ` Andrew Morton
2012-11-28 1:30 ` Rafael Aquini [this message]
2012-11-28 1:30 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128013031.GA2071@x61.redhat.com \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.