All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	xfs@oss.sgi.com, linux-kernel@vger.kernel.org,
	glommer@parallels.com
Subject: Re: [PATCH 15/19] xfs: convert dquot cache lru to list_lru
Date: Wed, 28 Nov 2012 11:17:07 -0500	[thread overview]
Message-ID: <20121128161707.GA19634@infradead.org> (raw)
In-Reply-To: <1354058086-27937-16-git-send-email-david@fromorbit.com>

> +	if (!xfs_dqflock_nowait(dqp))
> +		xfs_dqunlock(dqp);
> +		goto out_miss_busy;

This seems to miss braces.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: glommer@parallels.com, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH 15/19] xfs: convert dquot cache lru to list_lru
Date: Wed, 28 Nov 2012 11:17:07 -0500	[thread overview]
Message-ID: <20121128161707.GA19634@infradead.org> (raw)
In-Reply-To: <1354058086-27937-16-git-send-email-david@fromorbit.com>

> +	if (!xfs_dqflock_nowait(dqp))
> +		xfs_dqunlock(dqp);
> +		goto out_miss_busy;

This seems to miss braces.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: glommer@parallels.com, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH 15/19] xfs: convert dquot cache lru to list_lru
Date: Wed, 28 Nov 2012 11:17:07 -0500	[thread overview]
Message-ID: <20121128161707.GA19634@infradead.org> (raw)
In-Reply-To: <1354058086-27937-16-git-send-email-david@fromorbit.com>

> +	if (!xfs_dqflock_nowait(dqp))
> +		xfs_dqunlock(dqp);
> +		goto out_miss_busy;

This seems to miss braces.


  reply	other threads:[~2012-11-28 16:14 UTC|newest]

Thread overview: 163+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 23:14 [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers Dave Chinner
2012-11-27 23:14 ` Dave Chinner
2012-11-27 23:14 ` Dave Chinner
2012-11-27 23:14 ` [PATCH 01/19] dcache: convert dentry_stat.nr_unused to per-cpu counters Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 02/19] dentry: move to per-sb LRU locks Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 03/19] dcache: remove dentries from LRU before putting on dispose list Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 04/19] mm: new shrinker API Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 05/19] shrinker: convert superblock shrinkers to new API Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-12-20 11:06   ` Glauber Costa
2012-12-20 11:06     ` Glauber Costa
2012-12-20 11:06     ` Glauber Costa
2012-12-21  1:46     ` Dave Chinner
2012-12-21  1:46       ` Dave Chinner
2012-12-21 10:17       ` Glauber Costa
2012-12-21 10:17         ` Glauber Costa
2012-12-21 10:17         ` Glauber Costa
2012-11-27 23:14 ` [PATCH 06/19] list: add a new LRU list type Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-28 16:10   ` Christoph Hellwig
2012-11-28 16:10     ` Christoph Hellwig
2012-11-28 16:10     ` Christoph Hellwig
2012-11-27 23:14 ` [PATCH 07/19] inode: convert inode lru list to generic lru list code Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 08/19] dcache: convert to use new lru list infrastructure Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 09/19] list_lru: per-node " Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-12-20 11:21   ` Glauber Costa
2012-12-20 11:21     ` Glauber Costa
2012-12-20 11:21     ` Glauber Costa
2012-12-21  1:54     ` Dave Chinner
2012-12-21  1:54       ` Dave Chinner
2013-01-16 19:21   ` Glauber Costa
2013-01-16 19:21     ` Glauber Costa
2013-01-16 19:21     ` Glauber Costa
2013-01-16 22:55     ` Dave Chinner
2013-01-16 22:55       ` Dave Chinner
2013-01-17  0:35       ` Glauber Costa
2013-01-17  0:35         ` Glauber Costa
2013-01-17  0:35         ` Glauber Costa
2013-01-17  4:22         ` Dave Chinner
2013-01-17  4:22           ` Dave Chinner
2013-01-17 18:21           ` Glauber Costa
2013-01-17 18:21             ` Glauber Costa
2013-01-17 18:21             ` Glauber Costa
2013-01-18  0:10             ` Dave Chinner
2013-01-18  0:10               ` Dave Chinner
2013-01-18  0:14               ` Glauber Costa
2013-01-18  0:14                 ` Glauber Costa
2013-01-18  0:14                 ` Glauber Costa
2013-01-18  8:11                 ` Dave Chinner
2013-01-18  8:11                   ` Dave Chinner
2013-01-18 19:10                   ` Glauber Costa
2013-01-18 19:10                     ` Glauber Costa
2013-01-18 19:10                     ` Glauber Costa
2013-01-19  0:10                     ` Dave Chinner
2013-01-19  0:10                       ` Dave Chinner
2013-01-19  0:13                       ` Glauber Costa
2013-01-19  0:13                         ` Glauber Costa
2013-01-19  0:13                         ` Glauber Costa
2013-01-18  0:51               ` Glauber Costa
2013-01-18  0:51                 ` Glauber Costa
2013-01-18  0:51                 ` Glauber Costa
2013-01-18  8:08                 ` Dave Chinner
2013-01-18  8:08                   ` Dave Chinner
2013-01-18 19:01                   ` Glauber Costa
2013-01-18 19:01                     ` Glauber Costa
2013-01-18 19:01                     ` Glauber Costa
2012-11-27 23:14 ` [PATCH 10/19] shrinker: add node awareness Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 11/19] fs: convert inode and dentry shrinking to be node aware Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 12/19] xfs: convert buftarg LRU to generic code Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 13/19] xfs: Node aware direct inode reclaim Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 14/19] xfs: use generic AG walk for background " Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 15/19] xfs: convert dquot cache lru to list_lru Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-28 16:17   ` Christoph Hellwig [this message]
2012-11-28 16:17     ` Christoph Hellwig
2012-11-28 16:17     ` Christoph Hellwig
2012-11-27 23:14 ` [PATCH 16/19] fs: convert fs shrinkers to new scan/count API Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 17/19] drivers: convert shrinkers to new count/scan API Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-28  1:13   ` Chris Wilson
2012-11-28  1:13     ` Chris Wilson
2012-11-28  1:13     ` Chris Wilson
2012-11-28  3:17     ` Dave Chinner
2012-11-28  3:17       ` Dave Chinner
2012-11-28  3:17       ` Dave Chinner
2012-11-28  8:21       ` Glauber Costa
2012-11-28  8:21         ` Glauber Costa
2012-11-28  8:21         ` Glauber Costa
2012-11-28  8:21         ` Glauber Costa
2012-11-28 21:28         ` Dave Chinner
2012-11-28 21:28           ` Dave Chinner
2012-11-28 21:28           ` Dave Chinner
2012-11-29 10:29           ` Glauber Costa
2012-11-29 10:29             ` Glauber Costa
2012-11-29 10:29             ` Glauber Costa
2012-11-29 10:29             ` Glauber Costa
2012-11-29 22:02             ` Dave Chinner
2012-11-29 22:02               ` Dave Chinner
2012-11-29 22:02               ` Dave Chinner
2013-06-07 13:37   ` Konrad Rzeszutek Wilk
2013-06-07 13:37     ` Konrad Rzeszutek Wilk
2013-06-07 13:37     ` Konrad Rzeszutek Wilk
2012-11-27 23:14 ` [PATCH 18/19] shrinker: convert remaining shrinkers to " Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14 ` [PATCH 19/19] shrinker: Kill old ->shrink API Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-27 23:14   ` Dave Chinner
2012-11-29 19:02 ` [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers Andi Kleen
2012-11-29 19:02   ` Andi Kleen
2012-11-29 19:02   ` Andi Kleen
2012-11-29 22:09   ` Dave Chinner
2012-11-29 22:09     ` Dave Chinner
2012-11-29 22:09     ` Dave Chinner
2012-12-20 11:45 ` Glauber Costa
2012-12-20 11:45   ` Glauber Costa
2012-12-20 11:45   ` Glauber Costa
2012-12-21  2:50   ` Dave Chinner
2012-12-21  2:50     ` Dave Chinner
2012-12-21 10:41     ` Glauber Costa
2012-12-21 10:41       ` Glauber Costa
2012-12-21 10:41       ` Glauber Costa
2013-01-21 16:08 ` Glauber Costa
2013-01-21 16:08   ` Glauber Costa
2013-01-21 16:08   ` Glauber Costa
2013-01-21 23:21   ` Dave Chinner
2013-01-21 23:21     ` Dave Chinner
2013-01-21 23:21     ` Dave Chinner
2013-01-23 14:36     ` Glauber Costa
2013-01-23 14:36       ` Glauber Costa
2013-01-23 14:36       ` Glauber Costa
2013-01-23 23:46       ` Dave Chinner
2013-01-23 23:46         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121128161707.GA19634@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=glommer@parallels.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.