From: Minchan Kim <minchan@kernel.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 3/3] zram: get rid of lockdep warning
Date: Thu, 29 Nov 2012 10:34:41 +0900 [thread overview]
Message-ID: <20121129013441.GB24077@blaptop> (raw)
In-Reply-To: <50B625B5.2070601@redhat.com>
On Wed, Nov 28, 2012 at 03:54:45PM +0100, Jerome Marchand wrote:
> On 11/28/2012 03:35 AM, Minchan Kim wrote:
> > Lockdep complains about recursive deadlock of zram->init_lock.
> > [1] made it false positive because we can't request IO to zram
> > before setting disksize. Anyway, we should shut lockdep up to
> > avoid many reporting from user.
> >
> > This patch allocates zram's metadata out of lock so we can fix it.
>
> Is that me or the functions zram_meta_alloc/free are missing?
Who bite my zram_meta_alloc/free? :)
Will resend with your suggestion for removing GFP_ATOMIC.
Thanks!
>
> Regards,
> Jerome
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 3/3] zram: get rid of lockdep warning
Date: Thu, 29 Nov 2012 10:34:41 +0900 [thread overview]
Message-ID: <20121129013441.GB24077@blaptop> (raw)
In-Reply-To: <50B625B5.2070601@redhat.com>
On Wed, Nov 28, 2012 at 03:54:45PM +0100, Jerome Marchand wrote:
> On 11/28/2012 03:35 AM, Minchan Kim wrote:
> > Lockdep complains about recursive deadlock of zram->init_lock.
> > [1] made it false positive because we can't request IO to zram
> > before setting disksize. Anyway, we should shut lockdep up to
> > avoid many reporting from user.
> >
> > This patch allocates zram's metadata out of lock so we can fix it.
>
> Is that me or the functions zram_meta_alloc/free are missing?
Who bite my zram_meta_alloc/free? :)
Will resend with your suggestion for removing GFP_ATOMIC.
Thanks!
>
> Regards,
> Jerome
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-11-29 1:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 2:35 [PATCH 1/3] zram: force disksize setting before using zram Minchan Kim
2012-11-28 2:35 ` Minchan Kim
2012-11-28 2:35 ` [PATCH 2/3] zram: give up lazy initialization of zram metadata Minchan Kim
2012-11-28 2:35 ` Minchan Kim
2012-11-28 2:35 ` [PATCH 3/3] zram: get rid of lockdep warning Minchan Kim
2012-11-28 2:35 ` Minchan Kim
2012-11-28 14:54 ` Jerome Marchand
2012-11-28 14:54 ` Jerome Marchand
2012-11-29 1:34 ` Minchan Kim [this message]
2012-11-29 1:34 ` Minchan Kim
-- strict thread matches above, loose matches on Subject: below --
2013-01-17 2:12 [PATCH 1/3] zram: force disksize setting before using zram Minchan Kim
2013-01-17 2:12 ` [PATCH 3/3] zram: get rid of lockdep warning Minchan Kim
2013-01-17 2:12 ` Minchan Kim
2013-01-18 21:34 ` Nitin Gupta
2013-01-18 21:34 ` Nitin Gupta
2013-01-21 5:18 ` Minchan Kim
2013-01-21 5:18 ` Minchan Kim
2013-01-21 22:31 ` Nitin Gupta
2013-01-21 22:31 ` Nitin Gupta
2013-01-21 23:39 ` Minchan Kim
2013-01-21 23:39 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129013441.GB24077@blaptop \
--to=minchan@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmarchan@redhat.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=penberg@cs.helsinki.fi \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.