From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ab8500: remove explicit handling of battery type
Date: Fri, 30 Nov 2012 11:12:27 +0000 [thread overview]
Message-ID: <20121130111227.GE26023@gmail.com> (raw)
In-Reply-To: <1354130865-6148-1-git-send-email-rajanikanth.hv@linaro.org>
On Thu, 29 Nov 2012, Rajanikanth H.V wrote:
> From: "Rajanikanth H.V" <rajanikanth.hv@stericsson.com>
>
> property, battery-type shall be one of supported technology type
> instead blank
> - refer: Documentation/devicetree/bindings/power_supply/ab8500/fg.txt
> for the list supported types
> - this patch appends to ab8500 bm devs DT binding patch set
> ref: commit-id e0f1abeba5c2d8a2183566717d99294fd1a29c2e
> git://git.infradead.org/battery-2.6.git
> - promote ab8500_fg probe to happen before ab8500_btemp probe as
> btemp driver depends on fuelgauge list,
> ref: ab8500_fg_get(...)
I don't much like this commit message.
Take a look at some others to see how it's normally done.
> Signed-off-by: Rajanikanth H.V <rajanikanth.hv@stericsson.com>
> ---
> drivers/power/Makefile | 2 +-
> drivers/power/ab8500_bmdata.c | 10 +++-------
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/power/Makefile b/drivers/power/Makefile
> index 696e3a9..070c73d 100644
> --- a/drivers/power/Makefile
> +++ b/drivers/power/Makefile
> @@ -38,7 +38,7 @@ obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o
> obj-$(CONFIG_BATTERY_JZ4740) += jz4740-battery.o
> obj-$(CONFIG_BATTERY_INTEL_MID) += intel_mid_battery.o
> obj-$(CONFIG_BATTERY_RX51) += rx51_battery.o
> -obj-$(CONFIG_AB8500_BM) += ab8500_bmdata.o ab8500_charger.o ab8500_btemp.o ab8500_fg.o abx500_chargalg.o
> +obj-$(CONFIG_AB8500_BM) += ab8500_bmdata.o ab8500_charger.o ab8500_fg.o ab8500_btemp.o abx500_chargalg.o
> obj-$(CONFIG_CHARGER_ISP1704) += isp1704_charger.o
> obj-$(CONFIG_CHARGER_MAX8903) += max8903_charger.o
> obj-$(CONFIG_CHARGER_TWL4030) += twl4030_charger.o
This should be a separate patch.
> diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
> index 03cc528..f16b60c 100644
> --- a/drivers/power/ab8500_bmdata.c
> +++ b/drivers/power/ab8500_bmdata.c
> @@ -461,7 +461,6 @@ bmdevs_of_probe(struct device *dev,
> struct device_node *np_bat_supply;
> struct abx500_bm_data *bat;
> const char *btech;
> - char bat_tech[8];
> int i, thermistor;
>
> *battery = &ab8500_bm_data;
> @@ -488,12 +487,9 @@ bmdevs_of_probe(struct device *dev,
> "stericsson,battery-type", NULL);
> if (!btech) {
> dev_warn(dev, "missing property battery-name/type\n");
> - strcpy(bat_tech, "UNKNOWN");
> - } else {
> - strcpy(bat_tech, btech);
> + return -EINVAL;
> }
> -
> - if (strncmp(bat_tech, "LION", 4) == 0) {
> + if (strncmp(btech, "LION", 4) == 0) {
> bat->no_maintenance = true;
> bat->chg_unknown_bat = true;
> bat->bat_type[BATTERY_UNKNOWN].charge_full_design = 2600;
> @@ -508,7 +504,7 @@ bmdevs_of_probe(struct device *dev,
> if (thermistor == NTC_EXTERNAL) {
> btype->batres_tbl =
> temp_to_batres_tbl_ext_thermistor;
> - } else if (strncmp(bat_tech, "LION", 4) == 0) {
> + } else if (strncmp(btech, "LION", 4) == 0) {
> btype->batres_tbl =
> temp_to_batres_tbl_9100;
> } else {
Code is good though.
Once you have a sensible commit message you can apply my Acked-by
for both patches.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Rajanikanth H.V" <rajanikanth.hv@linaro.org>
Cc: anton.vorontsov@linaro.org, francescolavra.fl@gmail.com,
rob.herring@calxeda.com, arnd@arndb.de,
linus.walleij@stericsson.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
patches@linaro.org, STEricsson_nomadik_linux@list.st.com,
rajanikanth.hv@stericsson.com
Subject: Re: [PATCH] ab8500: remove explicit handling of battery type
Date: Fri, 30 Nov 2012 11:12:27 +0000 [thread overview]
Message-ID: <20121130111227.GE26023@gmail.com> (raw)
In-Reply-To: <1354130865-6148-1-git-send-email-rajanikanth.hv@linaro.org>
On Thu, 29 Nov 2012, Rajanikanth H.V wrote:
> From: "Rajanikanth H.V" <rajanikanth.hv@stericsson.com>
>
> property, battery-type shall be one of supported technology type
> instead blank
> - refer: Documentation/devicetree/bindings/power_supply/ab8500/fg.txt
> for the list supported types
> - this patch appends to ab8500 bm devs DT binding patch set
> ref: commit-id e0f1abeba5c2d8a2183566717d99294fd1a29c2e
> git://git.infradead.org/battery-2.6.git
> - promote ab8500_fg probe to happen before ab8500_btemp probe as
> btemp driver depends on fuelgauge list,
> ref: ab8500_fg_get(...)
I don't much like this commit message.
Take a look at some others to see how it's normally done.
> Signed-off-by: Rajanikanth H.V <rajanikanth.hv@stericsson.com>
> ---
> drivers/power/Makefile | 2 +-
> drivers/power/ab8500_bmdata.c | 10 +++-------
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/power/Makefile b/drivers/power/Makefile
> index 696e3a9..070c73d 100644
> --- a/drivers/power/Makefile
> +++ b/drivers/power/Makefile
> @@ -38,7 +38,7 @@ obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o
> obj-$(CONFIG_BATTERY_JZ4740) += jz4740-battery.o
> obj-$(CONFIG_BATTERY_INTEL_MID) += intel_mid_battery.o
> obj-$(CONFIG_BATTERY_RX51) += rx51_battery.o
> -obj-$(CONFIG_AB8500_BM) += ab8500_bmdata.o ab8500_charger.o ab8500_btemp.o ab8500_fg.o abx500_chargalg.o
> +obj-$(CONFIG_AB8500_BM) += ab8500_bmdata.o ab8500_charger.o ab8500_fg.o ab8500_btemp.o abx500_chargalg.o
> obj-$(CONFIG_CHARGER_ISP1704) += isp1704_charger.o
> obj-$(CONFIG_CHARGER_MAX8903) += max8903_charger.o
> obj-$(CONFIG_CHARGER_TWL4030) += twl4030_charger.o
This should be a separate patch.
> diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
> index 03cc528..f16b60c 100644
> --- a/drivers/power/ab8500_bmdata.c
> +++ b/drivers/power/ab8500_bmdata.c
> @@ -461,7 +461,6 @@ bmdevs_of_probe(struct device *dev,
> struct device_node *np_bat_supply;
> struct abx500_bm_data *bat;
> const char *btech;
> - char bat_tech[8];
> int i, thermistor;
>
> *battery = &ab8500_bm_data;
> @@ -488,12 +487,9 @@ bmdevs_of_probe(struct device *dev,
> "stericsson,battery-type", NULL);
> if (!btech) {
> dev_warn(dev, "missing property battery-name/type\n");
> - strcpy(bat_tech, "UNKNOWN");
> - } else {
> - strcpy(bat_tech, btech);
> + return -EINVAL;
> }
> -
> - if (strncmp(bat_tech, "LION", 4) == 0) {
> + if (strncmp(btech, "LION", 4) == 0) {
> bat->no_maintenance = true;
> bat->chg_unknown_bat = true;
> bat->bat_type[BATTERY_UNKNOWN].charge_full_design = 2600;
> @@ -508,7 +504,7 @@ bmdevs_of_probe(struct device *dev,
> if (thermistor == NTC_EXTERNAL) {
> btype->batres_tbl =
> temp_to_batres_tbl_ext_thermistor;
> - } else if (strncmp(bat_tech, "LION", 4) == 0) {
> + } else if (strncmp(btech, "LION", 4) == 0) {
> btype->batres_tbl =
> temp_to_batres_tbl_9100;
> } else {
Code is good though.
Once you have a sensible commit message you can apply my Acked-by
for both patches.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-30 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 19:27 [PATCH] ab8500: remove explicit handling of battery type Rajanikanth H.V
2012-11-28 19:27 ` Rajanikanth H.V
2012-11-30 11:12 ` Lee Jones [this message]
2012-11-30 11:12 ` Lee Jones
2012-12-01 18:09 ` Francesco Lavra
2012-12-01 18:09 ` Francesco Lavra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130111227.GE26023@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.