* [PATCH] ARM: sunxi: add missing include for mdelay()
@ 2012-11-30 1:37 ` Josh Cartwright
0 siblings, 0 replies; 6+ messages in thread
From: Josh Cartwright @ 2012-11-30 1:37 UTC (permalink / raw)
To: linux-arm-kernel
CC arch/arm/mach-sunxi/sunxi.o
./arch/arm/mach-sunxi/sunxi.c: In function 'sunxi_restart':
./arch/arm/mach-sunxi/sunxi.c:55:3: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]
Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
---
Fixes multiplatform build error seen with today's linux-next-20121129.
arch/arm/mach-sunxi/sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
index dc634ae..9be910f 100644
--- a/arch/arm/mach-sunxi/sunxi.c
+++ b/arch/arm/mach-sunxi/sunxi.c
@@ -10,6 +10,7 @@
* warranty of any kind, whether express or implied.
*/
+#include <linux/delay.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/of_address.h>
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: sunxi: add missing include for mdelay()
@ 2012-11-30 1:37 ` Josh Cartwright
0 siblings, 0 replies; 6+ messages in thread
From: Josh Cartwright @ 2012-11-30 1:37 UTC (permalink / raw)
To: Maxime Ripard, arm; +Cc: linux-arm-kernel, linux-kernel
CC arch/arm/mach-sunxi/sunxi.o
./arch/arm/mach-sunxi/sunxi.c: In function 'sunxi_restart':
./arch/arm/mach-sunxi/sunxi.c:55:3: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]
Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
---
Fixes multiplatform build error seen with today's linux-next-20121129.
arch/arm/mach-sunxi/sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
index dc634ae..9be910f 100644
--- a/arch/arm/mach-sunxi/sunxi.c
+++ b/arch/arm/mach-sunxi/sunxi.c
@@ -10,6 +10,7 @@
* warranty of any kind, whether express or implied.
*/
+#include <linux/delay.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/of_address.h>
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: sunxi: add missing include for mdelay()
2012-11-30 1:37 ` Josh Cartwright
@ 2012-11-30 8:18 ` Maxime Ripard
-1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2012-11-30 8:18 UTC (permalink / raw)
To: linux-arm-kernel
Le 30/11/2012 02:37, Josh Cartwright a ?crit :
> CC arch/arm/mach-sunxi/sunxi.o
> ./arch/arm/mach-sunxi/sunxi.c: In function 'sunxi_restart':
> ./arch/arm/mach-sunxi/sunxi.c:55:3: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> Fixes multiplatform build error seen with today's linux-next-20121129.
>
> arch/arm/mach-sunxi/sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
> index dc634ae..9be910f 100644
> --- a/arch/arm/mach-sunxi/sunxi.c
> +++ b/arch/arm/mach-sunxi/sunxi.c
> @@ -10,6 +10,7 @@
> * warranty of any kind, whether express or implied.
> */
>
> +#include <linux/delay.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/of_address.h>
>
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: sunxi: add missing include for mdelay()
@ 2012-11-30 8:18 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2012-11-30 8:18 UTC (permalink / raw)
To: Josh Cartwright; +Cc: arm, linux-arm-kernel, linux-kernel
Le 30/11/2012 02:37, Josh Cartwright a écrit :
> CC arch/arm/mach-sunxi/sunxi.o
> ./arch/arm/mach-sunxi/sunxi.c: In function 'sunxi_restart':
> ./arch/arm/mach-sunxi/sunxi.c:55:3: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> Fixes multiplatform build error seen with today's linux-next-20121129.
>
> arch/arm/mach-sunxi/sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
> index dc634ae..9be910f 100644
> --- a/arch/arm/mach-sunxi/sunxi.c
> +++ b/arch/arm/mach-sunxi/sunxi.c
> @@ -10,6 +10,7 @@
> * warranty of any kind, whether express or implied.
> */
>
> +#include <linux/delay.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/of_address.h>
>
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: sunxi: add missing include for mdelay()
2012-11-30 8:18 ` Maxime Ripard
@ 2012-11-30 17:58 ` Olof Johansson
-1 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2012-11-30 17:58 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 30, 2012 at 09:18:18AM +0100, Maxime Ripard wrote:
> Le 30/11/2012 02:37, Josh Cartwright a ?crit :
> > CC arch/arm/mach-sunxi/sunxi.o
> > ./arch/arm/mach-sunxi/sunxi.c: In function 'sunxi_restart':
> > ./arch/arm/mach-sunxi/sunxi.c:55:3: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]
> >
> > Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
Thanks, applied on top of sunxi/soc2.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: sunxi: add missing include for mdelay()
@ 2012-11-30 17:58 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2012-11-30 17:58 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Josh Cartwright, arm, linux-arm-kernel, linux-kernel
On Fri, Nov 30, 2012 at 09:18:18AM +0100, Maxime Ripard wrote:
> Le 30/11/2012 02:37, Josh Cartwright a écrit :
> > CC arch/arm/mach-sunxi/sunxi.o
> > ./arch/arm/mach-sunxi/sunxi.c: In function 'sunxi_restart':
> > ./arch/arm/mach-sunxi/sunxi.c:55:3: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]
> >
> > Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
Thanks, applied on top of sunxi/soc2.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-30 17:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-30 1:37 [PATCH] ARM: sunxi: add missing include for mdelay() Josh Cartwright
2012-11-30 1:37 ` Josh Cartwright
2012-11-30 8:18 ` Maxime Ripard
2012-11-30 8:18 ` Maxime Ripard
2012-11-30 17:58 ` Olof Johansson
2012-11-30 17:58 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.