From: Stephen Hemminger <shemminger@vyatta.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: mlindner@marvell.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: sky2: Correct mistakenly switched read/write sequence
Date: Sat, 1 Dec 2012 10:36:53 -0800 [thread overview]
Message-ID: <20121201103653.444b5087@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20121201124239.GB3914@neptun>
On Sat, 1 Dec 2012 13:42:39 +0100
Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote:
> In sky2_all_down() the order of the read()/write() access to B0_IMSK seems to
> be mistakenly switched. The original intention was obviously to avoid PCI write
> posting.
> This patch fixes the order.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
You are both right. David is correct in that the original code here
was quite different and was doing save/restore of irq mask.
That changed as driver evolved to only bring up IRQ if device was
brought up. At which point the read of irq mask was a left over call.
Lino is correct, it makes sense to do read after write to ensure PCI posting.
So I agree with the patch, but would like the commit message changed
slightly.
prev parent reply other threads:[~2012-12-01 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 12:42 sky2: Correct mistakenly switched read/write sequence Lino Sanfilippo
2012-12-01 17:27 ` David Miller
2012-12-01 20:06 ` Lino Sanfilippo
2012-12-01 18:36 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201103653.444b5087@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=LinoSanfilippo@gmx.de \
--cc=davem@davemloft.net \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.