From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: David Miller <davem@davemloft.net>
Cc: LinoSanfilippo@gmx.de, shemminger@vyatta.com,
mlindner@marvell.com, netdev@vger.kernel.org
Subject: Re: sky2: Correct mistakenly switched read/write sequence
Date: Sat, 1 Dec 2012 21:06:11 +0100 [thread overview]
Message-ID: <20121201200611.GA9527@neptun> (raw)
In-Reply-To: <20121201.122701.2065141028797970034.davem@davemloft.net>
On Sat, Dec 01, 2012 at 12:27:01PM -0500, David Miller wrote:
>
> > In sky2_all_down() the order of the read()/write() access to B0_IMSK seems to
> > be mistakenly switched. The original intention was obviously to avoid PCI write
> > posting.
> > This patch fixes the order.
> >
> > Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
>
> I would say that no such intention exists at all.
>
> The read is there because a long time ago the result as used
> to compute an 'imask' variable.
>
> Please see commit:
>
> commit d72ff8fa7f8b344382963721f842256825c4660b
I see. Indeed I was not aware of the history that led to the recent code, so
thanks for pointing that out.
However, since Stephen thinks the patch is useful nevertheless:
@Stephen please feel free to adjust the commit message as you think would make
the most sense.
Regards,
Lino
next prev parent reply other threads:[~2012-12-01 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 12:42 sky2: Correct mistakenly switched read/write sequence Lino Sanfilippo
2012-12-01 17:27 ` David Miller
2012-12-01 20:06 ` Lino Sanfilippo [this message]
2012-12-01 18:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201200611.GA9527@neptun \
--to=linosanfilippo@gmx.de \
--cc=davem@davemloft.net \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.