From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Olof Johansson <olof@lixom.net>
Cc: Simon Glass <sjg@chromium.org>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
grundler@chromium.org, naveen@chromium.org,
w.sang@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation
Date: Sat, 1 Dec 2012 13:26:34 +0000 [thread overview]
Message-ID: <20121201132632.GA17981@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOesGMgE0JEHsdySpua34_kbWi1+z4n4UdW0kumiJEROi7O2pQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote:
> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass <sjg@chromium.org> wrote:
> > It was originally done separately but I think it was felt that this
> > was overly complex. Olof can you please comment on this?
> it is indeed not controller specific per se, but we are unaware of any
> other platform/driver using it. So, it seemed reasonable to implement
> it in the driver as long as we have only one user; if another one
> comes along it's of course better to move it to the common i2c code.
> At least that was my opinion at the time. I could be convinced
> otherwise if someone else has strong opinions on the matter.
This sort of approach is half the reason SPI ended up being so fun... I
suspect if you look hard enough you'll find that this is just the first
time someone tried to upstream such a scheme. This is all especially
true for the DT bindings, even if the implementation is driver local for
now it'd be better to define generic bindings.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation
Date: Sat, 1 Dec 2012 13:26:34 +0000 [thread overview]
Message-ID: <20121201132632.GA17981@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOesGMgE0JEHsdySpua34_kbWi1+z4n4UdW0kumiJEROi7O2pQ@mail.gmail.com>
On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote:
> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass <sjg@chromium.org> wrote:
> > It was originally done separately but I think it was felt that this
> > was overly complex. Olof can you please comment on this?
> it is indeed not controller specific per se, but we are unaware of any
> other platform/driver using it. So, it seemed reasonable to implement
> it in the driver as long as we have only one user; if another one
> comes along it's of course better to move it to the common i2c code.
> At least that was my opinion at the time. I could be convinced
> otherwise if someone else has strong opinions on the matter.
This sort of approach is half the reason SPI ended up being so fun... I
suspect if you look hard enough you'll find that this is just the first
time someone tried to upstream such a scheme. This is all especially
true for the DT bindings, even if the implementation is driver local for
now it'd be better to define generic bindings.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121201/67e3ccb9/attachment.sig>
next prev parent reply other threads:[~2012-12-01 13:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 5:05 [PATCH 0/2] i2c-s3c2410: Implementation bus arbitration support Naveen Krishna Chatradhi
2012-11-29 5:05 ` Naveen Krishna Chatradhi
2012-11-29 5:05 ` [PATCH 1/2] i2c-s3c2410: Leave the bus disabled unless it is in use Naveen Krishna Chatradhi
2012-11-29 5:05 ` Naveen Krishna Chatradhi
2012-11-29 14:44 ` Kyungmin Park
2012-11-29 14:44 ` Kyungmin Park
[not found] ` <CAH9JG2VZAZfpfCjtxgMDsJPNf10FOO_PNV4poVkTgX=2XCoEpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-07 12:02 ` Naveen Krishna Ch
2013-01-07 12:02 ` Naveen Krishna Ch
2013-01-07 12:02 ` Naveen Krishna Ch
[not found] ` <1354165536-18529-2-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-01-24 12:20 ` Wolfram Sang
2013-01-24 12:20 ` Wolfram Sang
2013-01-24 12:20 ` Wolfram Sang
2014-02-07 8:50 ` Naveen Krishna Ch
2014-02-07 8:50 ` Naveen Krishna Ch
2014-02-07 8:54 ` [PATCH] " Naveen Krishna Chatradhi
2014-03-12 19:27 ` Wolfram Sang
2014-03-12 19:29 ` Wolfram Sang
2012-11-29 5:05 ` [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation Naveen Krishna Chatradhi
2012-11-29 5:05 ` Naveen Krishna Chatradhi
[not found] ` <1354165536-18529-3-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-11-29 16:34 ` Mark Brown
2012-11-29 16:34 ` Mark Brown
2012-11-29 16:34 ` Mark Brown
2012-11-30 2:13 ` Simon Glass
2012-11-30 2:13 ` Simon Glass
[not found] ` <CAPnjgZ0atD3k=gT0vjgkLO_SA8DMak6SiT6nZ_2T6WFqtK0szQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-30 6:14 ` Olof Johansson
2012-11-30 6:14 ` Olof Johansson
2012-11-30 6:14 ` Olof Johansson
2012-12-01 13:26 ` Mark Brown [this message]
2012-12-01 13:26 ` Mark Brown
[not found] ` <20121201132632.GA17981-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-04 0:11 ` Olof Johansson
2012-12-04 0:11 ` Olof Johansson
2012-12-04 0:11 ` Olof Johansson
[not found] ` <CAOesGMgzBGieYJ131sUX7u8EWPEusxareFzC0XPt48+oNuh-xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-04 5:15 ` Naveen Krishna Ch
2012-12-04 5:15 ` Naveen Krishna Ch
2012-12-04 5:15 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201132632.GA17981@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ch.naveen@samsung.com \
--cc=grundler@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveen@chromium.org \
--cc=olof@lixom.net \
--cc=sjg@chromium.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.