From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Patrick McLean <patrick@cim.mcgill.ca>,
Patrick McLean <patrickm@gaikai.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: Regression with initramfs and nfsroot (appears to be in the dcache)
Date: Sat, 1 Dec 2012 21:40:00 +0000 [thread overview]
Message-ID: <20121201213959.GJ4939@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA90B32EECB@SACEXCMBX04-PRD.hq.netapp.com>
On Fri, Nov 30, 2012 at 01:58:18PM +0000, Myklebust, Trond wrote:
> The reason for the choice of d_drop over d_invalidate() is the d_count
> checks. It really doesn't matter whether or not the client thinks it has
> users for a directory if the server is telling you that it is ESTALE. So
> we force a d_drop to prevent further lookups from finding it.
>
> IOW: It is there in order to fix the case where the user does
> 'rmdir("foo"); mkdir("foo")' on the server.
You do realize that your have_submounts() check in there is inherently
racy, right?
next prev parent reply other threads:[~2012-12-01 21:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 19:16 Regression with initramfs and nfsroot (appears to be in the dcache) Patrick McLean
2012-11-29 21:33 ` Al Viro
2012-11-29 22:06 ` Patrick McLean
2012-11-29 22:21 ` Al Viro
2012-11-29 22:53 ` Patrick McLean
2012-11-29 23:43 ` Al Viro
2012-11-30 0:19 ` Patrick McLean
2012-11-30 0:35 ` Al Viro
2012-11-30 0:57 ` Patrick McLean
2012-11-30 1:36 ` Al Viro
2012-11-30 1:54 ` Patrick McLean
2012-11-30 2:00 ` Al Viro
2012-11-30 2:00 ` Al Viro
2012-11-30 2:33 ` Patrick McLean
2012-11-30 2:33 ` Patrick McLean
2012-11-30 4:11 ` Al Viro
2012-11-30 4:11 ` Al Viro
2012-11-30 13:58 ` Myklebust, Trond
2012-11-30 13:58 ` Myklebust, Trond
2012-11-30 13:58 ` Myklebust, Trond
2012-12-01 21:40 ` Al Viro [this message]
2012-12-01 2:18 ` Simon Kirby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201213959.GJ4939@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=patrick@cim.mcgill.ca \
--cc=patrickm@gaikai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.