* [PATCH 1/1] ASoC: da7210: Remove unnecessary regmap_exit call
@ 2012-12-03 8:13 Sachin Kamat
2012-12-03 8:25 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2012-12-03 8:13 UTC (permalink / raw)
To: alsa-devel; +Cc: patches, tiwai, broonie, sachin.kamat, dchen, lrg
Use of devm_regmap_init_spi does not require an explicit
regmap_exit call.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
sound/soc/codecs/da7210.c | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index ab1ee5b..843c1eb 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -1337,24 +1337,15 @@ static int __devinit da7210_spi_probe(struct spi_device *spi)
if (ret != 0)
dev_warn(&spi->dev, "Failed to apply regmap patch: %d\n", ret);
- ret = snd_soc_register_codec(&spi->dev,
+ ret = snd_soc_register_codec(&spi->dev,
&soc_codec_dev_da7210, &da7210_dai, 1);
- if (ret < 0)
- goto err_regmap;
-
- return ret;
-
-err_regmap:
- regmap_exit(da7210->regmap);
return ret;
}
static int __devexit da7210_spi_remove(struct spi_device *spi)
{
- struct da7210_priv *da7210 = spi_get_drvdata(spi);
snd_soc_unregister_codec(&spi->dev);
- regmap_exit(da7210->regmap);
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ASoC: da7210: Remove unnecessary regmap_exit call
2012-12-03 8:13 [PATCH 1/1] ASoC: da7210: Remove unnecessary regmap_exit call Sachin Kamat
@ 2012-12-03 8:25 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-12-03 8:25 UTC (permalink / raw)
To: Sachin Kamat; +Cc: alsa-devel, patches, tiwai, dchen, lrg
On Mon, Dec 03, 2012 at 01:43:43PM +0530, Sachin Kamat wrote:
> Use of devm_regmap_init_spi does not require an explicit
> regmap_exit call.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-03 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 8:13 [PATCH 1/1] ASoC: da7210: Remove unnecessary regmap_exit call Sachin Kamat
2012-12-03 8:25 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.