From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] rtc: sa1100: enable/disable rtc when probe/remove the device
Date: Mon, 3 Dec 2012 09:48:29 +0000 [thread overview]
Message-ID: <20121203094828.GA14363@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CADApbegrJDe5SiO255WdKYai1U7WjBYfMHuCm-hTNfx5p6Wz-Q@mail.gmail.com>
On Mon, Dec 03, 2012 at 10:53:07AM +0800, Chao Xie wrote:
> I want to correct what i said. For the irq register/unregister i think
> can be done at open/release. But for clock enable/disable, i do not
> think so. If clock is disabled, as i think RTC will not work. User API
> still use open->get_time->close for "date" command. It means that RTC
> will not return correct date to user.
"I think" is not good enough for patches like this. Please test it.
On SA11x0 and PXA platforms, the clock for the sa1100-rtc is a dummy
clock; it has no effect. For MMP, I don't have access to the TRMs so
that's something you're going to have to find out.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Chao Xie <xiechao.mail@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
Chao Xie <chao.xie@marvell.com>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] rtc: sa1100: enable/disable rtc when probe/remove the device
Date: Mon, 3 Dec 2012 09:48:29 +0000 [thread overview]
Message-ID: <20121203094828.GA14363@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CADApbegrJDe5SiO255WdKYai1U7WjBYfMHuCm-hTNfx5p6Wz-Q@mail.gmail.com>
On Mon, Dec 03, 2012 at 10:53:07AM +0800, Chao Xie wrote:
> I want to correct what i said. For the irq register/unregister i think
> can be done at open/release. But for clock enable/disable, i do not
> think so. If clock is disabled, as i think RTC will not work. User API
> still use open->get_time->close for "date" command. It means that RTC
> will not return correct date to user.
"I think" is not good enough for patches like this. Please test it.
On SA11x0 and PXA platforms, the clock for the sa1100-rtc is a dummy
clock; it has no effect. For MMP, I don't have access to the TRMs so
that's something you're going to have to find out.
next prev parent reply other threads:[~2012-12-03 9:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 2:21 [PATCH 1/4] rtc: sa1100: enable/disable rtc when probe/remove the device Chao Xie
2012-11-29 2:21 ` Chao Xie
2012-11-29 2:21 ` [PATCH 2/4] rtc: pxa: fix rtc caculation issue Chao Xie
2012-11-29 2:21 ` Chao Xie
2012-11-29 20:04 ` Robert Jarzmik
2012-11-29 20:04 ` Robert Jarzmik
2012-12-03 2:40 ` Chao Xie
2012-12-03 2:40 ` Chao Xie
2012-12-04 2:53 ` Chao Xie
2012-12-04 2:53 ` Chao Xie
2012-11-29 2:21 ` [PATCH 3/4] rtc: pxa: add pxa95x rtc support Chao Xie
2012-11-29 2:21 ` Chao Xie
2012-12-04 7:03 ` Haojian Zhuang
2012-12-04 7:03 ` Haojian Zhuang
2012-11-29 2:21 ` [PATCH 4/4] rtc: pxa: request rtc irqs when probe/remove the device Chao Xie
2012-11-29 2:21 ` Chao Xie
2012-11-29 10:26 ` Russell King - ARM Linux
2012-11-29 10:26 ` Russell King - ARM Linux
2012-11-29 20:10 ` Robert Jarzmik
2012-11-29 20:10 ` Robert Jarzmik
2012-11-29 10:25 ` [PATCH 1/4] rtc: sa1100: enable/disable rtc " Russell King - ARM Linux
2012-11-29 10:25 ` Russell King - ARM Linux
2012-11-30 7:04 ` Haojian Zhuang
2012-11-30 7:04 ` Haojian Zhuang
2012-12-03 1:39 ` Chao Xie
2012-12-03 1:39 ` Chao Xie
2012-12-03 2:53 ` Chao Xie
2012-12-03 2:53 ` Chao Xie
2012-12-03 5:35 ` Haojian Zhuang
2012-12-03 5:35 ` Haojian Zhuang
2012-12-03 5:42 ` Chao Xie
2012-12-03 5:42 ` Chao Xie
2012-12-03 9:48 ` Russell King - ARM Linux [this message]
2012-12-03 9:48 ` Russell King - ARM Linux
2012-12-04 2:51 ` Chao Xie
2012-12-04 2:51 ` Chao Xie
2012-12-04 7:01 ` Haojian Zhuang
2012-12-04 7:01 ` Haojian Zhuang
2012-12-03 5:33 ` Haojian Zhuang
2012-12-03 5:33 ` Haojian Zhuang
2012-12-03 5:02 ` devendra.aaru
2012-12-03 5:02 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203094828.GA14363@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.