Re: [Powertop] [PATCH 3/3] process: Get rid of unused dbg_printf_pevent_info()

Re: [Powertop] [PATCH 3/3] process: Get rid of unused dbg_printf_pevent_info()

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

On (12/04/12 00:13), Namhyung Kim wrote:
> This function is not used, just remove it.
> This fixes following warning:
> 
>   CXX    process/powertop-do_process.o
> process/do_process.cpp:190: warning: ‘void dbg_printf_pevent_info(event_format*, pevent_record*)’ defined but not used
> 
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
>  src/process/do_process.cpp |   13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/src/process/do_process.cpp b/src/process/do_process.cpp
> index 6ac0fae..a07b3f3 100644
> --- a/src/process/do_process.cpp
> +++ b/src/process/do_process.cpp
> @@ -187,19 +187,6 @@ int dont_blame_me(char *comm)
>  	return 0;
>  }
>  
> -static void dbg_printf_pevent_info(struct event_format *event, struct pevent_record *rec)
> -{
> -	static struct trace_seq s;
> -
> -	event->pevent->print_raw = 1;
> -	trace_seq_init(&s);
> -	pevent_event_info(&s, event, rec);
> -	trace_seq_putc(&s, '\n');
> -	trace_seq_terminate(&s);
> -	fprintf(stderr, "%.*s", s.len, s.buffer);
> -	trace_seq_destroy(&s);
> -}
> -
>  static char * get_pevent_field_str(void *trace, struct event_format *event, struct format_field *field)
>  {
>  	unsigned long long offset, len;


this one looks good to me.

	-ss

Re: [Powertop] [PATCH 3/3] process: Get rid of unused dbg_printf_pevent_info()

[Kristen Carlson Accardi]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

On Tue,  4 Dec 2012 00:13:20 +0900
Namhyung Kim <namhyung(a)gmail.com> wrote:

> This function is not used, just remove it.
> This fixes following warning:
> 
>   CXX    process/powertop-do_process.o
> process/do_process.cpp:190: warning: ‘void
> dbg_printf_pevent_info(event_format*, pevent_record*)’ defined but
> not used
> 
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---
>  src/process/do_process.cpp |   13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/src/process/do_process.cpp b/src/process/do_process.cpp
> index 6ac0fae..a07b3f3 100644
> --- a/src/process/do_process.cpp
> +++ b/src/process/do_process.cpp
> @@ -187,19 +187,6 @@ int dont_blame_me(char *comm)
>  	return 0;
>  }
>  
> -static void dbg_printf_pevent_info(struct event_format *event,
> struct pevent_record *rec) -{
> -	static struct trace_seq s;
> -
> -	event->pevent->print_raw = 1;
> -	trace_seq_init(&s);
> -	pevent_event_info(&s, event, rec);
> -	trace_seq_putc(&s, '\n');
> -	trace_seq_terminate(&s);
> -	fprintf(stderr, "%.*s", s.len, s.buffer);
> -	trace_seq_destroy(&s);
> -}
> -
>  static char * get_pevent_field_str(void *trace, struct event_format
> *event, struct format_field *field) {
>  	unsigned long long offset, len;

Applied, thanks.

Kristen

[Powertop] [PATCH 3/3] process: Get rid of unused dbg_printf_pevent_info()

[Namhyung Kim]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

This function is not used, just remove it.
This fixes following warning:

  CXX    process/powertop-do_process.o
process/do_process.cpp:190: warning: ‘void dbg_printf_pevent_info(event_format*, pevent_record*)’ defined but not used

Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
---
 src/process/do_process.cpp |   13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/process/do_process.cpp b/src/process/do_process.cpp
index 6ac0fae..a07b3f3 100644
--- a/src/process/do_process.cpp
+++ b/src/process/do_process.cpp
@@ -187,19 +187,6 @@ int dont_blame_me(char *comm)
 	return 0;
 }
 
-static void dbg_printf_pevent_info(struct event_format *event, struct pevent_record *rec)
-{
-	static struct trace_seq s;
-
-	event->pevent->print_raw = 1;
-	trace_seq_init(&s);
-	pevent_event_info(&s, event, rec);
-	trace_seq_putc(&s, '\n');
-	trace_seq_terminate(&s);
-	fprintf(stderr, "%.*s", s.len, s.buffer);
-	trace_seq_destroy(&s);
-}
-
 static char * get_pevent_field_str(void *trace, struct event_format *event, struct format_field *field)
 {
 	unsigned long long offset, len;
-- 
1.7.9.2