* [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
@ 2012-11-30 15:24 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2012-11-30 15:24 UTC (permalink / raw)
To: linux-arm-kernel
When the STMPE IRQ is triggered to be active high level-sensitive, the
Nomadik GPIO controller it uses complains, although it still works.
Recently we attempted to move triggering to low-to-high in an attempt
to prevent the warning; however, this ensured that the IRQ was actually
missed completely. Now we have a solution which both works and keeps the
GPIO controller happy.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/boot/dts/stuib.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stuib.dtsi b/arch/arm/boot/dts/stuib.dtsi
index 39446a2..615392a 100644
--- a/arch/arm/boot/dts/stuib.dtsi
+++ b/arch/arm/boot/dts/stuib.dtsi
@@ -15,7 +15,7 @@
stmpe1601: stmpe1601 at 40 {
compatible = "st,stmpe1601";
reg = <0x40>;
- interrupts = <26 0x1>;
+ interrupts = <26 0x2>;
interrupt-parent = <&gpio6>;
interrupt-controller;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
@ 2012-11-30 15:24 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2012-11-30 15:24 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: arnd, linus.walleij, Lee Jones
When the STMPE IRQ is triggered to be active high level-sensitive, the
Nomadik GPIO controller it uses complains, although it still works.
Recently we attempted to move triggering to low-to-high in an attempt
to prevent the warning; however, this ensured that the IRQ was actually
missed completely. Now we have a solution which both works and keeps the
GPIO controller happy.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/boot/dts/stuib.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stuib.dtsi b/arch/arm/boot/dts/stuib.dtsi
index 39446a2..615392a 100644
--- a/arch/arm/boot/dts/stuib.dtsi
+++ b/arch/arm/boot/dts/stuib.dtsi
@@ -15,7 +15,7 @@
stmpe1601: stmpe1601@40 {
compatible = "st,stmpe1601";
reg = <0x40>;
- interrupts = <26 0x1>;
+ interrupts = <26 0x2>;
interrupt-parent = <&gpio6>;
interrupt-controller;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
2012-11-30 15:24 ` Lee Jones
@ 2012-12-01 16:51 ` Linus Walleij
-1 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2012-12-01 16:51 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
> When the STMPE IRQ is triggered to be active high level-sensitive, the
> Nomadik GPIO controller it uses complains, although it still works.
> Recently we attempted to move triggering to low-to-high in an attempt
> to prevent the warning; however, this ensured that the IRQ was actually
> missed completely. Now we have a solution which both works and keeps the
> GPIO controller happy.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Is this something I should put into the ux500 tree or will you
take care of this in a separate pull request?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
@ 2012-12-01 16:51 ` Linus Walleij
0 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2012-12-01 16:51 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
> When the STMPE IRQ is triggered to be active high level-sensitive, the
> Nomadik GPIO controller it uses complains, although it still works.
> Recently we attempted to move triggering to low-to-high in an attempt
> to prevent the warning; however, this ensured that the IRQ was actually
> missed completely. Now we have a solution which both works and keeps the
> GPIO controller happy.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Is this something I should put into the ux500 tree or will you
take care of this in a separate pull request?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
2012-12-01 16:51 ` Linus Walleij
@ 2012-12-04 9:12 ` Lee Jones
-1 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2012-12-04 9:12 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 01 Dec 2012, Linus Walleij wrote:
> On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > When the STMPE IRQ is triggered to be active high level-sensitive, the
> > Nomadik GPIO controller it uses complains, although it still works.
> > Recently we attempted to move triggering to low-to-high in an attempt
> > to prevent the warning; however, this ensured that the IRQ was actually
> > missed completely. Now we have a solution which both works and keeps the
> > GPIO controller happy.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Is this something I should put into the ux500 tree or will you
> take care of this in a separate pull request?
Can you still get this into the RCs, as it's a bugfix?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
@ 2012-12-04 9:12 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2012-12-04 9:12 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Sat, 01 Dec 2012, Linus Walleij wrote:
> On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > When the STMPE IRQ is triggered to be active high level-sensitive, the
> > Nomadik GPIO controller it uses complains, although it still works.
> > Recently we attempted to move triggering to low-to-high in an attempt
> > to prevent the warning; however, this ensured that the IRQ was actually
> > missed completely. Now we have a solution which both works and keeps the
> > GPIO controller happy.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Is this something I should put into the ux500 tree or will you
> take care of this in a separate pull request?
Can you still get this into the RCs, as it's a bugfix?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
2012-12-04 9:12 ` Lee Jones
@ 2012-12-04 12:31 ` Linus Walleij
-1 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2012-12-04 12:31 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 4, 2012 at 10:12 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Sat, 01 Dec 2012, Linus Walleij wrote:
>
>> On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>
>> > When the STMPE IRQ is triggered to be active high level-sensitive, the
>> > Nomadik GPIO controller it uses complains, although it still works.
>> > Recently we attempted to move triggering to low-to-high in an attempt
>> > to prevent the warning; however, this ensured that the IRQ was actually
>> > missed completely. Now we have a solution which both works and keeps the
>> > GPIO controller happy.
>> >
>> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Is this something I should put into the ux500 tree or will you
>> take care of this in a separate pull request?
>
> Can you still get this into the RCs, as it's a bugfix?
Well it doesn't apply to the -rc:s since it's patching
arch/arm/boot/dts/stuib.dtsi which does not exist in
the v3.7 series.
Either what you want is to submit a fix to Arnd & Olof
on top of your previous DT patches, or you need to send
a rebased version...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
@ 2012-12-04 12:31 ` Linus Walleij
0 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2012-12-04 12:31 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Tue, Dec 4, 2012 at 10:12 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Sat, 01 Dec 2012, Linus Walleij wrote:
>
>> On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>
>> > When the STMPE IRQ is triggered to be active high level-sensitive, the
>> > Nomadik GPIO controller it uses complains, although it still works.
>> > Recently we attempted to move triggering to low-to-high in an attempt
>> > to prevent the warning; however, this ensured that the IRQ was actually
>> > missed completely. Now we have a solution which both works and keeps the
>> > GPIO controller happy.
>> >
>> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Is this something I should put into the ux500 tree or will you
>> take care of this in a separate pull request?
>
> Can you still get this into the RCs, as it's a bugfix?
Well it doesn't apply to the -rc:s since it's patching
arch/arm/boot/dts/stuib.dtsi which does not exist in
the v3.7 series.
Either what you want is to submit a fix to Arnd & Olof
on top of your previous DT patches, or you need to send
a rebased version...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
2012-12-04 12:31 ` Linus Walleij
@ 2012-12-04 13:58 ` Lee Jones
-1 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2012-12-04 13:58 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 04 Dec 2012, Linus Walleij wrote:
> On Tue, Dec 4, 2012 at 10:12 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Sat, 01 Dec 2012, Linus Walleij wrote:
> >
> >> On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
> >>
> >> > When the STMPE IRQ is triggered to be active high level-sensitive, the
> >> > Nomadik GPIO controller it uses complains, although it still works.
> >> > Recently we attempted to move triggering to low-to-high in an attempt
> >> > to prevent the warning; however, this ensured that the IRQ was actually
> >> > missed completely. Now we have a solution which both works and keeps the
> >> > GPIO controller happy.
> >> >
> >> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >>
> >> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> Is this something I should put into the ux500 tree or will you
> >> take care of this in a separate pull request?
> >
> > Can you still get this into the RCs, as it's a bugfix?
>
> Well it doesn't apply to the -rc:s since it's patching
> arch/arm/boot/dts/stuib.dtsi which does not exist in
> the v3.7 series.
>
> Either what you want is to submit a fix to Arnd & Olof
> on top of your previous DT patches, or you need to send
> a rebased version...
Ah, well if it's fixing something that isn't in the -rc:s, then
it doesn't need to go into the -rc:s. Well as the merge window
is not long opening, I'll hold on to it and stick it in for -rc1
or something.
Thanks for letting me know.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low
@ 2012-12-04 13:58 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2012-12-04 13:58 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Tue, 04 Dec 2012, Linus Walleij wrote:
> On Tue, Dec 4, 2012 at 10:12 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Sat, 01 Dec 2012, Linus Walleij wrote:
> >
> >> On Fri, Nov 30, 2012 at 4:24 PM, Lee Jones <lee.jones@linaro.org> wrote:
> >>
> >> > When the STMPE IRQ is triggered to be active high level-sensitive, the
> >> > Nomadik GPIO controller it uses complains, although it still works.
> >> > Recently we attempted to move triggering to low-to-high in an attempt
> >> > to prevent the warning; however, this ensured that the IRQ was actually
> >> > missed completely. Now we have a solution which both works and keeps the
> >> > GPIO controller happy.
> >> >
> >> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >>
> >> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> Is this something I should put into the ux500 tree or will you
> >> take care of this in a separate pull request?
> >
> > Can you still get this into the RCs, as it's a bugfix?
>
> Well it doesn't apply to the -rc:s since it's patching
> arch/arm/boot/dts/stuib.dtsi which does not exist in
> the v3.7 series.
>
> Either what you want is to submit a fix to Arnd & Olof
> on top of your previous DT patches, or you need to send
> a rebased version...
Ah, well if it's fixing something that isn't in the -rc:s, then
it doesn't need to go into the -rc:s. Well as the merge window
is not long opening, I'll hold on to it and stick it in for -rc1
or something.
Thanks for letting me know.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-12-04 13:58 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-30 15:24 [PATCH 1/1] ARM: ux500: Change IRQ from low-to-high edge triggered to high-to-low Lee Jones
2012-11-30 15:24 ` Lee Jones
2012-12-01 16:51 ` Linus Walleij
2012-12-01 16:51 ` Linus Walleij
2012-12-04 9:12 ` Lee Jones
2012-12-04 9:12 ` Lee Jones
2012-12-04 12:31 ` Linus Walleij
2012-12-04 12:31 ` Linus Walleij
2012-12-04 13:58 ` Lee Jones
2012-12-04 13:58 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.