diff for duplicates of <20121205165921.GM6568@mwanda> diff --git a/a/1.txt b/N1/1.txt index 7d517f9..a6bcffb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,12 @@ On Wed, Dec 05, 2012 at 07:17:16AM -0800, Linus Torvalds wrote: > On Wed, Dec 5, 2012 at 4:44 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: -> > READ is zero so this test is always false. (rw = READ) was intended. +> > READ is zero so this test is always false. (rw == READ) was intended. > > Actually, that really *is* a bitmask, but yeah, the test is wrong. > > The correct test is > -> ((rw & RW_MASK) = READ) +> ((rw & RW_MASK) == READ) > Ah. Of course. I'll send a v2. diff --git a/a/content_digest b/N1/content_digest index c6f40ac..65eeb3d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0CA+55aFyCuepCzYq4zsLJyMO0yKzb=jD0-zv9zG6RyFYABOGe5w@mail.gmail.com\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [patch] vfs: clear to the end of the buffer on reads\0" - "Date\0Wed, 05 Dec 2012 16:59:21 +0000\0" + "Date\0Wed, 5 Dec 2012 19:59:21 +0300\0" "To\0Linus Torvalds <torvalds@linux-foundation.org>\0" "Cc\0Alexander Viro <viro@zeniv.linux.org.uk>" linux-fsdevel <linux-fsdevel@vger.kernel.org> @@ -14,13 +14,13 @@ "b\0" "On Wed, Dec 05, 2012 at 07:17:16AM -0800, Linus Torvalds wrote:\n" "> On Wed, Dec 5, 2012 at 4:44 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:\n" - "> > READ is zero so this test is always false. (rw = READ) was intended.\n" + "> > READ is zero so this test is always false. (rw == READ) was intended.\n" "> \n" "> Actually, that really *is* a bitmask, but yeah, the test is wrong.\n" "> \n" "> The correct test is\n" "> \n" - "> ((rw & RW_MASK) = READ)\n" + "> ((rw & RW_MASK) == READ)\n" "> \n" "\n" "Ah. Of course. I'll send a v2.\n" @@ -28,4 +28,4 @@ "regards,\n" dan carpenter -e89d92adb8b902728770ed8f59bd02233fcd700e462c98b8616cb20e1926467f +fd10d4e512077d096ecd074498ab8fe270c1bb9f0403abadc83d84f39aab57aa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.