From: Dan Carpenter <dan.carpenter@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Romain Francoise <romain@orebokech.com>,
Meelis Roos <mroos@linux.ee>, Tony Luck <tony.luck@intel.com>
Subject: Re: [patch] vfs: clear to the end of the buffer on reads
Date: Wed, 05 Dec 2012 16:59:21 +0000 [thread overview]
Message-ID: <20121205165921.GM6568@mwanda> (raw)
In-Reply-To: <CA+55aFyCuepCzYq4zsLJyMO0yKzb=jD0-zv9zG6RyFYABOGe5w@mail.gmail.com>
On Wed, Dec 05, 2012 at 07:17:16AM -0800, Linus Torvalds wrote:
> On Wed, Dec 5, 2012 at 4:44 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > READ is zero so this test is always false. (rw = READ) was intended.
>
> Actually, that really *is* a bitmask, but yeah, the test is wrong.
>
> The correct test is
>
> ((rw & RW_MASK) = READ)
>
Ah. Of course. I'll send a v2.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Romain Francoise <romain@orebokech.com>,
Meelis Roos <mroos@linux.ee>, Tony Luck <tony.luck@intel.com>
Subject: Re: [patch] vfs: clear to the end of the buffer on reads
Date: Wed, 5 Dec 2012 19:59:21 +0300 [thread overview]
Message-ID: <20121205165921.GM6568@mwanda> (raw)
In-Reply-To: <CA+55aFyCuepCzYq4zsLJyMO0yKzb=jD0-zv9zG6RyFYABOGe5w@mail.gmail.com>
On Wed, Dec 05, 2012 at 07:17:16AM -0800, Linus Torvalds wrote:
> On Wed, Dec 5, 2012 at 4:44 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > READ is zero so this test is always false. (rw == READ) was intended.
>
> Actually, that really *is* a bitmask, but yeah, the test is wrong.
>
> The correct test is
>
> ((rw & RW_MASK) == READ)
>
Ah. Of course. I'll send a v2.
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-05 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 12:44 [patch] vfs: clear to the end of the buffer on reads Dan Carpenter
2012-12-05 12:44 ` Dan Carpenter
2012-12-05 15:17 ` Linus Torvalds
2012-12-05 15:17 ` Linus Torvalds
2012-12-05 16:59 ` Dan Carpenter [this message]
2012-12-05 16:59 ` Dan Carpenter
2012-12-05 17:01 ` [patch v2] " Dan Carpenter
2012-12-05 17:01 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205165921.GM6568@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=romain@orebokech.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.