All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
To: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
Cc: Yinghai Lu <yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mfleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: Re: Use PCI ROMs from EFI boot services
Date: Thu, 6 Dec 2012 06:19:03 +0000	[thread overview]
Message-ID: <20121206061903.GA3068@srcf.ucam.org> (raw)
In-Reply-To: <50BFF328.5030406-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>

On Wed, Dec 05, 2012 at 05:21:44PM -0800, H. Peter Anvin wrote:
> On 12/05/2012 05:13 PM, Matthew Garrett wrote:
> >Yeah, it needs to be hidden from root - but ideally we'd be passing it to the second kernel if we kexec. Alternative would be for it to be capability bounded to a trusted signed kexec binary if we implement Vivek's IMA-based approach.
> >
> 
> Either way a security flag in the type field makes sense.

I've no objection to that, although I'm not sure there's any real reason 
to expose an incomplete setup_data to userspace. Any scenario in which 
kexec can't read the full data is one where kexec won't be able to 
call sys_kexec() anyway.

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-efi@vger.kernel.org, mfleming@intel.com,
	dwmw2@infradead.org, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: Use PCI ROMs from EFI boot services
Date: Thu, 6 Dec 2012 06:19:03 +0000	[thread overview]
Message-ID: <20121206061903.GA3068@srcf.ucam.org> (raw)
In-Reply-To: <50BFF328.5030406@zytor.com>

On Wed, Dec 05, 2012 at 05:21:44PM -0800, H. Peter Anvin wrote:
> On 12/05/2012 05:13 PM, Matthew Garrett wrote:
> >Yeah, it needs to be hidden from root - but ideally we'd be passing it to the second kernel if we kexec. Alternative would be for it to be capability bounded to a trusted signed kexec binary if we implement Vivek's IMA-based approach.
> >
> 
> Either way a security flag in the type field makes sense.

I've no objection to that, although I'm not sure there's any real reason 
to expose an incomplete setup_data to userspace. Any scenario in which 
kexec can't read the full data is one where kexec won't be able to 
call sys_kexec() anyway.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  parent reply	other threads:[~2012-12-06  6:19 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23 16:36 Use PCI ROMs from EFI boot services Matthew Garrett
2012-08-23 16:36 ` [PATCH V3 1/4] EFI: Stash ROMs if they're not in the PCI BAR Matthew Garrett
2012-08-23 23:44   ` Bjorn Helgaas
2012-08-24  4:09     ` Matthew Garrett
2012-09-04 13:45     ` Matthew Garrett
2012-09-06 13:59       ` Bjorn Helgaas
2012-09-06 17:36         ` [PATCH] x86: Fix build warning on 32-bit Matthew Garrett
2012-09-06 20:02           ` Bjorn Helgaas
2012-08-23 16:36 ` [PATCH V3 2/4] PCI: Add pcibios_add_device Matthew Garrett
2012-08-23 16:36 ` [PATCH V3 3/4] PCI: Add support for non-BAR ROMs Matthew Garrett
2012-09-05  2:18   ` Don Dutile
2012-09-05  2:29     ` Matthew Garrett
2012-09-05 12:46       ` Alan Cox
2012-09-05 13:20         ` Matthew Garrett
2012-09-05 13:30           ` Alan Cox
2012-09-05 13:44             ` Matthew Garrett
2012-08-23 16:36 ` [PATCH V3 4/4] X86: Use PCI setup data Matthew Garrett
2012-08-24  9:30 ` Use PCI ROMs from EFI boot services David Woodhouse
2012-08-24 12:53   ` Matthew Garrett
     [not found] ` <1345739803-21017-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-25 17:35   ` Bjorn Helgaas
2012-10-25 17:35     ` Bjorn Helgaas
2012-12-03 20:02     ` Seth Forshee
2012-12-05 20:09       ` Bjorn Helgaas
     [not found]         ` <CAErSpo7S2+Vt+9bkGLx_=AY9aSGCvAnkHfqu01gTj=eKs7btNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-05 20:22           ` Matthew Garrett
2012-12-05 20:22             ` Matthew Garrett
     [not found]             ` <20121205202254.GA25398-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2012-12-05 22:21               ` Bjorn Helgaas
2012-12-05 22:21                 ` Bjorn Helgaas
2012-12-05 21:06           ` David Woodhouse
2012-12-05 21:06             ` David Woodhouse
2012-12-06  0:15       ` Yinghai Lu
     [not found]         ` <CAE9FiQVdpmmExrPrLf7HYVuo0cTY9Xjn6bWzObbuSSeQ-e1PbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-06  0:18           ` Matthew Garrett
2012-12-06  0:18             ` Matthew Garrett
2012-12-06  0:21             ` H. Peter Anvin
     [not found]               ` <50BFE50C.8030008-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-06  0:30                 ` Yinghai Lu
2012-12-06  0:30                   ` Yinghai Lu
2012-12-06  0:36                   ` H. Peter Anvin
     [not found]                     ` <50BFE890.5070109-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-06  0:57                       ` Matthew Garrett
2012-12-06  0:57                         ` Matthew Garrett
2012-12-06  1:04                         ` H. Peter Anvin
2012-12-06  1:13                           ` Matthew Garrett
     [not found]                             ` <cd3b2e67-92af-494d-ba2d-4179ead6e06b-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2012-12-06  1:21                               ` H. Peter Anvin
2012-12-06  1:21                                 ` H. Peter Anvin
     [not found]                                 ` <50BFF328.5030406-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-06  6:19                                   ` Matthew Garrett [this message]
2012-12-06  6:19                                     ` Matthew Garrett
2012-12-06  1:00               ` Matthew Garrett
2012-12-06  0:22             ` Yinghai Lu
     [not found]             ` <20121206001819.GA30527-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2012-12-06  0:23               ` Eric W. Biederman
2012-12-06  0:23                 ` Eric W. Biederman
2012-12-06  0:36         ` H. Peter Anvin
2012-12-06  0:51           ` Yinghai Lu
     [not found]             ` <CAE9FiQXwZAAMkWYT8EjsewpuZ-OWqoaFscyzGS_pSuO9C3bf9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-06  0:52               ` Yinghai Lu
2012-12-06  0:52                 ` Yinghai Lu
2012-12-06 18:19                 ` Bjorn Helgaas
2012-12-06 18:26                   ` H. Peter Anvin
     [not found]                     ` <50C0E339.4030607-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-06 18:54                       ` Matthew Garrett
2012-12-06 18:54                         ` Matthew Garrett
2012-12-06 18:57                         ` Yinghai Lu
2012-12-06 21:44                         ` Bjorn Helgaas
2012-12-06  0:56               ` H. Peter Anvin
2012-12-06  0:56                 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206061903.GA3068@srcf.ucam.org \
    --to=mjg59-1xo5oi07kqx4cg9nei1l7q@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mfleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.