All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver
Date: Thu, 06 Dec 2012 14:14:15 +0000	[thread overview]
Message-ID: <20121206141415.10BB43E0948@localhost> (raw)
In-Reply-To: <1352288407-20594-4-git-send-email-hechtb@gmail.com>

On Wed,  7 Nov 2012 12:40:06 +0100, Bastian Hecht <hechtb@gmail.com> wrote:
> This adds the capability to retrieve setup data from the device tree
> node. The usage of platform data is still available.
> 
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>

Aside from the binding issues I've pointed out on patch 4, this change
looks fine. I'll wait for an updated patch before committing.

g.


WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Bastian Hecht <hechtb@gmail.com>,
	spi-devel-general@lists.sourceforge.net
Cc: Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver
Date: Thu, 06 Dec 2012 14:14:15 +0000	[thread overview]
Message-ID: <20121206141415.10BB43E0948@localhost> (raw)
In-Reply-To: <1352288407-20594-4-git-send-email-hechtb@gmail.com>

On Wed,  7 Nov 2012 12:40:06 +0100, Bastian Hecht <hechtb@gmail.com> wrote:
> This adds the capability to retrieve setup data from the device tree
> node. The usage of platform data is still available.
> 
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>

Aside from the binding issues I've pointed out on patch 4, this change
looks fine. I'll wait for an updated patch before committing.

g.


WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver
Date: Thu, 06 Dec 2012 14:14:15 +0000	[thread overview]
Message-ID: <20121206141415.10BB43E0948@localhost> (raw)
In-Reply-To: <1352288407-20594-4-git-send-email-hechtb@gmail.com>

On Wed,  7 Nov 2012 12:40:06 +0100, Bastian Hecht <hechtb@gmail.com> wrote:
> This adds the capability to retrieve setup data from the device tree
> node. The usage of platform data is still available.
> 
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>

Aside from the binding issues I've pointed out on patch 4, this change
looks fine. I'll wait for an updated patch before committing.

g.

  reply	other threads:[~2012-12-06 14:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-07 11:40 [PATCH RESEND 0/4] spi: sh-msiof: Add DT support Bastian Hecht
2012-11-07 11:40 ` Bastian Hecht
2012-11-07 11:40 ` Bastian Hecht
2012-11-07 11:40 ` [PATCH 1/4] spi: sh-msiof: Remove unneeded clock name Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-12-06 14:05   ` Grant Likely
2012-12-06 14:05     ` Grant Likely
2012-12-06 14:05     ` Grant Likely
2012-11-07 11:40 ` [PATCH 2/4] spi: Add SH Mobile series as dependency to MSIOF controller Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-11-07 11:40 ` [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-12-06 14:14   ` Grant Likely [this message]
2012-12-06 14:14     ` Grant Likely
2012-12-06 14:14     ` Grant Likely
2012-11-07 11:40 ` [PATCH 4/4] devicetree: Add Renesas SH Mobile MSIOF spi controller binding doc Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-11-07 11:40   ` Bastian Hecht
2012-12-06 14:08   ` Grant Likely
2012-12-06 14:08     ` Grant Likely
2012-12-06 14:08     ` Grant Likely
2012-12-06 14:13     ` Grant Likely
2012-12-06 14:13       ` Grant Likely
2012-12-06 14:13       ` Grant Likely
2012-12-12 11:26       ` Bastian Hecht
2012-12-12 11:26         ` Bastian Hecht
2012-12-12 11:26         ` Bastian Hecht
  -- strict thread matches above, loose matches on Subject: below --
2012-09-21 11:00 [PATCH 1/4] spi: sh-msiof: Remove unneeded clock name Bastian Hecht
     [not found] ` <1348225249-1294-1-git-send-email-hechtb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-21 11:00   ` [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver Bastian Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206141415.10BB43E0948@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.