From: Thomas Graf <tgraf@suug.ch>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] sctp: Add RCU protection to assoc->transport_addr_list
Date: Thu, 06 Dec 2012 19:08:35 +0000 [thread overview]
Message-ID: <20121206190835.GF16122@casper.infradead.org> (raw)
In-Reply-To: <50C0EAB5.3050303@gmail.com>
On 12/06/12 at 01:57pm, Vlad Yasevich wrote:
> On 12/06/2012 01:44 PM, Thomas Graf wrote:
> >On 12/06/12 at 01:35pm, Vlad Yasevich wrote:
> >>We may want to mark transports as dead sooner. Probably right about
> >>the time we pull them off the list.
> >
> >We mark it dead in sctp_transport_free() which is called at the
> >end of sctp_assoc_rm_peer(). Do you want to mark it dead at the
> >beginning of sctp_assoc_rm_peer() as well? (We still need to
> >mark in sctp_transport_free() anyway).
>
> Crud.. sctp_transport_free() is called directly in places... Hmm...
> the one in sctp_association_free() may need to be list_del_rcu()...
It's not really needed but it wouldn't be wrong from a
documentation perspective. The assoc is always unhashed
while holding head->lock before sctp_association_free()
and all current RCU readers of transport_addr_list access
the the assoc while holding a read-lock on head->lock.
Let me respin this patch and do a list_del_rcu() there
to document the RCU'iness of it.
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Graf <tgraf@suug.ch>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] sctp: Add RCU protection to assoc->transport_addr_list
Date: Thu, 6 Dec 2012 19:08:35 +0000 [thread overview]
Message-ID: <20121206190835.GF16122@casper.infradead.org> (raw)
In-Reply-To: <50C0EAB5.3050303@gmail.com>
On 12/06/12 at 01:57pm, Vlad Yasevich wrote:
> On 12/06/2012 01:44 PM, Thomas Graf wrote:
> >On 12/06/12 at 01:35pm, Vlad Yasevich wrote:
> >>We may want to mark transports as dead sooner. Probably right about
> >>the time we pull them off the list.
> >
> >We mark it dead in sctp_transport_free() which is called at the
> >end of sctp_assoc_rm_peer(). Do you want to mark it dead at the
> >beginning of sctp_assoc_rm_peer() as well? (We still need to
> >mark in sctp_transport_free() anyway).
>
> Crud.. sctp_transport_free() is called directly in places... Hmm...
> the one in sctp_association_free() may need to be list_del_rcu()...
It's not really needed but it wouldn't be wrong from a
documentation perspective. The assoc is always unhashed
while holding head->lock before sctp_association_free()
and all current RCU readers of transport_addr_list access
the the assoc while holding a read-lock on head->lock.
Let me respin this patch and do a list_del_rcu() there
to document the RCU'iness of it.
next prev parent reply other threads:[~2012-12-06 19:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 18:15 [PATCH] sctp: Add RCU protection to assoc->transport_addr_list Thomas Graf
2012-12-06 18:15 ` Thomas Graf
2012-12-06 18:35 ` Vlad Yasevich
2012-12-06 18:35 ` Vlad Yasevich
2012-12-06 18:44 ` Thomas Graf
2012-12-06 18:44 ` Thomas Graf
2012-12-06 18:57 ` Vlad Yasevich
2012-12-06 18:57 ` Vlad Yasevich
2012-12-06 19:08 ` Thomas Graf [this message]
2012-12-06 19:08 ` Thomas Graf
2012-12-06 19:14 ` Vlad Yasevich
2012-12-06 19:14 ` Vlad Yasevich
2012-12-06 19:28 ` Thomas Graf
2012-12-06 19:28 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206190835.GF16122@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.