From: Stephen Hemminger <shemminger@vyatta.com>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr,
davem@davemloft.net, shiyer@redhat.com
Subject: Re: [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info
Date: Fri, 7 Dec 2012 15:11:11 -0800 [thread overview]
Message-ID: <20121207151111.7d2f9150@samsung-9> (raw)
In-Reply-To: <1354899897-10423-2-git-send-email-jasowang@redhat.com>
Minor style issue reported by checkpatch which can be fixed after merge.
Although sizeof is actually an operator in C, it is considered correct
style to treat it as a function.
WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr)
#293: FILE: drivers/net/virtio_net.c:395:
+ sg_set_buf(rq->sg, &hdr->hdr, sizeof hdr->hdr);
WARNING: sizeof hdr->mhdr should be sizeof(hdr->mhdr)
#552: FILE: drivers/net/virtio_net.c:641:
+ sg_set_buf(sq->sg, &hdr->mhdr, sizeof hdr->mhdr);
WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr)
#555: FILE: drivers/net/virtio_net.c:643:
+ sg_set_buf(sq->sg, &hdr->hdr, sizeof hdr->hdr);
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, rusty@rustcorp.com.au, davem@davemloft.net,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
krkumar2@in.ibm.com, kvm@vger.kernel.org,
bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr,
shiyer@redhat.com
Subject: Re: [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info
Date: Fri, 7 Dec 2012 15:11:11 -0800 [thread overview]
Message-ID: <20121207151111.7d2f9150@samsung-9> (raw)
In-Reply-To: <1354899897-10423-2-git-send-email-jasowang@redhat.com>
Minor style issue reported by checkpatch which can be fixed after merge.
Although sizeof is actually an operator in C, it is considered correct
style to treat it as a function.
WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr)
#293: FILE: drivers/net/virtio_net.c:395:
+ sg_set_buf(rq->sg, &hdr->hdr, sizeof hdr->hdr);
WARNING: sizeof hdr->mhdr should be sizeof(hdr->mhdr)
#552: FILE: drivers/net/virtio_net.c:641:
+ sg_set_buf(sq->sg, &hdr->mhdr, sizeof hdr->mhdr);
WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr)
#555: FILE: drivers/net/virtio_net.c:643:
+ sg_set_buf(sq->sg, &hdr->hdr, sizeof hdr->hdr);
next prev parent reply other threads:[~2012-12-07 23:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 17:04 [PATCH net-next v3 0/3] Multiqueue support in virtio-net Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 17:04 ` [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 23:11 ` Stephen Hemminger [this message]
2012-12-07 23:11 ` Stephen Hemminger
2012-12-07 17:04 ` [PATCH net-next v3 2/3] virtio_net: multiqueue support Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 17:04 ` [PATCH net-next v3 3/3] virtio-net: support changing the number of queue pairs through ethtool Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 20:35 ` [PATCH net-next v3 0/3] Multiqueue support in virtio-net David Miller
2012-12-07 20:35 ` David Miller
2012-12-07 23:13 ` Stephen Hemminger
2012-12-07 23:13 ` Stephen Hemminger
2012-12-09 5:32 ` David Miller
2012-12-09 5:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207151111.7d2f9150@samsung-9 \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jwhan@filewood.snu.ac.kr \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shiyer@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.