All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Abhilash Kesavan <a.kesavan@samsung.com>
Cc: lrg@ti.com, linux-kernel@vger.kernel.org, dianders@chromium.org,
	olof@lixom.net, grant.likely@secretlab.ca,
	thomas.abraham@linaro.org, kgene.kim@samsung.com,
	sameo@linux.intel.com
Subject: Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes
Date: Mon, 10 Dec 2012 15:46:51 +0900	[thread overview]
Message-ID: <20121210064650.GJ10927@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1355120784-31118-3-git-send-email-a.kesavan@samsung.com>

On Mon, Dec 10, 2012 at 11:56:23AM +0530, Abhilash Kesavan wrote:

> +		if (of_property_read_u32(rdata[i].of_node, "max77686-opmode",
> +			&rdata[i].opmode)) {
> +			dev_warn(iodev->dev, "no op_mode property property at %s\n",
> +			rmatch.name);
> +			rdata[i].opmode = regulators[i].enable_mask;
> +		}

Binding documenation is mandatory for any new OF properties, please add
this.

  parent reply	other threads:[~2012-12-10  6:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10  6:26 [RFC PATCH 0/3] Add MAX77686 Operating mode support Abhilash Kesavan
2012-12-10  6:26 ` [RFC PATCH 1/3] ARM: DTS: CROS5250: Add regulator operating mode bindings Abhilash Kesavan
2012-12-10  6:26   ` [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Abhilash Kesavan
2012-12-10  6:26     ` [RFC PATCH 3/3] dt: Document: Add optional MAX77686 operating mode bindings Abhilash Kesavan
2012-12-10 18:30       ` Doug Anderson
2012-12-12  3:07         ` Mark Brown
2012-12-10  6:46     ` Mark Brown [this message]
2012-12-10  8:19       ` [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Abhilash Kesavan
     [not found]         ` <loom.20121210T091624-754-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2012-12-10  8:36           ` Abhilash Kesavan
2012-12-10  8:36             ` Abhilash Kesavan
2012-12-11 12:57             ` Mark Brown
     [not found]               ` <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-12  2:58                 ` Abhilash Kesavan
2012-12-12  2:58                   ` Abhilash Kesavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121210064650.GJ10927@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=a.kesavan@samsung.com \
    --cc=dianders@chromium.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=olof@lixom.net \
    --cc=sameo@linux.intel.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.