From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Abhilash Kesavan <kesavan.abhilash@gmail.com>
Cc: linux-kernel@vger.kernel.org, lrg@ti.com,
Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org, sameo@linux.intel.com
Subject: Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes
Date: Tue, 11 Dec 2012 21:57:14 +0900 [thread overview]
Message-ID: <20121211125713.GH9097@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAM4voanevLVXW5_WFts2cjDi-5aAbj1_2=EN1amfp14KnKXNug@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote:
> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan
> <kesavan.abhilash@gmail.com> wrote:
> > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes:
> >> Binding documenation is mandatory for any new OF properties, please add
> >> this.
> > Patch 3/3 of this series adds documentation for the max77686-opmode property.
There is no point in splitting changes like this up, it just makes
review harder - in this case it caused me to not read your patch due
to the missing documentation. Put the whole change together unless
things are getting too big to review.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-11 12:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 6:26 [RFC PATCH 0/3] Add MAX77686 Operating mode support Abhilash Kesavan
2012-12-10 6:26 ` [RFC PATCH 1/3] ARM: DTS: CROS5250: Add regulator operating mode bindings Abhilash Kesavan
2012-12-10 6:26 ` [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Abhilash Kesavan
2012-12-10 6:26 ` [RFC PATCH 3/3] dt: Document: Add optional MAX77686 operating mode bindings Abhilash Kesavan
2012-12-10 18:30 ` Doug Anderson
2012-12-12 3:07 ` Mark Brown
2012-12-10 6:46 ` [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Mark Brown
2012-12-10 8:19 ` Abhilash Kesavan
[not found] ` <loom.20121210T091624-754-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2012-12-10 8:36 ` Abhilash Kesavan
2012-12-10 8:36 ` Abhilash Kesavan
2012-12-11 12:57 ` Mark Brown [this message]
[not found] ` <20121211125713.GH9097-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-12 2:58 ` Abhilash Kesavan
2012-12-12 2:58 ` Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211125713.GH9097@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=grant.likely@secretlab.ca \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=olof@lixom.net \
--cc=sameo@linux.intel.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.