From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP
Date: Mon, 10 Dec 2012 21:47:55 +0000 [thread overview]
Message-ID: <20121210214755.9CD823E0C7C@localhost> (raw)
In-Reply-To: <20121210162819.46fe4f91@skate>
On Mon, 10 Dec 2012 16:28:19 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Dear Gregory CLEMENT,
>
> On Mon, 10 Dec 2012 11:42:01 +0100, Gregory CLEMENT wrote:
>
> > + rtc at 10300 {
> > + compatible = "marvell,orion-rtc";
> > + reg = <0xd0010300 0x20>;
> > + interrupts = <50>;
> > + };
>
> Maybe an explicit status = "okay" here?
Only necessary if it is typical for the device to get disabled. I don't
add status="okay" properties unless it is to enable a device previously
disabled with status="disabled"
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Ike Pan <ike.pan-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
David Marlin <dmarlin-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Yehuda Yitschak <yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Jani Monoses
<jani.monoses-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Dan Frazier
<dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Eran Ben-Avi <benavi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Leif Lindholm <leif.lindholm-5wv7dgnIgG8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
Jon Masters <jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Chris Van Hoof <vanhoof-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Maen Suleiman <maen-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Shadi Ammouri <shadi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP
Date: Mon, 10 Dec 2012 21:47:55 +0000 [thread overview]
Message-ID: <20121210214755.9CD823E0C7C@localhost> (raw)
In-Reply-To: <20121210162819.46fe4f91@skate>
On Mon, 10 Dec 2012 16:28:19 +0100, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Dear Gregory CLEMENT,
>
> On Mon, 10 Dec 2012 11:42:01 +0100, Gregory CLEMENT wrote:
>
> > + rtc@10300 {
> > + compatible = "marvell,orion-rtc";
> > + reg = <0xd0010300 0x20>;
> > + interrupts = <50>;
> > + };
>
> Maybe an explicit status = "okay" here?
Only necessary if it is typical for the device to get disabled. I don't
add status="okay" properties unless it is to enable a device previously
disabled with status="disabled"
g.
next prev parent reply other threads:[~2012-12-10 21:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 10:42 [PATCH 0/2] add RTC support for Armada 370 and Armada XP Gregory CLEMENT
2012-12-10 10:42 ` Gregory CLEMENT
2012-12-10 10:42 ` [PATCH 1/2] arm: mvebu: " Gregory CLEMENT
2012-12-10 10:42 ` Gregory CLEMENT
2012-12-10 15:28 ` Thomas Petazzoni
2012-12-10 15:28 ` Thomas Petazzoni
2012-12-10 21:47 ` Grant Likely [this message]
2012-12-10 21:47 ` Grant Likely
2012-12-10 22:37 ` Thomas Petazzoni
2012-12-10 22:37 ` Thomas Petazzoni
2012-12-11 6:00 ` Andrew Lunn
2012-12-11 6:00 ` Andrew Lunn
2012-12-11 8:18 ` Thomas Petazzoni
2012-12-11 8:18 ` Thomas Petazzoni
2012-12-10 10:42 ` [PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation Gregory CLEMENT
2012-12-10 10:42 ` Gregory CLEMENT
2012-12-10 13:39 ` Jason Cooper
2012-12-10 13:39 ` Jason Cooper
2012-12-10 21:49 ` Grant Likely
2012-12-10 21:49 ` Grant Likely
2012-12-10 10:59 ` [PATCH 0/2] add RTC support for Armada 370 and Armada XP Andrew Lunn
2012-12-10 10:59 ` Andrew Lunn
2012-12-10 14:01 ` Thomas Petazzoni
2012-12-10 14:01 ` Thomas Petazzoni
2012-12-10 14:17 ` Gregory CLEMENT
2012-12-10 14:17 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210214755.9CD823E0C7C@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.