All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings
Date: Mon, 10 Dec 2012 22:37:22 +0000	[thread overview]
Message-ID: <20121210223722.461773E08FB@localhost> (raw)
In-Reply-To: <50C1F783.6090501@ti.com>

On Fri, 7 Dec 2012 15:04:51 +0100, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 12/07/2012 02:34 PM, Grant Likely wrote:
> > It really needs to look like this:
> > 
> > pwmleds {
> > 	compatible = "pwm-leds";
> > 	kpad {
> > 		label = "omap4::keypad";
> > 		max-brightness = <127>;
> > 		pwms = <&twl_pwm 0 7812500>;
> > 	};
> > 	charging {
> > 		label = "omap4:green:chrg";
> > 		max-brightness = <255>;
> > 		pwms = <&twl_pwmled 0 7812500>;
> > 	};
> > };
> 
> OK.
> So What we need to do is export the of_pwm_request() from drivers/pwm/core.c
> Client drivers us of_pwm_request(node, NULL); to get the pwm when booted with DT.
> Works fine on my setup this way and the DTS section looks just as you have
> described.
> Now I need to clean them up and resubmit.

Cool, thanks.

g.

      reply	other threads:[~2012-12-10 22:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 14:41 [PATCH v2 0/3] leds: leds-pwm: Device tree support Peter Ujfalusi
2012-11-12 14:41 ` Peter Ujfalusi
     [not found] ` <1352731270-27534-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2012-11-12 14:41   ` [PATCH v2 1/3] leds: leds-pwm: Convert to use devm_get_pwm Peter Ujfalusi
2012-11-12 14:41     ` Peter Ujfalusi
2012-11-14  1:14     ` Bryan Wu
     [not found]       ` <CAK5ve-JDCSSOKHQG-F1RoDii62=-DiPevaD6SafndYVvOgB6Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-14  7:13         ` Peter Ujfalusi
2012-11-14  7:13           ` Peter Ujfalusi
2012-12-03 14:13       ` Peter Ujfalusi
2012-12-03 14:13         ` Peter Ujfalusi
2012-12-03 18:32         ` Bryan Wu
     [not found]           ` <CAK5ve-+1eQ3mPLAu2Qxw4LjNA85oEtJE-wZcL=YpQ0xBFJ6+hQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-04  8:11             ` Peter Ujfalusi
2012-12-04  8:11               ` Peter Ujfalusi
2012-12-04 17:34               ` Bryan Wu
2012-12-05 15:36                 ` Peter Ujfalusi
2012-12-05 15:36                   ` Peter Ujfalusi
2012-11-12 14:41   ` [PATCH v2 2/3] leds: leds-pwm: Preparing the driver for device tree support Peter Ujfalusi
2012-11-12 14:41     ` Peter Ujfalusi
2012-11-12 14:41 ` [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings Peter Ujfalusi
2012-11-12 14:41   ` Peter Ujfalusi
     [not found]   ` <1352731270-27534-4-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2012-12-06 10:00     ` Grant Likely
2012-12-06 10:00       ` Grant Likely
2012-12-06 12:36       ` Peter Ujfalusi
2012-12-06 12:36         ` Peter Ujfalusi
     [not found]         ` <50C0913B.9070802-l0cyMroinI0@public.gmane.org>
2012-12-07 13:34           ` Grant Likely
2012-12-07 13:34             ` Grant Likely
2012-12-07 14:04             ` Peter Ujfalusi
2012-12-07 14:04               ` Peter Ujfalusi
2012-12-10 22:37               ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121210223722.461773E08FB@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=cooloney@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=rpurdie@rpsys.net \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.