All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>, Andi Kleen <andi@firstfloor.org>,
	Simon Jeons <simon.jeons@gmail.com>,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	WuJianguo <wujianguo@huawei.com>, Liujiang <jiang.liu@huawei.com>,
	Vyacheslav.Dubeyko@huawei.com, Borislav Petkov <bp@alien8.de>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	wency@cn.fujitsu.com, Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics
Date: Tue, 11 Dec 2012 03:58:57 +0100	[thread overview]
Message-ID: <20121211025857.GX16230@one.firstfloor.org> (raw)
In-Reply-To: <20121211024522.GA10505@localhost>

> That sounds like overkill. There are not so many free pages in a
> typical server system.

As Fengguang said -- memory error handling is tricky. Lots of things
could be done in theory, but they all have a cost in testing and 
maintenance. 

In general they are only worth doing if the situation is common and
represents a significant percentage of the total pages of a relevant server
workload.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>, Andi Kleen <andi@firstfloor.org>,
	Simon Jeons <simon.jeons@gmail.com>,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	WuJianguo <wujianguo@huawei.com>, Liujiang <jiang.liu@huawei.com>,
	Vyacheslav.Dubeyko@huawei.com, Borislav Petkov <bp@alien8.de>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	wency@cn.fujitsu.com, Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics
Date: Tue, 11 Dec 2012 03:58:57 +0100	[thread overview]
Message-ID: <20121211025857.GX16230@one.firstfloor.org> (raw)
In-Reply-To: <20121211024522.GA10505@localhost>

> That sounds like overkill. There are not so many free pages in a
> typical server system.

As Fengguang said -- memory error handling is tricky. Lots of things
could be done in theory, but they all have a cost in testing and 
maintenance. 

In general they are only worth doing if the situation is common and
represents a significant percentage of the total pages of a relevant server
workload.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2012-12-11  2:58 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07  8:48 [PATCH V2] MCE: fix an error of mce_bad_pages statistics Xishi Qiu
2012-12-07  8:48 ` Xishi Qiu
2012-12-07 14:33 ` Borislav Petkov
2012-12-07 14:33   ` Borislav Petkov
2012-12-07 22:11 ` Andrew Morton
2012-12-07 22:11   ` Andrew Morton
2012-12-07 22:41   ` Borislav Petkov
2012-12-07 22:41     ` Borislav Petkov
2012-12-10  4:33   ` Xishi Qiu
2012-12-10  4:33     ` Xishi Qiu
2012-12-10  8:33   ` Wanpeng Li
2012-12-10  9:06     ` Xishi Qiu
2012-12-10  9:06       ` Xishi Qiu
2012-12-10 10:47       ` Simon Jeons
2012-12-10 10:47         ` Simon Jeons
2012-12-10 11:16         ` Xishi Qiu
2012-12-10 11:16           ` Xishi Qiu
2012-12-10 11:39           ` Wanpeng Li
2012-12-10 11:39           ` Wanpeng Li
2012-12-10 11:54             ` Xishi Qiu
2012-12-10 11:54               ` Xishi Qiu
2012-12-10 12:11               ` Borislav Petkov
2012-12-10 12:11                 ` Borislav Petkov
2012-12-10 15:39             ` Andi Kleen
2012-12-10 15:39               ` Andi Kleen
2012-12-10 11:58           ` Simon Jeons
2012-12-10 11:58             ` Simon Jeons
     [not found]           ` <1355140561.1821.5.camel@kernel.cn.ibm.com>
     [not found]             ` <50C5D844.8050707@huawei.com>
2012-12-10 12:47               ` Simon Jeons
2012-12-10 12:47                 ` Simon Jeons
2012-12-11  1:16                 ` Wanpeng Li
2012-12-11  6:49                   ` Xishi Qiu
2012-12-11  6:49                     ` Xishi Qiu
2012-12-11  8:02                     ` Wanpeng Li
2012-12-11  8:02                     ` Wanpeng Li
2012-12-11  1:16                 ` Wanpeng Li
2012-12-10 15:38           ` Andi Kleen
2012-12-10 15:38             ` Andi Kleen
2012-12-11  1:49             ` Simon Jeons
2012-12-11  1:49               ` Simon Jeons
2012-12-11  2:03               ` Andi Kleen
2012-12-11  2:03                 ` Andi Kleen
2012-12-11  2:14                 ` Simon Jeons
2012-12-11  2:14                   ` Simon Jeons
2012-12-11  3:01                   ` Andi Kleen
2012-12-11  3:01                     ` Andi Kleen
2012-12-11  3:13                     ` Simon Jeons
2012-12-11  3:13                       ` Simon Jeons
2012-12-11  3:19                       ` Andi Kleen
2012-12-11  3:19                         ` Andi Kleen
2012-12-11  3:48                         ` Simon Jeons
2012-12-11  3:48                           ` Simon Jeons
2012-12-11  5:55                           ` Xishi Qiu
2012-12-11  5:55                             ` Xishi Qiu
2012-12-11  6:34                             ` Wanpeng Li
2012-12-11  6:34                             ` Wanpeng Li
2012-12-11  2:25             ` Xishi Qiu
2012-12-11  2:25               ` Xishi Qiu
2012-12-11  2:45               ` Fengguang Wu
2012-12-11  2:45                 ` Fengguang Wu
2012-12-11  2:58                 ` Andi Kleen [this message]
2012-12-11  2:58                   ` Andi Kleen
2012-12-11  3:25                   ` Xishi Qiu
2012-12-11  3:25                     ` Xishi Qiu
2012-12-11  3:36                     ` Andi Kleen
2012-12-11  3:36                       ` Andi Kleen
2012-12-10  8:33   ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211025857.GX16230@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=Vyacheslav.Dubeyko@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=fengguang.wu@intel.com \
    --cc=guohanjun@huawei.com \
    --cc=jiang.liu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwanp@linux.vnet.ibm.com \
    --cc=qiuxishi@huawei.com \
    --cc=simon.jeons@gmail.com \
    --cc=wency@cn.fujitsu.com \
    --cc=wujianguo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.