Re: [RFC v2 2/5] video: Add generic HDMI infoframe helpers

[Thierry Reding <thierry.reding@avionic-design.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1289 bytes --]

On Fri, Dec 07, 2012 at 12:32:42PM -0200, Paulo Zanoni wrote:
> 2012/12/5 Thierry Reding <thierry.reding@avionic-design.de>:
[...]
> > +ssize_t hdmi_spd_infoframe_pack(struct hdmi_spd_infoframe *frame, void *buffer,
> > +                               size_t size)
> > +{
> > +       u8 *ptr = buffer;
> > +       size_t length, i;
> > +
> > +       if (!frame || !buffer)
> > +               return -EINVAL;
> > +
> > +       length = 4 + frame->length;
> > +
> > +       if (size < length)
> > +               return -ENOSPC;
> > +
> > +       memset(buffer, 0, length);
> > +
> > +       ptr[0] = frame->type;
> > +       ptr[1] = frame->version;
> > +       ptr[2] = frame->length;
> > +       ptr[3] = 0; /* checksum */
> > +
> > +       for (i = 0; i < sizeof(frame->vendor); i++)
> > +               ptr[4 + i] = frame->vendor[i];
> > +
> > +       for (i = 0; i < sizeof(frame->product); i++)
> > +               ptr[12 + i] = frame->product[i];
> > +
> > +       ptr[26] = frame->sdi;
> 
> Shouldn't this be ptr[28] ?

Yes, you're absolutely right.

By the way, I had to scroll through your reply several times before I
found this single line. If you remove unneeded context when replying
your comments are much easier to locate.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel