From: Andi Kleen <andi@firstfloor.org>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: WuJianguo <wujianguo@huawei.com>, Liujiang <jiang.liu@huawei.com>,
Simon Jeons <simon.jeons@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, Andi Kleen <andi@firstfloor.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/3] MCE: fix an error of mce_bad_pages statistics
Date: Wed, 12 Dec 2012 05:23:16 +0100 [thread overview]
Message-ID: <20121212042316.GC16230@one.firstfloor.org> (raw)
In-Reply-To: <50C7FB82.7050802@huawei.com>
> if (PageHWPoison(hpage)) {
> pr_info("soft offline: %#lx hugepage already poisoned\n", pfn);
> - return -EBUSY;
> + ret = -EBUSY;
> + goto out;
Doesn't look like a code improvement to me. Single return is easier and
simpler.
-Andi
> +out:
> return ret;
> }
> --
> 1.7.1
>
>
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: WuJianguo <wujianguo@huawei.com>, Liujiang <jiang.liu@huawei.com>,
Simon Jeons <simon.jeons@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, Andi Kleen <andi@firstfloor.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/3] MCE: fix an error of mce_bad_pages statistics
Date: Wed, 12 Dec 2012 05:23:16 +0100 [thread overview]
Message-ID: <20121212042316.GC16230@one.firstfloor.org> (raw)
In-Reply-To: <50C7FB82.7050802@huawei.com>
> if (PageHWPoison(hpage)) {
> pr_info("soft offline: %#lx hugepage already poisoned\n", pfn);
> - return -EBUSY;
> + ret = -EBUSY;
> + goto out;
Doesn't look like a code improvement to me. Single return is easier and
simpler.
-Andi
> +out:
> return ret;
> }
> --
> 1.7.1
>
>
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-12-12 4:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 3:35 [PATCH V4 2/3] MCE: fix an error of mce_bad_pages statistics Xishi Qiu
2012-12-12 3:35 ` Xishi Qiu
2012-12-12 4:23 ` Andi Kleen [this message]
2012-12-12 4:23 ` Andi Kleen
2012-12-14 2:14 ` [PATCH V4 2/3 RESEND] MCE: do code refactor of soft_offline_page Xishi Qiu
2012-12-14 2:14 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212042316.GC16230@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=fengguang.wu@intel.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=qiuxishi@huawei.com \
--cc=simon.jeons@gmail.com \
--cc=wujianguo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.