From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm_ functions
Date: Thu, 13 Dec 2012 11:20:29 +0000 [thread overview]
Message-ID: <20121213112029.GY6568@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.02.1212131118220.1966@hadrien>
On Thu, Dec 13, 2012 at 11:18:53AM +0100, Julia Lawall wrote:
> On Thu, 13 Dec 2012, Dan Carpenter wrote:
>
> > On Wed, Dec 12, 2012 at 01:25:56AM +0400, Evgeniy Polyakov wrote:
> > > I suppose mdev will be automatically freed, but who will release
> > > mdev->clk and other private members of mdev structure?
> >
> > + mdev->clk = devm_clk_get(&pdev->dev, NULL);
> >
> > ->clk is now a devm pointer as well.
>
> Thanks for the suggestion. I will submit a patch shortly.
>
Huh? I think there is a miscommunication here. I was trying to
explain that your original patch handles releasing ->clk.
I've reviewed the patch again and I still don't see a problem with
it. What will you change when you resubmit?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm_ functions
Date: Thu, 13 Dec 2012 14:20:29 +0300 [thread overview]
Message-ID: <20121213112029.GY6568@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.02.1212131118220.1966@hadrien>
On Thu, Dec 13, 2012 at 11:18:53AM +0100, Julia Lawall wrote:
> On Thu, 13 Dec 2012, Dan Carpenter wrote:
>
> > On Wed, Dec 12, 2012 at 01:25:56AM +0400, Evgeniy Polyakov wrote:
> > > I suppose mdev will be automatically freed, but who will release
> > > mdev->clk and other private members of mdev structure?
> >
> > + mdev->clk = devm_clk_get(&pdev->dev, NULL);
> >
> > ->clk is now a devm pointer as well.
>
> Thanks for the suggestion. I will submit a patch shortly.
>
Huh? I think there is a miscommunication here. I was trying to
explain that your original patch handles releasing ->clk.
I've reviewed the patch again and I still don't see a problem with
it. What will you change when you resubmit?
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-13 11:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 22:15 [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm_ functions Julia Lawall
2012-12-06 23:15 ` Julia Lawall
2012-12-11 21:25 ` Evgeniy Polyakov
2012-12-11 21:25 ` Evgeniy Polyakov
2012-12-13 9:39 ` Dan Carpenter
2012-12-13 9:39 ` Dan Carpenter
2012-12-13 10:18 ` Julia Lawall
2012-12-13 10:18 ` Julia Lawall
2012-12-13 11:20 ` Dan Carpenter [this message]
2012-12-13 11:20 ` Dan Carpenter
2012-12-13 11:23 ` Julia Lawall
2012-12-13 11:23 ` Julia Lawall
2012-12-13 18:27 ` Evgeniy Polyakov
2012-12-13 18:27 ` Evgeniy Polyakov
2012-12-13 18:28 ` Evgeniy Polyakov
2012-12-13 18:28 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213112029.GY6568@mwanda \
--to=dan.carpenter@oracle.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.