From: Tony Lindgren <tony@atomide.com>
To: Igor Mazanov <i.mazanov@gmail.com>
Cc: "AnilKumar, Chimata" <anilkumar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] OMAP2+: enable TPS65217 support in omap2plus_defconfig
Date: Fri, 14 Dec 2012 09:32:18 -0800 [thread overview]
Message-ID: <20121214173218.GU4989@atomide.com> (raw)
In-Reply-To: <CAK0ocyD+N7t5Tm38p3Qt6fNSUEHuL-=_Pw7twDVPbDJ81K3-Xg@mail.gmail.com>
* Igor Mazanov <i.mazanov@gmail.com> [121120 09:12]:
> On Tue, Nov 20, 2012 at 2:15 PM, AnilKumar, Chimata <anilkumar@ti.com> wrote:
> > On Mon, Nov 19, 2012 at 17:15:25, Igor Mazanov wrote:
> >> TPS65217 is described in arch/arm/boot/dts/am335x-bone.dts
> >> but doesn't enabled in arch/arm/configs/omap2plus_defconfig.
> >>
> >> Enable TPS65217 support in omap2plus_defconfig.
> >>
> >> Signed-off-by: Igor Mazanov <i.mazanov@gmail.com>
> >> ---
> >> arch/arm/configs/omap2plus_defconfig | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/configs/omap2plus_defconfig
> >> b/arch/arm/configs/omap2plus_defconfig
> >> index 6230304..00f2ce3 100644
> >> --- a/arch/arm/configs/omap2plus_defconfig
> >> +++ b/arch/arm/configs/omap2plus_defconfig
> >> @@ -240,3 +240,6 @@ CONFIG_CRC_ITU_T=y
> >> CONFIG_CRC7=y
> >> CONFIG_LIBCRC32C=y
> >> CONFIG_SOC_OMAP5=y
> >> +CONFIG_MFD_CORE=y
> >> +CONFIG_MFD_TPS65217=y
> >> +CONFIG_REGULATOR_TPS65217=y
> >
> > Hi Igor,
> >
> > Can you try this, MFD_CORE is selected by default and note that
> > remaining flags should be added at appropriate places.
> >
> > Author: AnilKumar Ch <anilkumar@ti.com>
> > Date: Tue Nov 20 15:34:51 2012 +0530
> >
> > Custom: ARM: OMAP2+: omap2plus_defconfig: Add tps65217 support
> >
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> >
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 6230304..69ddbf7 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -132,9 +132,11 @@ CONFIG_POWER_SUPPLY=y
> > CONFIG_WATCHDOG=y
> > CONFIG_OMAP_WATCHDOG=y
> > CONFIG_TWL4030_WATCHDOG=y
> > +CONFIG_MFD_TPS65217=y
> > CONFIG_REGULATOR_TWL4030=y
> > CONFIG_REGULATOR_TPS65023=y
> > CONFIG_REGULATOR_TPS6507X=y
> > +CONFIG_REGULATOR_TPS65217=y
> > CONFIG_FB=y
> > CONFIG_FIRMWARE_EDID=y
> > CONFIG_FB_MODE_HELPERS=y
> >
>
> OK, I made changes as you say and it works. Thanks for a tip about
> default selection of CONFIG_MFD.
Thanks applying into omap-for-v3.8/fixes-for-merge-window.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP2+: enable TPS65217 support in omap2plus_defconfig
Date: Fri, 14 Dec 2012 09:32:18 -0800 [thread overview]
Message-ID: <20121214173218.GU4989@atomide.com> (raw)
In-Reply-To: <CAK0ocyD+N7t5Tm38p3Qt6fNSUEHuL-=_Pw7twDVPbDJ81K3-Xg@mail.gmail.com>
* Igor Mazanov <i.mazanov@gmail.com> [121120 09:12]:
> On Tue, Nov 20, 2012 at 2:15 PM, AnilKumar, Chimata <anilkumar@ti.com> wrote:
> > On Mon, Nov 19, 2012 at 17:15:25, Igor Mazanov wrote:
> >> TPS65217 is described in arch/arm/boot/dts/am335x-bone.dts
> >> but doesn't enabled in arch/arm/configs/omap2plus_defconfig.
> >>
> >> Enable TPS65217 support in omap2plus_defconfig.
> >>
> >> Signed-off-by: Igor Mazanov <i.mazanov@gmail.com>
> >> ---
> >> arch/arm/configs/omap2plus_defconfig | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/configs/omap2plus_defconfig
> >> b/arch/arm/configs/omap2plus_defconfig
> >> index 6230304..00f2ce3 100644
> >> --- a/arch/arm/configs/omap2plus_defconfig
> >> +++ b/arch/arm/configs/omap2plus_defconfig
> >> @@ -240,3 +240,6 @@ CONFIG_CRC_ITU_T=y
> >> CONFIG_CRC7=y
> >> CONFIG_LIBCRC32C=y
> >> CONFIG_SOC_OMAP5=y
> >> +CONFIG_MFD_CORE=y
> >> +CONFIG_MFD_TPS65217=y
> >> +CONFIG_REGULATOR_TPS65217=y
> >
> > Hi Igor,
> >
> > Can you try this, MFD_CORE is selected by default and note that
> > remaining flags should be added at appropriate places.
> >
> > Author: AnilKumar Ch <anilkumar@ti.com>
> > Date: Tue Nov 20 15:34:51 2012 +0530
> >
> > Custom: ARM: OMAP2+: omap2plus_defconfig: Add tps65217 support
> >
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> >
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 6230304..69ddbf7 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -132,9 +132,11 @@ CONFIG_POWER_SUPPLY=y
> > CONFIG_WATCHDOG=y
> > CONFIG_OMAP_WATCHDOG=y
> > CONFIG_TWL4030_WATCHDOG=y
> > +CONFIG_MFD_TPS65217=y
> > CONFIG_REGULATOR_TWL4030=y
> > CONFIG_REGULATOR_TPS65023=y
> > CONFIG_REGULATOR_TPS6507X=y
> > +CONFIG_REGULATOR_TPS65217=y
> > CONFIG_FB=y
> > CONFIG_FIRMWARE_EDID=y
> > CONFIG_FB_MODE_HELPERS=y
> >
>
> OK, I made changes as you say and it works. Thanks for a tip about
> default selection of CONFIG_MFD.
Thanks applying into omap-for-v3.8/fixes-for-merge-window.
Regards,
Tony
next prev parent reply other threads:[~2012-12-14 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 11:45 [PATCH] OMAP2+: enable TPS65217 support in omap2plus_defconfig Igor Mazanov
2012-11-19 11:45 ` Igor Mazanov
2012-11-20 10:15 ` AnilKumar, Chimata
2012-11-20 10:15 ` AnilKumar, Chimata
2012-11-20 17:10 ` Igor Mazanov
2012-11-20 17:10 ` Igor Mazanov
2012-12-14 17:32 ` Tony Lindgren [this message]
2012-12-14 17:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214173218.GU4989@atomide.com \
--to=tony@atomide.com \
--cc=anilkumar@ti.com \
--cc=i.mazanov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.