From: Grant Likely <grant.likely@secretlab.ca>
To: Jon Hunter <jon-hunter@ti.com>, Daniel Mack <zonque@gmail.com>
Cc: paul@pwsan.com, x0148406@ti.com,
devicetree-discuss@lists.ozlabs.org, nsekhar@ti.com,
rob.herring@calxeda.com, tony@atomide.com, jacmet@sunsite.dk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
Date: Sat, 15 Dec 2012 00:37:52 +0000 [thread overview]
Message-ID: <20121215003752.D0BE63E0BEF@localhost> (raw)
In-Reply-To: <50C90CF2.1090405@ti.com>
On Wed, 12 Dec 2012 17:02:10 -0600, Jon Hunter <jon-hunter@ti.com> wrote:
>
> So looking at this today, here is what I see when comparing the
> registers ...
>
> omap2430 != omap2420
> omap3430 != omap2430
> omap3630 == omap3430
> omap4430 != omap3430
> omap4460 == omap4430
> omap543x == omap4430
> am335x != omap4430
>
> Therefore, I believe that we need to have the following compatible
> strings ...
>
> ti,omap2420-gpmc
> ti,omap2430-gpmc
> ti,omap3430-gpmc (omap3430 & omap3630)
> ti,omap4430-gpmc (omap4430 & omap4460 & omap543x)
> ti,am3352-gpmc (am335x devices)
>
> Probably worth adding a comment to the Documentation what should be used
> for which device.
Yes, it is completely appropriate to add a comment to the documentation
here so this doesn't get lost.
g.
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
Date: Sat, 15 Dec 2012 00:37:52 +0000 [thread overview]
Message-ID: <20121215003752.D0BE63E0BEF@localhost> (raw)
In-Reply-To: <50C90CF2.1090405@ti.com>
On Wed, 12 Dec 2012 17:02:10 -0600, Jon Hunter <jon-hunter@ti.com> wrote:
>
> So looking at this today, here is what I see when comparing the
> registers ...
>
> omap2430 != omap2420
> omap3430 != omap2430
> omap3630 == omap3430
> omap4430 != omap3430
> omap4460 == omap4430
> omap543x == omap4430
> am335x != omap4430
>
> Therefore, I believe that we need to have the following compatible
> strings ...
>
> ti,omap2420-gpmc
> ti,omap2430-gpmc
> ti,omap3430-gpmc (omap3430 & omap3630)
> ti,omap4430-gpmc (omap4430 & omap4460 & omap543x)
> ti,am3352-gpmc (am335x devices)
>
> Probably worth adding a comment to the Documentation what should be used
> for which device.
Yes, it is completely appropriate to add a comment to the documentation
here so this doesn't get lost.
g.
next prev parent reply other threads:[~2012-12-15 0:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 19:09 [PATCH v7 0/5] OMAP GPMC DT bindings Daniel Mack
2012-12-05 19:09 ` Daniel Mack
2012-12-05 19:09 ` [PATCH v7 1/5] ARM: OMAP: gpmc: don't create devices from initcall on DT Daniel Mack
2012-12-05 19:09 ` Daniel Mack
2012-12-05 19:09 ` [PATCH v7 2/5] mtd: omap-nand: pass device_node in platform data Daniel Mack
2012-12-05 19:09 ` Daniel Mack
2012-12-05 19:09 ` [PATCH v7 3/5] ARM: OMAP: gpmc-nand: drop __init annotation Daniel Mack
2012-12-05 19:09 ` Daniel Mack
2012-12-05 19:09 ` [PATCH v7 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs Daniel Mack
2012-12-05 19:09 ` Daniel Mack
2012-12-05 19:09 ` [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Daniel Mack
2012-12-05 19:09 ` Daniel Mack
2012-12-05 22:22 ` Grant Likely
2012-12-05 22:22 ` Grant Likely
2012-12-05 22:33 ` Jon Hunter
2012-12-05 22:33 ` Jon Hunter
2012-12-05 23:24 ` Grant Likely
2012-12-05 23:24 ` Grant Likely
2012-12-06 0:03 ` Tony Lindgren
2012-12-06 0:03 ` Tony Lindgren
[not found] ` <20121206000302.GM21682-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-12-06 16:22 ` Jon Hunter
2012-12-06 16:22 ` Jon Hunter
[not found] ` <50C0C646.9000802-l0cyMroinI0@public.gmane.org>
2012-12-06 16:54 ` Daniel Mack
2012-12-06 16:54 ` Daniel Mack
[not found] ` <50C0CDB0.5050008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-06 18:11 ` Jon Hunter
2012-12-06 18:11 ` Jon Hunter
2012-12-06 16:19 ` Jon Hunter
2012-12-06 16:19 ` Jon Hunter
[not found] ` <50C0C5AB.3030201-l0cyMroinI0@public.gmane.org>
2012-12-06 16:59 ` Daniel Mack
2012-12-06 16:59 ` Daniel Mack
2012-12-12 9:13 ` Daniel Mack
2012-12-12 9:13 ` Daniel Mack
[not found] ` <50C84AC6.5030307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-12 23:02 ` Jon Hunter
2012-12-12 23:02 ` Jon Hunter
2012-12-15 0:37 ` Grant Likely [this message]
2012-12-15 0:37 ` Grant Likely
[not found] ` <1354734571-10774-1-git-send-email-zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-05 19:22 ` [PATCH v7 0/5] OMAP GPMC DT bindings Jon Hunter
2012-12-05 19:22 ` Jon Hunter
2012-12-05 19:24 ` Daniel Mack
2012-12-05 19:24 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121215003752.D0BE63E0BEF@localhost \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jacmet@sunsite.dk \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
--cc=x0148406@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.