All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Russell King <linux@arm.linux.org.uk>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: OMAP2+: common: remove use of vram
Date: Sun, 16 Dec 2012 09:48:25 -0800	[thread overview]
Message-ID: <20121216174824.GB18490@atomide.com> (raw)
In-Reply-To: <1355626132-32117-1-git-send-email-javier.martinez@collabora.co.uk>

* Javier Martinez Canillas <javier.martinez@collabora.co.uk> [121215 18:52]:
> commit 966458f OMAP: remove vram allocator
> 
> Removed the OMAP specific vram allocator but OMAP2 common was
> still trying to use it and this lead to the following build error:
> 
> CC      arch/arm/mach-omap2/common.o
> arch/arm/mach-omap2/common.c:19:23: fatal error: plat/vram.h: No such file or directory
> compilation terminated.
> make[1]: *** [arch/arm/mach-omap2/common.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2

OK looks like this got missed in the merge notes from Tomi, will
apply.

Thanks,

Ton
 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/mach-omap2/common.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/common.c b/arch/arm/mach-omap2/common.c
> index 5c2fd48..2dabb9e 100644
> --- a/arch/arm/mach-omap2/common.c
> +++ b/arch/arm/mach-omap2/common.c
> @@ -16,8 +16,6 @@
>  #include <linux/init.h>
>  #include <linux/platform_data/dsp-omap.h>
>  
> -#include <plat/vram.h>
> -
>  #include "common.h"
>  #include "omap-secure.h"
>  
> @@ -32,7 +30,6 @@ int __weak omap_secure_ram_reserve_memblock(void)
>  
>  void __init omap_reserve(void)
>  {
> -	omap_vram_reserve_sdram_memblock();
>  	omap_dsp_reserve_sdram_memblock();
>  	omap_secure_ram_reserve_memblock();
>  	omap_barrier_reserve_memblock();
> -- 
> 1.7.7.6
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: OMAP2+: common: remove use of vram
Date: Sun, 16 Dec 2012 09:48:25 -0800	[thread overview]
Message-ID: <20121216174824.GB18490@atomide.com> (raw)
In-Reply-To: <1355626132-32117-1-git-send-email-javier.martinez@collabora.co.uk>

* Javier Martinez Canillas <javier.martinez@collabora.co.uk> [121215 18:52]:
> commit 966458f OMAP: remove vram allocator
> 
> Removed the OMAP specific vram allocator but OMAP2 common was
> still trying to use it and this lead to the following build error:
> 
> CC      arch/arm/mach-omap2/common.o
> arch/arm/mach-omap2/common.c:19:23: fatal error: plat/vram.h: No such file or directory
> compilation terminated.
> make[1]: *** [arch/arm/mach-omap2/common.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2

OK looks like this got missed in the merge notes from Tomi, will
apply.

Thanks,

Ton
 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/mach-omap2/common.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/common.c b/arch/arm/mach-omap2/common.c
> index 5c2fd48..2dabb9e 100644
> --- a/arch/arm/mach-omap2/common.c
> +++ b/arch/arm/mach-omap2/common.c
> @@ -16,8 +16,6 @@
>  #include <linux/init.h>
>  #include <linux/platform_data/dsp-omap.h>
>  
> -#include <plat/vram.h>
> -
>  #include "common.h"
>  #include "omap-secure.h"
>  
> @@ -32,7 +30,6 @@ int __weak omap_secure_ram_reserve_memblock(void)
>  
>  void __init omap_reserve(void)
>  {
> -	omap_vram_reserve_sdram_memblock();
>  	omap_dsp_reserve_sdram_memblock();
>  	omap_secure_ram_reserve_memblock();
>  	omap_barrier_reserve_memblock();
> -- 
> 1.7.7.6
> 

  reply	other threads:[~2012-12-16 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-16  2:48 [PATCH 1/1] ARM: OMAP2+: common: remove use of vram Javier Martinez Canillas
2012-12-16  2:48 ` Javier Martinez Canillas
2012-12-16 17:48 ` Tony Lindgren [this message]
2012-12-16 17:48   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121216174824.GB18490@atomide.com \
    --to=tony@atomide.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.