From: Grant Likely <grant.likely@secretlab.ca>
Cc: Felipe Balbi <balbi@ti.com>,
spi-devel-general@lists.sourceforge.net, rob@landley.net,
rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] spi: devicetree: add support for loopback mode
Date: Sun, 16 Dec 2012 21:14:14 +0000 [thread overview]
Message-ID: <20121216211415.0DE793E0BDD@localhost> (raw)
In-Reply-To: <20121215145546.GA15606@arwen.pp.htv.fi>
On Sat, 15 Dec 2012 16:55:46 +0200, Felipe Balbi <balbi@ti.com> wrote:
> On Sat, Dec 15, 2012 at 12:32:24AM +0000, Grant Likely wrote:
> > On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi <balbi@ti.com> wrote:
> > > there are a few spi master drivers which make
> > > use of that flag but there is no way to pass it
> > > through devicetree.
> > >
> > > This patch just creates a way to pass SPI_LOOP
> > > via devicetree.
> >
> > I don't understand how this would be useful since loopback mode is
> > really just a test feature. Is there any reason to do loopback for
> > something other than test?
> >
> > I think it would be better to add a sysfs or debugfs property to
> > manipulate the SPI_LOOP flag from userspace. What do you think?
>
> might be nicer in the long run, indeed. Want me to look into it, or do
> you wanna do it yourself ?
Yes, please look into it. After all, you're the one who needs the feature/ :-)
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Felipe Balbi <balbi@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
spi-devel-general@lists.sourceforge.net, rob@landley.net,
rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] spi: devicetree: add support for loopback mode
Date: Sun, 16 Dec 2012 21:14:14 +0000 [thread overview]
Message-ID: <20121216211415.0DE793E0BDD@localhost> (raw)
In-Reply-To: <20121215145546.GA15606@arwen.pp.htv.fi>
On Sat, 15 Dec 2012 16:55:46 +0200, Felipe Balbi <balbi@ti.com> wrote:
> On Sat, Dec 15, 2012 at 12:32:24AM +0000, Grant Likely wrote:
> > On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi <balbi@ti.com> wrote:
> > > there are a few spi master drivers which make
> > > use of that flag but there is no way to pass it
> > > through devicetree.
> > >
> > > This patch just creates a way to pass SPI_LOOP
> > > via devicetree.
> >
> > I don't understand how this would be useful since loopback mode is
> > really just a test feature. Is there any reason to do loopback for
> > something other than test?
> >
> > I think it would be better to add a sysfs or debugfs property to
> > manipulate the SPI_LOOP flag from userspace. What do you think?
>
> might be nicer in the long run, indeed. Want me to look into it, or do
> you wanna do it yourself ?
Yes, please look into it. After all, you're the one who needs the feature/ :-)
g.
next prev parent reply other threads:[~2012-12-16 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 8:45 [PATCH 1/2] spi: omap2: disable DMA requests before complete() Felipe Balbi
2012-12-12 8:45 ` Felipe Balbi
2012-12-12 8:45 ` Felipe Balbi
[not found] ` <1355301960-21523-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-12-12 8:46 ` [PATCH 2/2] spi: devicetree: add support for loopback mode Felipe Balbi
2012-12-12 8:46 ` Felipe Balbi
2012-12-12 8:46 ` Felipe Balbi
2012-12-15 0:32 ` Grant Likely
2012-12-15 0:32 ` Grant Likely
2012-12-15 14:55 ` Felipe Balbi
2012-12-15 14:55 ` Felipe Balbi
2012-12-16 21:14 ` Grant Likely [this message]
2012-12-16 21:14 ` Grant Likely
2012-12-15 0:35 ` [PATCH 1/2] spi: omap2: disable DMA requests before complete() Grant Likely
2012-12-15 0:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121216211415.0DE793E0BDD@localhost \
--to=grant.likely@secretlab.ca \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.