All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>,
	linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, spear-devel@list.st.com,
	viresh.kumar@linaro.org, shiraz.hashim@st.com
Subject: Re: [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event
Date: Sun, 16 Dec 2012 23:11:45 -0800	[thread overview]
Message-ID: <20121217071144.GA10898@core.coreip.homeip.net> (raw)
In-Reply-To: <20121213091004.GF27617@gmail.com>

On Thu, Dec 13, 2012 at 09:10:04AM +0000, Lee Jones wrote:
> On Thu, 13 Dec 2012, Vipul Kumar Samar wrote:
> 
> > stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add
> > BTN_TOUCH reporting capability to the stmpe touchscreen driver.
> > 
> > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > ---
> >  drivers/input/touchscreen/stmpe-ts.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> > index 076442a..c3399a1 100644
> > --- a/drivers/input/touchscreen/stmpe-ts.c
> > +++ b/drivers/input/touchscreen/stmpe-ts.c
> > @@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work)
> >  	__stmpe_reset_fifo(ts->stmpe);
> >  
> >  	input_report_abs(ts->idev, ABS_PRESSURE, 0);
> > +	input_report_key(ts->idev, BTN_TOUCH, 0);
> >  	input_sync(ts->idev);
> >  }
> >  
> > @@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
> >  	input_report_abs(ts->idev, ABS_X, x);
> >  	input_report_abs(ts->idev, ABS_Y, y);
> >  	input_report_abs(ts->idev, ABS_PRESSURE, z);
> > +	input_report_key(ts->idev, BTN_TOUCH, 1);
> >  	input_sync(ts->idev);
> >  
> >         /* flush the FIFO after we have read out our values. */
> > -- 
> > 1.7.2.2
> 
> So long as it's tested/working, the code looks fine so:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

Applied, thank you.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event
Date: Sun, 16 Dec 2012 23:11:45 -0800	[thread overview]
Message-ID: <20121217071144.GA10898@core.coreip.homeip.net> (raw)
In-Reply-To: <20121213091004.GF27617@gmail.com>

On Thu, Dec 13, 2012 at 09:10:04AM +0000, Lee Jones wrote:
> On Thu, 13 Dec 2012, Vipul Kumar Samar wrote:
> 
> > stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add
> > BTN_TOUCH reporting capability to the stmpe touchscreen driver.
> > 
> > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > ---
> >  drivers/input/touchscreen/stmpe-ts.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> > index 076442a..c3399a1 100644
> > --- a/drivers/input/touchscreen/stmpe-ts.c
> > +++ b/drivers/input/touchscreen/stmpe-ts.c
> > @@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work)
> >  	__stmpe_reset_fifo(ts->stmpe);
> >  
> >  	input_report_abs(ts->idev, ABS_PRESSURE, 0);
> > +	input_report_key(ts->idev, BTN_TOUCH, 0);
> >  	input_sync(ts->idev);
> >  }
> >  
> > @@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
> >  	input_report_abs(ts->idev, ABS_X, x);
> >  	input_report_abs(ts->idev, ABS_Y, y);
> >  	input_report_abs(ts->idev, ABS_PRESSURE, z);
> > +	input_report_key(ts->idev, BTN_TOUCH, 1);
> >  	input_sync(ts->idev);
> >  
> >         /* flush the FIFO after we have read out our values. */
> > -- 
> > 1.7.2.2
> 
> So long as it's tested/working, the code looks fine so:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

Applied, thank you.

-- 
Dmitry

  reply	other threads:[~2012-12-17  7:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13  5:27 [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event Vipul Kumar Samar
2012-12-13  5:27 ` Vipul Kumar Samar
2012-12-13  6:34 ` Viresh Kumar
2012-12-13  6:34   ` Viresh Kumar
2012-12-13  9:10 ` Lee Jones
2012-12-13  9:10   ` Lee Jones
2012-12-17  7:11   ` Dmitry Torokhov [this message]
2012-12-17  7:11     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121217071144.GA10898@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=shiraz.hashim@st.com \
    --cc=spear-devel@list.st.com \
    --cc=vipulkumar.samar@st.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.