Re: [PATCH] drm/i915: Implement workaround for broken CS tlb on i830/845

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Dec 17, 2012 at 01:33:01PM +0000, Chris Wilson wrote:
> On Sun, 16 Dec 2012 22:46:00 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > @@ -1087,6 +1087,9 @@ i915_error_first_batchbuffer(struct drm_i915_private *dev_priv,
> >  	if (!ring->get_seqno)
> >  		return NULL;
> >  
> > +	if (HAS_BROKEN_CS_TLB(dev_priv->dev))
> > +		return i915_error_object_create(dev_priv, ring->private);
> 
> Hmm, this is complicated by userspace opting out of the CS w/a, and
> imposes quite a burden upon our simple seq interface.

Right, I've written this without userspace being able to opt out in mind
... for the seq -ENOMEM, I guess it's just time to bite the bullet. Loads
of the error_states for the ilk fallout couldn't be dumped (but could be
captured) by bug reporters already :(
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch