From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/1] spi/atmel: add DT support
Date: Mon, 17 Dec 2012 17:15:13 +0000 [thread overview]
Message-ID: <20121217171513.9B0ED3E0BEC@localhost> (raw)
In-Reply-To: <20121217101351.GI23971-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
On Mon, 17 Dec 2012 11:13:51 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> On 01:03 Sat 15 Dec , Grant Likely wrote:
> > On Wed, 12 Dec 2012 16:13:08 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> > > On 14:37 Fri 23 Nov , Nicolas Ferre wrote:
> > > > On 11/23/2012 01:44 PM, Jean-Christophe PLAGNIOL-VILLARD :
> > > > > the atmel_spi use only gpio for chip select
> > > > >
> > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
> > > >
> > > > Seems simple and nice:
> > > >
> > > > Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > > grant is ok to have this for 3.8?
> >
> > Not sure how I missed this one. It's pretty straight forward and not
> > risky, so no problem. However;
> >
> > > > > the atmel_spi use only gpio for chip select
> >
> > I know you know how to write a proper commit message. I'll need
> > something better than the above before I commit it. I won't make you
> > resubmit the patch, but do send me a better description.
> >
> ok replace with this please
>
> spi/atmel: add DT support
>
> Use the newly introduce cs-gpios dt support on atmel.
> We do not use the hardware cs as it's wired and have buges and limitations.
> As the the controller's belief that only active-low devices/systems exists.
>
> As done on non-dt system.
Done, thanks.
g.
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] spi/atmel: add DT support
Date: Mon, 17 Dec 2012 17:15:13 +0000 [thread overview]
Message-ID: <20121217171513.9B0ED3E0BEC@localhost> (raw)
In-Reply-To: <20121217101351.GI23971@game.jcrosoft.org>
On Mon, 17 Dec 2012 11:13:51 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> On 01:03 Sat 15 Dec , Grant Likely wrote:
> > On Wed, 12 Dec 2012 16:13:08 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > > On 14:37 Fri 23 Nov , Nicolas Ferre wrote:
> > > > On 11/23/2012 01:44 PM, Jean-Christophe PLAGNIOL-VILLARD :
> > > > > the atmel_spi use only gpio for chip select
> > > > >
> > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > >
> > > > Seems simple and nice:
> > > >
> > > > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > > grant is ok to have this for 3.8?
> >
> > Not sure how I missed this one. It's pretty straight forward and not
> > risky, so no problem. However;
> >
> > > > > the atmel_spi use only gpio for chip select
> >
> > I know you know how to write a proper commit message. I'll need
> > something better than the above before I commit it. I won't make you
> > resubmit the patch, but do send me a better description.
> >
> ok replace with this please
>
> spi/atmel: add DT support
>
> Use the newly introduce cs-gpios dt support on atmel.
> We do not use the hardware cs as it's wired and have buges and limitations.
> As the the controller's belief that only active-low devices/systems exists.
>
> As done on non-dt system.
Done, thanks.
g.
next prev parent reply other threads:[~2012-12-17 17:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1349850454-21127-1-git-send-email-wenyou.yang@atmel.com>
[not found] ` <1349850454-21127-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-10 6:27 ` [PATCH 02/16] of_spi: add generic binding support to specify cs gpio Wenyou Yang
[not found] ` <1349850454-21127-3-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-15 16:50 ` Grant Likely
2012-11-15 16:50 ` Grant Likely
2012-11-15 19:19 ` [PATCH 1/1 v2] " Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 19:19 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1353007197-31491-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-11-21 15:17 ` Grant Likely
2012-11-21 15:17 ` Grant Likely
2012-11-23 12:44 ` [PATCH 1/1] spi/atmel: add DT support Jean-Christophe PLAGNIOL-VILLARD
2012-11-23 12:44 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1353674679-13158-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-11-23 13:37 ` Nicolas Ferre
2012-11-23 13:37 ` Nicolas Ferre
2012-12-12 15:13 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-12 15:13 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20121212151308.GK4398-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-12-15 1:03 ` Grant Likely
2012-12-15 1:03 ` Grant Likely
2012-12-17 10:13 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-17 10:13 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20121217101351.GI23971-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-12-17 17:15 ` Grant Likely [this message]
2012-12-17 17:15 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217171513.9B0ED3E0BEC@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.