From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: fixup overlay stolen memory leak
Date: Tue, 18 Dec 2012 16:07:40 +0100 [thread overview]
Message-ID: <20121218150733.GW5737@phenom.ffwll.local> (raw)
In-Reply-To: <84c8a8$70rcbb@orsmga001.jf.intel.com>
On Tue, Dec 18, 2012 at 02:48:39PM +0000, Chris Wilson wrote:
> On Tue, 18 Dec 2012 15:24:37 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > We need to clean up the overlay first, before taking down the
> > stolen memory allocator.
> >
> > This regression has been introducec in
> >
> > commit 8040513870399f1cb032cb8bc805df5042fedcdf
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Thu Nov 15 11:32:29 2012 +0000
> >
> > drm/i915: Allocate overlay registers from stolen memory
> >
> > Note: This is just a quick hack to shut up a warning in the module
> > unload code, so that I can check again whether we don't leak any
> > framebuffers.
Dropped this note, since it's no longer a hack ...
> > v2: Rework the patch a bit as suggested by Chris Wilson:
> > - move the overlay teardown up, into the modeset cleanup
> > - move the stolen mm takedown into i915_gem_cleanup_stolen
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> That organisation indeed makes more sense.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
... and merged it. Thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-12-18 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 14:24 [PATCH] drm/i915: fixup overlay stolen memory leak Daniel Vetter
2012-12-18 14:48 ` Chris Wilson
2012-12-18 15:07 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-10 23:07 Daniel Vetter
2012-12-10 23:50 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218150733.GW5737@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.