[PATCH] of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS

[PATCH] of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS

[Jonas Gorski]

Fixes the following warning:

include/linux/of_platform.h:106:13: warning: 'struct device' declared inside parameter list [enabled by default]
include/linux/of_platform.h:106:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Signed-off-by: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
---
 include/linux/of_platform.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
index b47d204..3863a4d 100644
--- a/include/linux/of_platform.h
+++ b/include/linux/of_platform.h
@@ -100,6 +100,7 @@ extern int of_platform_populate(struct device_node *root,
 
 #if !defined(CONFIG_OF_ADDRESS)
 struct of_dev_auxdata;
+struct device;
 static inline int of_platform_populate(struct device_node *root,
 					const struct of_device_id *matches,
 					const struct of_dev_auxdata *lookup,
-- 
1.7.10.4

Re: [PATCH] of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS

[Rob Herring]

On 12/15/2012 07:27 AM, Jonas Gorski wrote:
> Fixes the following warning:
> 
> include/linux/of_platform.h:106:13: warning: 'struct device' declared inside parameter list [enabled by default]
> include/linux/of_platform.h:106:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> 
> Signed-off-by: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
> ---

It seems like this never made it to the list, so hopefully this reply will.

Rob

>  include/linux/of_platform.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
> index b47d204..3863a4d 100644
> --- a/include/linux/of_platform.h
> +++ b/include/linux/of_platform.h
> @@ -100,6 +100,7 @@ extern int of_platform_populate(struct device_node *root,
>  
>  #if !defined(CONFIG_OF_ADDRESS)
>  struct of_dev_auxdata;
> +struct device;
>  static inline int of_platform_populate(struct device_node *root,
>  					const struct of_device_id *matches,
>  					const struct of_dev_auxdata *lookup,
> 

Re: [PATCH] of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS

[Jonas Gorski]

On 19 December 2012 16:12, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 12/15/2012 07:27 AM, Jonas Gorski wrote:
>> Fixes the following warning:
>>
>> include/linux/of_platform.h:106:13: warning: 'struct device' declared inside parameter list [enabled by default]
>> include/linux/of_platform.h:106:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>
>> Signed-off-by: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
>> ---
>
> It seems like this never made it to the list, so hopefully this reply will.
>
> Rob

It's in the archive, and I received it from the list (on a different
email account), so it whatever made it not there must be a local
issue:

<https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-December/024480.html>

Regards
Jonas

Re: [PATCH] of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS

[Grant Likely]

On Wed, 19 Dec 2012 09:12:59 -0600, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 12/15/2012 07:27 AM, Jonas Gorski wrote:
> > Fixes the following warning:
> > 
> > include/linux/of_platform.h:106:13: warning: 'struct device' declared inside parameter list [enabled by default]
> > include/linux/of_platform.h:106:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> > 
> > Signed-off-by: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
> > ---
> 
> It seems like this never made it to the list, so hopefully this reply will.
> 
> Rob

Applied, thanks.

Rob, I've added a signed-off-by tag for you since I *assume* you sign
off on receiving this patch under appropriate terms. I will expect to
hear from you if this is not the case.  :-p

g.