From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] spi: tegra: sequence compatible strings as per preference
Date: Wed, 19 Dec 2012 17:00:09 +0000 [thread overview]
Message-ID: <20121219170009.54EE83E0C34@localhost> (raw)
In-Reply-To: <20121110170741.GA17689-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> wrote:
> On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote:
> > On 11/09/2012 10:10 AM, Mark Brown wrote:
> > > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote:
> > >
> > >> However just FYI, it should not be necessary for correctness; The
> > >> DT matching order is supposed to be driven purely by the order of
> > >> the compatible values in the DT now, and not affected by the
> > >> order of values in the table. (This wasn't always the case, but
> > >> was a bug that was fixed IIRC by Thierry Reding).
> > >
> > > I guess the driver is being used backported in older kernels which
> > > don't have that fix?
> >
> > That sounds likely. Laxman, it'd be a good idea to track down the fix
> > to the DT matching code and backport it, so that hard-to debug issues
> > aren't caused by the lack of that patch!
>
> Unfortunately the patch that was supposed to fixed this caused a
> regression and was therefore reverted. Rob (Cc'ed) said there was a
> patch to fix it properly and was supposed to go into 3.6 but it seems
> that never happened. Rob, what's the status on this?
>
> The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478
Rob, ping on this. I think we talked about it on IRC, but I cannot
remember what was said.... I must be getting old.
g.
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Thierry Reding <thierry.reding@avionic-design.de>,
Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH] spi: tegra: sequence compatible strings as per preference
Date: Wed, 19 Dec 2012 17:00:09 +0000 [thread overview]
Message-ID: <20121219170009.54EE83E0C34@localhost> (raw)
In-Reply-To: <20121110170741.GA17689@avionic-0098.mockup.avionic-design.de>
On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding <thierry.reding@avionic-design.de> wrote:
> On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote:
> > On 11/09/2012 10:10 AM, Mark Brown wrote:
> > > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote:
> > >
> > >> However just FYI, it should not be necessary for correctness; The
> > >> DT matching order is supposed to be driven purely by the order of
> > >> the compatible values in the DT now, and not affected by the
> > >> order of values in the table. (This wasn't always the case, but
> > >> was a bug that was fixed IIRC by Thierry Reding).
> > >
> > > I guess the driver is being used backported in older kernels which
> > > don't have that fix?
> >
> > That sounds likely. Laxman, it'd be a good idea to track down the fix
> > to the DT matching code and backport it, so that hard-to debug issues
> > aren't caused by the lack of that patch!
>
> Unfortunately the patch that was supposed to fixed this caused a
> regression and was therefore reverted. Rob (Cc'ed) said there was a
> patch to fix it properly and was supposed to go into 3.6 but it seems
> that never happened. Rob, what's the status on this?
>
> The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478
Rob, ping on this. I think we talked about it on IRC, but I cannot
remember what was said.... I must be getting old.
g.
next prev parent reply other threads:[~2012-12-19 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 9:07 [PATCH] spi: tegra: sequence compatible strings as per preference Laxman Dewangan
2012-11-09 9:07 ` Laxman Dewangan
2012-11-09 16:43 ` Mark Brown
2012-11-09 17:04 ` Stephen Warren
2012-11-09 17:10 ` Mark Brown
[not found] ` <20121109171008.GX23807-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-09 17:28 ` Stephen Warren
2012-11-09 17:28 ` Stephen Warren
2012-11-10 17:07 ` Thierry Reding
[not found] ` <20121110170741.GA17689-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-12-19 17:00 ` Grant Likely [this message]
2012-12-19 17:00 ` Grant Likely
2013-01-08 7:12 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219170009.54EE83E0C34@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.