From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Padmavathi Venna <padma.v@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree-discuss@lists.ozlabs.org, jassisinghbrar@gmail.com,
kgene.kim@samsung.com, sbkim73@samsung.com, tiwai@suse.de,
ben-linux@fluff.org, lrg@ti.com
Subject: Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s
Date: Wed, 19 Dec 2012 17:09:37 +0000 [thread overview]
Message-ID: <20121219170937.GV4985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121219132414.2CF653E0AD7@localhost>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote:
> On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna <padma.v@samsung.com> wrote:
> > +- compatible : "samsung,samsung-i2s"
> Isn't that kind of redundant? :-)
> The format of the compatible strings should be "<vendor>,<part-number>-i2s".
> Please be specific about the part number that you're doing the binding
> for. For example; use "samsung,exynos4210-i2s" instead of "samsung,exynos-i2s".
There are actually versioned IPs here (where the versions are used
publically in a few places) but it's not clearly documented which is
which. It would be reasonable to use the IP versions here I think.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s
Date: Wed, 19 Dec 2012 17:09:37 +0000 [thread overview]
Message-ID: <20121219170937.GV4985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121219132414.2CF653E0AD7@localhost>
On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote:
> On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna <padma.v@samsung.com> wrote:
> > +- compatible : "samsung,samsung-i2s"
> Isn't that kind of redundant? :-)
> The format of the compatible strings should be "<vendor>,<part-number>-i2s".
> Please be specific about the part number that you're doing the binding
> for. For example; use "samsung,exynos4210-i2s" instead of "samsung,exynos-i2s".
There are actually versioned IPs here (where the versions are used
publically in a few places) but it's not clearly documented which is
which. It would be reasonable to use the IP versions here I think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121219/840a7bdc/attachment.sig>
next prev parent reply other threads:[~2012-12-19 17:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 10:42 [PATCH V5 0/2] Add DT support for i2s Padmavathi Venna
2012-12-13 10:42 ` Padmavathi Venna
2012-12-13 10:42 ` [PATCH V5 1/2] ASoC: Samsung: Rename samsung i2s secondary device name Padmavathi Venna
2012-12-13 10:42 ` Padmavathi Venna
2012-12-13 10:42 ` [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s Padmavathi Venna
2012-12-13 10:42 ` Padmavathi Venna
2012-12-19 13:24 ` Grant Likely
2012-12-19 13:24 ` Grant Likely
2012-12-19 17:09 ` Mark Brown [this message]
2012-12-19 17:09 ` Mark Brown
2012-12-19 17:37 ` Kukjin Kim
2012-12-19 17:37 ` Kukjin Kim
[not found] ` <20121219170937.GV4985-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-21 11:36 ` Padma Venkat
2012-12-21 11:36 ` Padma Venkat
2012-12-21 19:02 ` Kukjin Kim
2012-12-21 19:02 ` Kukjin Kim
2012-12-24 4:03 ` Padma Venkat
2012-12-24 4:03 ` Padma Venkat
2012-12-26 10:51 ` Padma Venkat
2012-12-26 10:51 ` Padma Venkat
2012-12-27 16:48 ` Mark Brown
2012-12-27 16:48 ` Mark Brown
2012-12-23 23:13 ` Kukjin Kim
2012-12-23 23:13 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219170937.GV4985@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.