* [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors
@ 2012-12-19 16:01 Guenter Roeck
2012-12-19 16:17 ` Jean Delvare
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-19 16:01 UTC (permalink / raw)
To: lm-sensors
Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor
variable type is unsigned. Fix by declaring divisor as signed variable.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Fix by changing divisor variable type instead of dividend variable type
drivers/hwmon/emc6w201.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
index a98c917..789bd4f 100644
--- a/drivers/hwmon/emc6w201.c
+++ b/drivers/hwmon/emc6w201.c
@@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev)
* Sysfs callback functions
*/
-static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
+static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
char *buf)
--
1.7.9.7
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors
2012-12-19 16:01 [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Guenter Roeck
@ 2012-12-19 16:17 ` Jean Delvare
2012-12-19 16:26 ` Guenter Roeck
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2012-12-19 16:17 UTC (permalink / raw)
To: lm-sensors
Hi Guenter,
On Wed, 19 Dec 2012 08:01:48 -0800, Guenter Roeck wrote:
> Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor
> variable type is unsigned. Fix by declaring divisor as signed variable.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Fix by changing divisor variable type instead of dividend variable type
>
> drivers/hwmon/emc6w201.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
> index a98c917..789bd4f 100644
> --- a/drivers/hwmon/emc6w201.c
> +++ b/drivers/hwmon/emc6w201.c
> @@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev)
> * Sysfs callback functions
> */
>
> -static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> +static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
>
> static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
> char *buf)
Applied, thanks.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors
2012-12-19 16:01 [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Guenter Roeck
2012-12-19 16:17 ` Jean Delvare
@ 2012-12-19 16:26 ` Guenter Roeck
2012-12-19 16:27 ` Jean Delvare
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-19 16:26 UTC (permalink / raw)
To: lm-sensors
On Wed, Dec 19, 2012 at 05:17:00PM +0100, Jean Delvare wrote:
> Hi Guenter,
>
> On Wed, 19 Dec 2012 08:01:48 -0800, Guenter Roeck wrote:
> > Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor
> > variable type is unsigned. Fix by declaring divisor as signed variable.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > v2: Fix by changing divisor variable type instead of dividend variable type
> >
> > drivers/hwmon/emc6w201.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
> > index a98c917..789bd4f 100644
> > --- a/drivers/hwmon/emc6w201.c
> > +++ b/drivers/hwmon/emc6w201.c
> > @@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev)
> > * Sysfs callback functions
> > */
> >
> > -static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > +static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> >
> > static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
> > char *buf)
>
> Applied, thanks.
>
Hi Jean,
Can you take the kernel.h patch as well ?
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors
2012-12-19 16:01 [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Guenter Roeck
2012-12-19 16:17 ` Jean Delvare
2012-12-19 16:26 ` Guenter Roeck
@ 2012-12-19 16:27 ` Jean Delvare
2012-12-19 21:35 ` Jean Delvare
2012-12-19 22:38 ` Guenter Roeck
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2012-12-19 16:27 UTC (permalink / raw)
To: lm-sensors
On Wed, 19 Dec 2012 08:26:10 -0800, Guenter Roeck wrote:
> On Wed, Dec 19, 2012 at 05:17:00PM +0100, Jean Delvare wrote:
> > Hi Guenter,
> >
> > On Wed, 19 Dec 2012 08:01:48 -0800, Guenter Roeck wrote:
> > > Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor
> > > variable type is unsigned. Fix by declaring divisor as signed variable.
> > >
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > > v2: Fix by changing divisor variable type instead of dividend variable type
> > >
> > > drivers/hwmon/emc6w201.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
> > > index a98c917..789bd4f 100644
> > > --- a/drivers/hwmon/emc6w201.c
> > > +++ b/drivers/hwmon/emc6w201.c
> > > @@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev)
> > > * Sysfs callback functions
> > > */
> > >
> > > -static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > > +static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > >
> > > static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
> > > char *buf)
> >
> > Applied, thanks.
>
> Can you take the kernel.h patch as well ?
Yes I can. I'm sending my hwmon patches to Linus tonight.
For clarity: both patches are needed but they are otherwise
independent, right?
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors
2012-12-19 16:01 [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Guenter Roeck
` (2 preceding siblings ...)
2012-12-19 16:27 ` Jean Delvare
@ 2012-12-19 21:35 ` Jean Delvare
2012-12-19 22:38 ` Guenter Roeck
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2012-12-19 21:35 UTC (permalink / raw)
To: lm-sensors
On Wed, 19 Dec 2012 17:27:33 +0100, Jean Delvare wrote:
> On Wed, 19 Dec 2012 08:26:10 -0800, Guenter Roeck wrote:
> > On Wed, Dec 19, 2012 at 05:17:00PM +0100, Jean Delvare wrote:
> > > Hi Guenter,
> > >
> > > On Wed, 19 Dec 2012 08:01:48 -0800, Guenter Roeck wrote:
> > > > Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor
> > > > variable type is unsigned. Fix by declaring divisor as signed variable.
> > > >
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > > ---
> > > > v2: Fix by changing divisor variable type instead of dividend variable type
> > > >
> > > > drivers/hwmon/emc6w201.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
> > > > index a98c917..789bd4f 100644
> > > > --- a/drivers/hwmon/emc6w201.c
> > > > +++ b/drivers/hwmon/emc6w201.c
> > > > @@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev)
> > > > * Sysfs callback functions
> > > > */
> > > >
> > > > -static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > > > +static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > > >
> > > > static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
> > > > char *buf)
> > >
> > > Applied, thanks.
> >
> > Can you take the kernel.h patch as well ?
>
> Yes I can. I'm sending my hwmon patches to Linus tonight.
>
> For clarity: both patches are needed but they are otherwise
> independent, right?
Note: I finally refrained from including both commits in my pull
request, I want to take a closer look first. If nothing else, to decide
whether they should go to stable trees or not.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors
2012-12-19 16:01 [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Guenter Roeck
` (3 preceding siblings ...)
2012-12-19 21:35 ` Jean Delvare
@ 2012-12-19 22:38 ` Guenter Roeck
4 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2012-12-19 22:38 UTC (permalink / raw)
To: lm-sensors
On Wed, Dec 19, 2012 at 10:35:02PM +0100, Jean Delvare wrote:
> On Wed, 19 Dec 2012 17:27:33 +0100, Jean Delvare wrote:
> > On Wed, 19 Dec 2012 08:26:10 -0800, Guenter Roeck wrote:
> > > On Wed, Dec 19, 2012 at 05:17:00PM +0100, Jean Delvare wrote:
> > > > Hi Guenter,
> > > >
> > > > On Wed, 19 Dec 2012 08:01:48 -0800, Guenter Roeck wrote:
> > > > > Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor
> > > > > variable type is unsigned. Fix by declaring divisor as signed variable.
> > > > >
> > > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > > > ---
> > > > > v2: Fix by changing divisor variable type instead of dividend variable type
> > > > >
> > > > > drivers/hwmon/emc6w201.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c
> > > > > index a98c917..789bd4f 100644
> > > > > --- a/drivers/hwmon/emc6w201.c
> > > > > +++ b/drivers/hwmon/emc6w201.c
> > > > > @@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev)
> > > > > * Sysfs callback functions
> > > > > */
> > > > >
> > > > > -static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > > > > +static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 };
> > > > >
> > > > > static ssize_t show_in(struct device *dev, struct device_attribute *devattr,
> > > > > char *buf)
> > > >
> > > > Applied, thanks.
> > >
> > > Can you take the kernel.h patch as well ?
> >
> > Yes I can. I'm sending my hwmon patches to Linus tonight.
> >
> > For clarity: both patches are needed but they are otherwise
> > independent, right?
>
> Note: I finally refrained from including both commits in my pull
> request, I want to take a closer look first. If nothing else, to decide
> whether they should go to stable trees or not.
>
Yes - 3.6 and later.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-19 22:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-19 16:01 [lm-sensors] [PATCH v2] hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Guenter Roeck
2012-12-19 16:17 ` Jean Delvare
2012-12-19 16:26 ` Guenter Roeck
2012-12-19 16:27 ` Jean Delvare
2012-12-19 21:35 ` Jean Delvare
2012-12-19 22:38 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.