From: Thierry Reding <thierry.reding@avionic-design.de>
To: Andrew Murray <Andrew.Murray@arm.com>
Cc: linux-pci@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Michal Simek <monstr@monstr.eu>,
Rob Herring <robherring2@gmail.com>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
Rob Herring <rob.herring@calxeda.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Liviu Dudau <liviu.dudau@arm.com>
Subject: Re: [PATCH] pci: Provide support for parsing PCI DT ranges property
Date: Thu, 20 Dec 2012 09:25:00 +0100 [thread overview]
Message-ID: <20121220082500.GA32617@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20121212163749.GA17371@arm.com>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On Wed, Dec 12, 2012 at 04:37:50PM +0000, Andrew Murray wrote:
[...]
> diff --git a/drivers/of/address.c b/drivers/of/address.c
[...]
> + start = of_get_property(node, "ranges", &rlen);
> + if (start == NULL)
> + return NULL;
> +
> + end = start + rlen;
I'm currently rewriting large parts of the Tegra PCIe controller driver
and I'm trying to use this new API. This seems to work fine, except that
I think this line needs to be:
end = start + rlen / sizeof(__be32);
Otherwise we'll try to process 4 times as many ranges as there are.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Andrew Murray <Andrew.Murray@arm.com>
Cc: Michal Simek <monstr@monstr.eu>,
linux-pci@vger.kernel.org,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Rob Herring <rob.herring@calxeda.com>,
Rob Herring <robherring2@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] pci: Provide support for parsing PCI DT ranges property
Date: Thu, 20 Dec 2012 09:25:00 +0100 [thread overview]
Message-ID: <20121220082500.GA32617@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20121212163749.GA17371@arm.com>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On Wed, Dec 12, 2012 at 04:37:50PM +0000, Andrew Murray wrote:
[...]
> diff --git a/drivers/of/address.c b/drivers/of/address.c
[...]
> + start = of_get_property(node, "ranges", &rlen);
> + if (start == NULL)
> + return NULL;
> +
> + end = start + rlen;
I'm currently rewriting large parts of the Tegra PCIe controller driver
and I'm trying to use this new API. This seems to work fine, except that
I think this line needs to be:
end = start + rlen / sizeof(__be32);
Otherwise we'll try to process 4 times as many ranges as there are.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Andrew Murray <Andrew.Murray-5wv7dgnIgG8@public.gmane.org>
Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linuxppc-dev
<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH] pci: Provide support for parsing PCI DT ranges property
Date: Thu, 20 Dec 2012 09:25:00 +0100 [thread overview]
Message-ID: <20121220082500.GA32617@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20121212163749.GA17371-5wv7dgnIgG8@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 549 bytes --]
On Wed, Dec 12, 2012 at 04:37:50PM +0000, Andrew Murray wrote:
[...]
> diff --git a/drivers/of/address.c b/drivers/of/address.c
[...]
> + start = of_get_property(node, "ranges", &rlen);
> + if (start == NULL)
> + return NULL;
> +
> + end = start + rlen;
I'm currently rewriting large parts of the Tegra PCIe controller driver
and I'm trying to use this new API. This seems to work fine, except that
I think this line needs to be:
end = start + rlen / sizeof(__be32);
Otherwise we'll try to process 4 times as many ranges as there are.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2012-12-20 8:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 16:37 [PATCH] pci: Provide support for parsing PCI DT ranges property Andrew Murray
2012-12-12 16:37 ` Andrew Murray
2012-12-13 9:13 ` Thierry Reding
2012-12-13 9:13 ` Thierry Reding
2012-12-13 9:13 ` Thierry Reding
2012-12-13 9:45 ` Andrew Murray
2012-12-13 9:45 ` Andrew Murray
2012-12-13 10:03 ` Thierry Reding
2012-12-13 10:03 ` Thierry Reding
2012-12-13 10:03 ` Thierry Reding
2012-12-13 10:34 ` Andrew Murray
2012-12-13 10:34 ` Andrew Murray
2012-12-15 1:06 ` Grant Likely
2012-12-15 1:06 ` Grant Likely
2013-01-14 9:24 ` Andrew Murray
2013-01-14 9:24 ` Andrew Murray
2012-12-20 8:25 ` Thierry Reding [this message]
2012-12-20 8:25 ` Thierry Reding
2012-12-20 8:25 ` Thierry Reding
2013-01-14 9:15 ` Andrew Murray
2013-01-14 9:15 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220082500.GA32617@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=Andrew.Murray@arm.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liviu.dudau@arm.com \
--cc=monstr@monstr.eu \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.